From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smqw0-00034t-0i for qemu-devel@nongnu.org; Thu, 05 Jul 2012 14:37:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Smqvy-0006WG-0t for qemu-devel@nongnu.org; Thu, 05 Jul 2012 14:37:47 -0400 Received: from mail-gg0-f173.google.com ([209.85.161.173]:36013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smqvx-0006WA-QL for qemu-devel@nongnu.org; Thu, 05 Jul 2012 14:37:45 -0400 Received: by ggnp1 with SMTP id p1so8353958ggn.4 for ; Thu, 05 Jul 2012 11:37:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4FF4711E.1090107@redhat.com> References: <1340984094-5451-1-git-send-email-armbru@redhat.com> <1340984094-5451-19-git-send-email-armbru@redhat.com> <20120702125515.GA16482@stefanha-thinkpad.localdomain> <4FF19D21.20005@suse.de> <4FF352C4.6040209@suse.de> <4FF46D00.9090008@redhat.com> <4FF4711E.1090107@redhat.com> From: Blue Swirl Date: Thu, 5 Jul 2012 18:37:21 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, aliguori@us.ibm.com, Stefan Hajnoczi , Stefan Hajnoczi , Markus Armbruster , qemu-devel@nongnu.org, Paolo Bonzini , =?UTF-8?Q?Andreas_F=C3=A4rber?= On Wed, Jul 4, 2012 at 4:36 PM, Eric Blake wrote: > On 07/04/2012 10:19 AM, Paolo Bonzini wrote: >> Il 03/07/2012 22:15, Andreas F=C3=A4rber ha scritto: >>>>> >>>>> I'd also vote for %u. PRI*32 do not seem very useful compared to plai= n >>>>> int versions. >>> If it's not useful we should use unsigned int. >> >> It just means that we're assuming 32-bit ints, which is a fact. The day >> an IL32 platform appears that has "typedef long int32_t", we'll worry >> about PRIu32. > > Newlib's does just that, on platforms that __have_long32. > Which makes Cygwin a great platform for flushing out these sorts of type > discrepancies (since cygwin inherits from newlib). > > http://sourceware.org/cgi-bin/cvsweb.cgi/src/newlib/libc/include/stdint.h= .diff?r1=3D1.8&r2=3D1.9&cvsroot=3Dsrc&f=3Dh Interesting, my thoughts went pretty much along Paolo's line. Now I think PRI*32 indeed makes some sense. But we don't support Cygwin builds (only mingw), would that be useful? > > -- > Eric Blake eblake@redhat.com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > > >