From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QypdP-0000M3-Cq for qemu-devel@nongnu.org; Wed, 31 Aug 2011 14:35:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QypdO-0003A5-4Z for qemu-devel@nongnu.org; Wed, 31 Aug 2011 14:35:35 -0400 Received: from mail-qy0-f173.google.com ([209.85.216.173]:43511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QypdO-00039x-1x for qemu-devel@nongnu.org; Wed, 31 Aug 2011 14:35:34 -0400 Received: by qyk31 with SMTP id 31so3759534qyk.4 for ; Wed, 31 Aug 2011 11:35:33 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1314752751.84463.YahooMailClassic@web27003.mail.ukl.yahoo.com> <4E5D8BAA.9010302@codemonkey.ws> <4E5D9570.1030201@codemonkey.ws> <4E5E3789.3010603@codemonkey.ws> <4E5E39DF.3080609@codemonkey.ws> <4E5E4540.5030408@codemonkey.ws> <4E5E5BF3.50801@codemonkey.ws> From: Blue Swirl Date: Wed, 31 Aug 2011 18:35:13 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org, bifferos On Wed, Aug 31, 2011 at 4:24 PM, malc wrote: > On Wed, 31 Aug 2011, Anthony Liguori wrote: > >> On 08/31/2011 09:35 AM, malc wrote: >> > On Wed, 31 Aug 2011, Anthony Liguori wrote: >> > >> > > Upper case field names are not okay. =C2=A0If you think coding style= isn't >> > > clear, >> > > that's a bug in coding style. >> > >> > Sez hu? Coding style is garbage that should be thrown out of the windo= w. >> > As for looking, yeah, i'm looking at usb with it's lovely hungarian >> > fields, should we stampede to "fix" it? >> > >> > If the one who's going to maintain the code is fine with whatever nami= ng >> > is used so be it. >> >> No. =C2=A0That's how we got into the coding style mess we're in in the f= irst >> place. > > boblycat.org/~malc/right.ogg > >> >> There's no benefit to going through and changing existing code but new c= ode >> needs to be consistent with the vast majority of code in the rest of the= tree. >> It's about overall code base consistency and maintainability. >> > > Hand waving, for instance vast majority of the code never used the > mandatory braces, the choice was arbitrary. No, mandatory braces are better than the alternative. The choice has been made and it has been mostly upheld.