From: Blue Swirl <blauwirbel@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: blueswirl@gmail.com, Andreas Schwab <schwab@linux-m68k.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:
Date: Thu, 12 Jul 2012 20:28:57 +0000 [thread overview]
Message-ID: <CAAu8pHto2VoNo+z6JkJE-nRAPEYmJKruDOHQ=ykzv_+gnULYaA@mail.gmail.com> (raw)
In-Reply-To: <4FFD7790.20201@redhat.com>
On Wed, Jul 11, 2012 at 12:54 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 08.07.2012 14:09, schrieb Andreas Schwab:
>> blauwirbel@gmail.com writes:
>>
>>> + pstrcpy(bs->backing_format, sizeof(bs->backing_format),
>>> + backing_fmt ? backing_file : "");
>>
>> s/backing_file/backing_fmt/
>
> Which is why such changes are probably a bad idea. Even more so if they
> aren't scripted.
Maybe your patches are perfect from day one, but all patches can be
buggy. Review should catch some of the bugs, others may be found
later. It's not possible to script this because expr1 may have side
effects.
>
> Does this patch improve anything? Last time I checked, qemu only
> compiled on gcc anyway.
It improves C99 compliance. GCC extensions should not be used unless
absolutely required. In the future, it should be possible to compile
QEMU with any C compiler, AREG0 patches remove the biggest obstacle.
>
> Kevin
next prev parent reply other threads:[~2012-07-12 20:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 11:51 [Qemu-devel] [PATCH 0/5] portability patches blauwirbel
2012-07-08 11:51 ` [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?: blauwirbel
2012-07-08 12:09 ` Andreas Schwab
2012-07-08 12:14 ` Blue Swirl
2012-07-11 12:54 ` Kevin Wolf
2012-07-11 13:09 ` Peter Maydell
2012-07-11 13:12 ` 陳韋任 (Wei-Ren Chen)
2012-07-12 20:34 ` Blue Swirl
2012-07-12 20:28 ` Blue Swirl [this message]
2012-07-12 21:08 ` Peter Maydell
2012-07-13 14:47 ` Blue Swirl
2012-07-13 9:05 ` Kevin Wolf
2012-07-13 14:58 ` Blue Swirl
2012-07-09 7:35 ` Markus Armbruster
2012-07-10 19:09 ` Blue Swirl
2012-07-08 11:51 ` [Qemu-devel] [PATCH 2/5] Avoid returning void blauwirbel
2012-07-08 11:51 ` [Qemu-devel] [PATCH 3/5] Use __asm__ instead of asm or __asm blauwirbel
2012-07-08 11:51 ` [Qemu-devel] [PATCH 4/5] Avoid unportable %m format blauwirbel
2012-07-10 20:53 ` Anthony Liguori
2012-07-10 21:12 ` Stefan Weil
2012-07-10 21:23 ` Anthony Liguori
2012-07-12 19:43 ` Blue Swirl
2012-07-08 11:51 ` [Qemu-devel] [PATCH 5/5] Avoid redefining inline blauwirbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAu8pHto2VoNo+z6JkJE-nRAPEYmJKruDOHQ=ykzv_+gnULYaA@mail.gmail.com' \
--to=blauwirbel@gmail.com \
--cc=blueswirl@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.