From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36643)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Sv60Z-0007aR-CP
	for qemu-devel@nongnu.org; Sat, 28 Jul 2012 08:20:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Sv60U-0005ib-Gz
	for qemu-devel@nongnu.org; Sat, 28 Jul 2012 08:20:35 -0400
Received: from mail-gh0-f173.google.com ([209.85.160.173]:65217)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Sv60U-0005iX-D1
	for qemu-devel@nongnu.org; Sat, 28 Jul 2012 08:20:30 -0400
Received: by ghrr14 with SMTP id r14so3835754ghr.4
	for <qemu-devel@nongnu.org>; Sat, 28 Jul 2012 05:20:30 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA9MWKvTcq6eYEBeqn2Wv7z8SaKZr4rpw5m0_3B07G-AQg@mail.gmail.com>
References: <1342620628-12751-1-git-send-email-peter.maydell@linaro.org>
	<1342620628-12751-12-git-send-email-peter.maydell@linaro.org>
	<CAAu8pHsA5A0wmUMMQFJzRvoBU85TFS9nJx6ibWL+MQWDGgCkqw@mail.gmail.com>
	<CAFEAcA-zs=r4+c-ruih0Xf9v6vQcJVv8XNfh0BQDVhqoXw+w3w@mail.gmail.com>
	<CAAu8pHu0crC1ZFm=fbYX3gmaavFFZ+sTSCQKTb7j5S+KWJh3zQ@mail.gmail.com>
	<CAFEAcA9MWKvTcq6eYEBeqn2Wv7z8SaKZr4rpw5m0_3B07G-AQg@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 28 Jul 2012 12:20:09 +0000
Message-ID: <CAAu8pHtyKLGKjXy_8hHNw0jEf3NRZ4QxM2+tUYf9E_DcfoE2ig@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing
 failures when compiling tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, patches@linaro.org

On Sat, Jul 28, 2012 at 12:14 PM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 28 July 2012 13:09, Blue Swirl <blauwirbel@gmail.com> wrote:
>> On Sat, Jul 28, 2012 at 10:57 AM, Peter Maydell
>> <peter.maydell@linaro.org> wrote:
>>> On 28 July 2012 10:04, Blue Swirl <blauwirbel@gmail.com> wrote:
>>>>, I'm getting configure breakage in some cases:
>>>
>>> The thesis of the patch series is that these represent bugs to be fixed.
>>
>> Yes, but then the errors should be fixed by the series. When adding
>> new GCC warning flags, I also fixed the causes for the warning first.
>> Committing known build breakages is not OK.
>
> I fixed all the ones I saw on my system, obviously. I'll have a look
> at this one.
>
> I think it would be worth committing patches 1-10 now anyway : those fix
> configure issues (patch 1 in particular fixes the problem of tests
> silently failing when they should pass).

OK, I'll test those.

>
> -- PMM