From mboxrd@z Thu Jan 1 00:00:00 1970 From: Blue Swirl Subject: Re: [PATCH 4/4] kvm: i386: Add classic PCI device assignment Date: Sat, 8 Sep 2012 08:06:42 +0000 Message-ID: References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <87k3wjyy0e.fsf@codemonkey.ws> <503E227B.40904@suse.de> <874nndmrjs.fsf@codemonkey.ws> <50476F3E.7000100@redhat.com> <87wr081nq4.fsf@codemonkey.ws> <50486270.9020504@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Alexey Kardashevskiy , Marcelo Tosatti , qemu-devel@nongnu.org, Alex Williamson , Jan Kiszka , Anthony Liguori , qemu-ppc , =?UTF-8?Q?Andreas_F=C3=A4rber?= To: Avi Kivity Return-path: In-Reply-To: <50486270.9020504@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On Thu, Sep 6, 2012 at 8:44 AM, Avi Kivity wrote: > On 09/05/2012 10:04 PM, Blue Swirl wrote: >> >> Reinventing a disassembler for ever growing x86 assembly is >> no fun. > > We can try linking to a disassembler library. I use udis86 to > disassemble instructions in kvm tracepoints > (http://udis86.git.sourceforge.net/git/gitweb.cgi?p=udis86/udis86;a=shortlog), > it's maintained but not heavily so. I think commonality with KVM would be preferred. The library looks neat and based on changelog, more actively developed than BSD DDB. > > Of course for non-x86 we'd need to continue using binutils; this is > about copying code vs. libraries, not about licensing. For most architectures, pre-GPLv3 binutils is good enough since the instruction set does not change anymore. Maybe only PPC and Sparc64 still change besides x86. New CPUs types more recent than 2007 will have problems. > > > -- > error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAG4K-0002Vn-E1 for qemu-devel@nongnu.org; Sat, 08 Sep 2012 04:07:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TAG4J-0004qC-Bm for qemu-devel@nongnu.org; Sat, 08 Sep 2012 04:07:08 -0400 MIME-Version: 1.0 In-Reply-To: <50486270.9020504@redhat.com> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <87k3wjyy0e.fsf@codemonkey.ws> <503E227B.40904@suse.de> <874nndmrjs.fsf@codemonkey.ws> <50476F3E.7000100@redhat.com> <87wr081nq4.fsf@codemonkey.ws> <50486270.9020504@redhat.com> From: Blue Swirl Date: Sat, 8 Sep 2012 08:06:42 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Alexey Kardashevskiy , Marcelo Tosatti , qemu-devel@nongnu.org, Alex Williamson , Jan Kiszka , Anthony Liguori , qemu-ppc , =?UTF-8?Q?Andreas_F=C3=A4rber?= On Thu, Sep 6, 2012 at 8:44 AM, Avi Kivity wrote: > On 09/05/2012 10:04 PM, Blue Swirl wrote: >> >> Reinventing a disassembler for ever growing x86 assembly is >> no fun. > > We can try linking to a disassembler library. I use udis86 to > disassemble instructions in kvm tracepoints > (http://udis86.git.sourceforge.net/git/gitweb.cgi?p=udis86/udis86;a=shortlog), > it's maintained but not heavily so. I think commonality with KVM would be preferred. The library looks neat and based on changelog, more actively developed than BSD DDB. > > Of course for non-x86 we'd need to continue using binutils; this is > about copying code vs. libraries, not about licensing. For most architectures, pre-GPLv3 binutils is good enough since the instruction set does not change anymore. Maybe only PPC and Sparc64 still change besides x86. New CPUs types more recent than 2007 will have problems. > > > -- > error compiling committee.c: too many arguments to function