All of lore.kernel.org
 help / color / mirror / Atom feed
From: Blue Swirl <blauwirbel@gmail.com>
To: Paul Brook <paul@codesourcery.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 0/6] ARM: AREG0 conversion
Date: Mon, 26 Mar 2012 17:02:08 +0000	[thread overview]
Message-ID: <CAAu8pHuGABQOus7ymNh3WJ_32iLL71qgfFz4=8f=HODsgJ2fOg@mail.gmail.com> (raw)
In-Reply-To: <201203261405.13760.paul@codesourcery.com>

On Mon, Mar 26, 2012 at 13:05, Paul Brook <paul@codesourcery.com> wrote:
>> On 24 March 2012 18:58, Blue Swirl <blauwirbel@gmail.com> wrote:
>> > v2: fix patch 1, tweak patch 2 and rebase to master.
>> >
>> > URL     git://repo.or.cz/qemu/blueswirl.git
>> >        http://repo.or.cz/r/qemu/blueswirl.git
>> >
>> > Blue Swirl (6):
>> >  arm: move neon_tbl to neon_helper.c
>> >  arm: move saturating arithmetic to helper.c
>> >  arm: move other arithmetic to helper.c
>> >  arm: move cpsr and banked register access to helper.c
>> >  arm: move exception and wfi helpers to helper.c
>> >  arm: move load and store helpers, switch to AREG0 free mode
>>
>> The patches themselves look OK, but do we really want to take
>> a 5% performance hit for this cleanup?
>
> I have a similar concern.  I'd like to at least have some idea where this
> slowdown is coming from.

At least stack protector is protecting more code than before (for
example TLB miss handler), but could overhead from that amount to 5%?

Otherwise there should be just a few extra register moves here and
there, that should be cheap on modern processors.

  reply	other threads:[~2012-03-26 17:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-24 18:58 [Qemu-devel] [PATCH v2 0/6] ARM: AREG0 conversion Blue Swirl
2012-03-25 22:29 ` Richard Henderson
2012-03-26 11:52 ` Peter Maydell
2012-03-26 12:46   ` Lluís Vilanova
2012-03-26 12:48     ` Andreas Färber
2012-03-26 13:05   ` Paul Brook
2012-03-26 17:02     ` Blue Swirl [this message]
2012-03-26 17:59       ` Lluís Vilanova
2012-03-27 13:40       ` Laurent Desnogues
2012-03-27 16:48         ` Blue Swirl
2012-03-27 17:01           ` Laurent Desnogues
2012-03-27 19:59             ` Artyom Tarasenko
2012-03-29 15:42               ` Laurent Desnogues
2012-03-29 16:28                 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAu8pHuGABQOus7ymNh3WJ_32iLL71qgfFz4=8f=HODsgJ2fOg@mail.gmail.com' \
    --to=blauwirbel@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.