From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyptx-0002J9-Qa for qemu-devel@nongnu.org; Wed, 31 Aug 2011 14:52:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QypoQ-0005oK-6w for qemu-devel@nongnu.org; Wed, 31 Aug 2011 14:46:59 -0400 Received: from mail-qw0-f47.google.com ([209.85.216.47]:60377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QypoQ-0005oG-33 for qemu-devel@nongnu.org; Wed, 31 Aug 2011 14:46:58 -0400 Received: by qwh5 with SMTP id 5so807371qwh.34 for ; Wed, 31 Aug 2011 11:46:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110831175934.GA17959@zapo> References: <4E5D9570.1030201@codemonkey.ws> <4E5E3789.3010603@codemonkey.ws> <4E5E39DF.3080609@codemonkey.ws> <4E5E4540.5030408@codemonkey.ws> <4E5E5BF3.50801@codemonkey.ws> <20110831175934.GA17959@zapo> From: Blue Swirl Date: Wed, 31 Aug 2011 18:46:37 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: qemu-devel@nongnu.org, bifferos On Wed, Aug 31, 2011 at 5:59 PM, Edgar E. Iglesias wrote: > On Wed, Aug 31, 2011 at 11:06:11AM -0500, Anthony Liguori wrote: >> On 08/31/2011 09:35 AM, malc wrote: >> >On Wed, 31 Aug 2011, Anthony Liguori wrote: >> > >> >>Upper case field names are not okay. =C2=A0If you think coding style i= sn't clear, >> >>that's a bug in coding style. >> > >> >Sez hu? Coding style is garbage that should be thrown out of the window= . >> >As for looking, yeah, i'm looking at usb with it's lovely hungarian >> >fields, should we stampede to "fix" it? >> > >> >If the one who's going to maintain the code is fine with whatever namin= g >> >is used so be it. >> >> No. =C2=A0That's how we got into the coding style mess we're in in the >> first place. > > TBH, the codingstyle in QEMU is the least of "problems" we are facing. > We've got lack of documentation, lack of tests, lack of contributors, > etc, etc. IMO, those bring codingstyle issues into the pretty much > neglectable space. The issues you mention are real, but problems in those areas do not make the case for consistency invalid. We could also make rules for documentation. For example, must use doxygen decorations for APIs, must add a file under docs/apis/ when adding an API, must convert old APIs when adding new ones etc. Another way would be to downscale the project to match the resources, we should throw away code which is not maintained and then focus on the good parts. > I think we should throw out everything from CS beyond the details of > spaces and braces. Maybe keep the 80 char limit. I disagree, those rules try to make the code consistent. I don't care much what is the standard (could be Linux kernel style for example), but maintaining the style improves readability and maintainability of the code. > We should ofcourse refer to the C and other specs regarding correctness, > like the _t thing, but those are not really stylistic issues. Those are > bugs. > > my 5 cents > > Cheers > >