From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1SzZ99-0007Yq-Rb
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:15:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1SzZ98-0000h0-Q8
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:15:55 -0400
Received: from mail-gh0-f173.google.com ([209.85.160.173]:46951)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1SzZ98-0000gu-Ll
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:15:54 -0400
Received: by ghrr17 with SMTP id r17so866937ghr.4
	for <qemu-devel@nongnu.org>; Thu, 09 Aug 2012 13:15:54 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA8R86yqCADHSJBkyeLRz4EkRz2TtYhgK60k67=ZhTrCLg@mail.gmail.com>
References: <1342620628-12751-1-git-send-email-peter.maydell@linaro.org>
	<1342620628-12751-12-git-send-email-peter.maydell@linaro.org>
	<CAAu8pHsA5A0wmUMMQFJzRvoBU85TFS9nJx6ibWL+MQWDGgCkqw@mail.gmail.com>
	<CAFEAcA-zs=r4+c-ruih0Xf9v6vQcJVv8XNfh0BQDVhqoXw+w3w@mail.gmail.com>
	<CAAu8pHu0crC1ZFm=fbYX3gmaavFFZ+sTSCQKTb7j5S+KWJh3zQ@mail.gmail.com>
	<CAFEAcA9MWKvTcq6eYEBeqn2Wv7z8SaKZr4rpw5m0_3B07G-AQg@mail.gmail.com>
	<CAAu8pHusDDU8BsiJCdB+aytnL-cn6er3WLHCgpLS1K4SJsG02A@mail.gmail.com>
	<CAFEAcA-UY=Ekq0=RqmNm7z4NVK5_Mnq-F+pBygcmZPF4WGR7Pw@mail.gmail.com>
	<CAAu8pHu1gRD3MLP1wfHDmwjQJxHAacUqo_DtaKrMnC5iKO7+Fg@mail.gmail.com>
	<CAFEAcA8R86yqCADHSJBkyeLRz4EkRz2TtYhgK60k67=ZhTrCLg@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Thu, 9 Aug 2012 20:15:33 +0000
Message-ID: <CAAu8pHv+mLVH8Wc_=p+M7XV5H_O0jKyLtBYjLCUuQGcoZ-qsJQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing
 failures when compiling tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, patches@linaro.org

On Thu, Aug 9, 2012 at 6:24 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 4 August 2012 18:57, Blue Swirl <blauwirbel@gmail.com> wrote:
>> On Sat, Jul 28, 2012 at 1:48 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>>> On 28 July 2012 13:31, Blue Swirl <blauwirbel@gmail.com> wrote:
>>>> I'm getting this error, probably because now Valgrind support is enabled:
>>>>   CC    coroutine-ucontext.o
>>>> cc1: warnings being treated as errors
>>>> /src/qemu/coroutine-ucontext.c:204: error: unknown option after
>>>> '#pragma GCC diagnostic' kind
>>>> /src/qemu/coroutine-ucontext.c:209: error: unknown option after
>>>> '#pragma GCC diagnostic' kind
>>>>
>>>> Maybe the compiler does not understand this pragma and Valgrind check
>>>> should also fail in that case.
>>>
>>> Yeah, I think this is one of the few tests which want to explicitly
>>> check "is this construct going to provoke a compiler warning" --
>>> fix is for that test to explictly put -Werror in the cflags in
>>> the compile_prog line.
>>
>> Now with your Xen configure patches in place, I'm not getting errors
>> with this applied except for Clang (which I didn't test earlier).
>> Maybe this should be applied.
>
> Yes, I think that (assuming we are going to go down this route at all)
> it would be good to apply this 11/11 patch now in good time before
> the freeze. Does anybody want to object?

I'll send a patch that fixes configure with Clang.

>
> thanks
> -- PMM