From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C83C4727E for ; Thu, 1 Oct 2020 19:46:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAB6820848 for ; Thu, 1 Oct 2020 19:46:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="L8wFd+Hl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732888AbgJATp7 (ORCPT ); Thu, 1 Oct 2020 15:45:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729990AbgJATp7 (ORCPT ); Thu, 1 Oct 2020 15:45:59 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD58DC0613D0 for ; Thu, 1 Oct 2020 12:45:58 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id v23so5686115ljd.1 for ; Thu, 01 Oct 2020 12:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c2gfbOiiR0so3N0eX6gQPc6WKY7PeKJeRfa9G0R50hA=; b=L8wFd+HleRUy2It+KmWJB1fwyoQVZjtyVGCA52KJRhRXbSNUGkkwN3/7mIaxQepJR7 iuog+JhLqKQBpndNTN35oHdPDn2rnXahO3Xx7vmOsxZXqDUs1JrtwY5UwiWm423plAQj lo4HD9GZCPKZ25/bwDhXwjYcudcL/Zg3xzqRhLqf4r9rXjw1u5njkPwGOnFinErUgbBz YCDMiwdlkMrqWJj2GxZ5QqLrv8qMsrR+Iqj0LfK5k4TPlCzy3PughEAPTlwiNRXlpGVR XFx8eCdsk0HIUFNeGUhrVgk3rWB5BrHFd9Ow8NqbjOPmaYbuAs3sCg2YWbchqAuzJNzK 2vUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c2gfbOiiR0so3N0eX6gQPc6WKY7PeKJeRfa9G0R50hA=; b=OY6v7wefa4eYo7/PdK2HSolMDXbIe6OiR0u/rzK/Lwsx1F5IIK2Mis6b7ZUsKPY58O 1n9p76FATzuEwf7jWdRs/0qalvBDKsL5t8J/0vvyjTE9ufO/VF8EbFzUvJvWtk4wrYKb Ac4PiIb4Ii1acyY7VZI02vWPW7ZNX+0+EaSPcnTmhgQ4tvRAoQNNZxfDvMs9xQA7dpxz YjI0wrJPlkyc6auhBcU4Ww+3/uIcxuBgei5QaSzUDJtyajn2IjbHtrjNGMH1oQGEtsVY IDqQuqpoTnT8m/+Em1cOJBMLf5tx83WsDTI1VK8trsj+eUUG/67PEyBD9K0bB/JJ4un0 udQw== X-Gm-Message-State: AOAM530yJMvj3ECECL2KJtubpY1v9jGCjiGq8j6AZZO68LFAn3yp4yTo J3aMrmqwXXBXxVk0OZd/fOT80heKGsIvoqGZUT3Apw== X-Google-Smtp-Source: ABdhPJzhr62N6D/DY0NMD6Re7tm+lJuTbYgAQTgrVa6ZpBk/+rg4S7xE0mJMNKGk9FcSYDYEXfBWz/WFBYcaS/gYx8o= X-Received: by 2002:a2e:804f:: with SMTP id p15mr2979567ljg.199.1601581557161; Thu, 01 Oct 2020 12:45:57 -0700 (PDT) MIME-Version: 1.0 References: <20200929221526.GA1370981@ubuntu-m3-large-x86> <20200930140758.gummt3umouva3wyu@gilmour.lan> <20200930163823.GA237050@ubuntu-m3-large-x86> <20201001064843.dlewcu3b7dvqanyy@gilmour.lan> <20201001085402.t6mzzwzplviunhoc@gilmour.lan> <8bc3f2b0d1b5ae59996bc9316a401a68c92ebac7.camel@suse.de> In-Reply-To: <8bc3f2b0d1b5ae59996bc9316a401a68c92ebac7.camel@suse.de> From: Tim Gover Date: Thu, 1 Oct 2020 20:45:45 +0100 Message-ID: Subject: Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline To: Nicolas Saenz Julienne Cc: Maxime Ripard , Stefan Wahren , Nathan Chancellor , Eric Anholt , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hoegeun Kwon , Chanwoo Choi , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry, my previous statement was misleading. enable_uart will select the mini_uart for gpio14,15 unless the disable-bt device tree overlay is loaded. As well as disabling bluetooth disable-bt swaps the uart0 pin configs to point the regular UART to gpio 14,15. After resolving the DT overlays the firmware does the initial UART setup according to which controller is pointed at pins 14,15. I'll have to speak to others about exactly when the fixing of the core clock takes effect. There have been a few changes related to the initial turbo frequency configuration and how this is reported via the mbox APIs On Thu, 1 Oct 2020 at 17:47, Nicolas Saenz Julienne wrote: > > Hi Tim, thanks for the info! > > On Thu, 2020-10-01 at 11:15 +0100, Tim Gover wrote: > > hdmi_enable_4k60=1 causes the firmware to select 3.3 GHz for the PLLC > > VCO to support a core-frequency of 550 MHz which is the minimum > > frequency required by the HVS at 4Kp60. The side effect is that if the > > display clock requirements are lower than 4Kp60 then you will see > > different core frequencies selected by DVFS. > > > > If enable_uart=1 and the mini-uart is selected (default unless > > What is the actual test made to check if mini-uart is selected? I can't get > firmware to trigger this behaviour with 64-bit upstream kernel/dts. Note that I > see the core clk setup at 200MHz just before having VC4 set it to 500MHz. > > The only thing I've got on my config.txt is: > > enable_uart=1 > arm_64bit=1 > > Maybe we're missing some kind of DT alias upstream? > > Regards, > Nicolas > > > bluetooth is disabled) then the firmware will pin the core-frequency > > to either core_freq max (500 or 550). Although, I think there is a way > > of pinning it to a lower fixed frequency. > > > > The table in overclocking.md defines options for setting the maximum > > core frequency but unless core_freq_min is specified DVFS will > > automatically pick the lowest idle frequency required by the display > > resolution. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C726FC4727E for ; Thu, 1 Oct 2020 19:47:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 675B420780 for ; Thu, 1 Oct 2020 19:47:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m1V4LaCK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="L8wFd+Hl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 675B420780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KO19GvIlwuGCeR0c/PqhNOzInzEohZazO62xz7xCNsk=; b=m1V4LaCK+uz/DqOZpNICKcOXO 53XwLHHTFmY6GUubsjY8VDfuUmwvbA8iCwUsJHIRcKem3BsdUDf9z7iM3Z4SnvhYWN8i9jRxqp5aM 72XZBfRWzrcOL6plgk/AmQDWEoI1cDriOYrIuKsDyUNo5+wrRHF7qQOW0BqtJPdDNEsJnrOXhWtWd wMszODLk6Pk/MB7ijIszum9WGSYFXztaM1nULIc7AkjWxXvXck/RLFutApDRpCMAJ7SjOaysH+1xA zcrd2bL5h+0oKGgG0AT/S+VGfkclUfi6OkzPaHyILx5zof0F7hGTMV6DI9yd5INkGiu8+2H0rbnwx 6LjNm+p9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO4Wj-0004yX-Sm; Thu, 01 Oct 2020 19:46:05 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO4Wc-0004wV-QL for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 19:46:03 +0000 Received: by mail-lj1-x244.google.com with SMTP id a15so5686092ljk.2 for ; Thu, 01 Oct 2020 12:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c2gfbOiiR0so3N0eX6gQPc6WKY7PeKJeRfa9G0R50hA=; b=L8wFd+HleRUy2It+KmWJB1fwyoQVZjtyVGCA52KJRhRXbSNUGkkwN3/7mIaxQepJR7 iuog+JhLqKQBpndNTN35oHdPDn2rnXahO3Xx7vmOsxZXqDUs1JrtwY5UwiWm423plAQj lo4HD9GZCPKZ25/bwDhXwjYcudcL/Zg3xzqRhLqf4r9rXjw1u5njkPwGOnFinErUgbBz YCDMiwdlkMrqWJj2GxZ5QqLrv8qMsrR+Iqj0LfK5k4TPlCzy3PughEAPTlwiNRXlpGVR XFx8eCdsk0HIUFNeGUhrVgk3rWB5BrHFd9Ow8NqbjOPmaYbuAs3sCg2YWbchqAuzJNzK 2vUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c2gfbOiiR0so3N0eX6gQPc6WKY7PeKJeRfa9G0R50hA=; b=aaO/jBWjM2yf+JyekmmATHusIWXpM3qoOeQ2GmPV7ssVkuectnIXkCMZWMcfMh/xWo tUGUYA9EkEg8OWlzmh/62dHR4impiYXWIq7oDe6NUOste10+OJPnLHJCUw40Dpu3KIcV 8mlhZAyUwTGk1G9x8YZVUUZO2e9LTmN92fhXMY7XYUguCCTTE1a2chkq81IFLHdT9Qt9 QzuqYPAgrVfjSbMCvzo+GiV1wSFtRis+yRZEhhbyHBM2+BwuVd6gEet6tqYHl1fqMWWu tIi5aajyVKrKhdYDfSrVm5uAl+B8WM+bOasF1dPTkOCPQnysxvXOy/F9ma3zz8DvDJKw 3SPw== X-Gm-Message-State: AOAM5327ICAbmfXJL0RviJIMiuIDUvYyElhCDg+hwOZJ/tXqu3d5v+th 35g0WRob3RG1ppaPzhrB0SpjIDcdGyx5nMmj80kj/A== X-Google-Smtp-Source: ABdhPJzhr62N6D/DY0NMD6Re7tm+lJuTbYgAQTgrVa6ZpBk/+rg4S7xE0mJMNKGk9FcSYDYEXfBWz/WFBYcaS/gYx8o= X-Received: by 2002:a2e:804f:: with SMTP id p15mr2979567ljg.199.1601581557161; Thu, 01 Oct 2020 12:45:57 -0700 (PDT) MIME-Version: 1.0 References: <20200929221526.GA1370981@ubuntu-m3-large-x86> <20200930140758.gummt3umouva3wyu@gilmour.lan> <20200930163823.GA237050@ubuntu-m3-large-x86> <20201001064843.dlewcu3b7dvqanyy@gilmour.lan> <20201001085402.t6mzzwzplviunhoc@gilmour.lan> <8bc3f2b0d1b5ae59996bc9316a401a68c92ebac7.camel@suse.de> In-Reply-To: <8bc3f2b0d1b5ae59996bc9316a401a68c92ebac7.camel@suse.de> From: Tim Gover Date: Thu, 1 Oct 2020 20:45:45 +0100 Message-ID: Subject: Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline To: Nicolas Saenz Julienne X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_154558_872574_D90B4FBA X-CRM114-Status: GOOD ( 22.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Chanwoo Choi , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Phil Elwell , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , Nathan Chancellor , Hoegeun Kwon , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sorry, my previous statement was misleading. enable_uart will select the mini_uart for gpio14,15 unless the disable-bt device tree overlay is loaded. As well as disabling bluetooth disable-bt swaps the uart0 pin configs to point the regular UART to gpio 14,15. After resolving the DT overlays the firmware does the initial UART setup according to which controller is pointed at pins 14,15. I'll have to speak to others about exactly when the fixing of the core clock takes effect. There have been a few changes related to the initial turbo frequency configuration and how this is reported via the mbox APIs On Thu, 1 Oct 2020 at 17:47, Nicolas Saenz Julienne wrote: > > Hi Tim, thanks for the info! > > On Thu, 2020-10-01 at 11:15 +0100, Tim Gover wrote: > > hdmi_enable_4k60=1 causes the firmware to select 3.3 GHz for the PLLC > > VCO to support a core-frequency of 550 MHz which is the minimum > > frequency required by the HVS at 4Kp60. The side effect is that if the > > display clock requirements are lower than 4Kp60 then you will see > > different core frequencies selected by DVFS. > > > > If enable_uart=1 and the mini-uart is selected (default unless > > What is the actual test made to check if mini-uart is selected? I can't get > firmware to trigger this behaviour with 64-bit upstream kernel/dts. Note that I > see the core clk setup at 200MHz just before having VC4 set it to 500MHz. > > The only thing I've got on my config.txt is: > > enable_uart=1 > arm_64bit=1 > > Maybe we're missing some kind of DT alias upstream? > > Regards, > Nicolas > > > bluetooth is disabled) then the firmware will pin the core-frequency > > to either core_freq max (500 or 550). Although, I think there is a way > > of pinning it to a lower fixed frequency. > > > > The table in overclocking.md defines options for setting the maximum > > core frequency but unless core_freq_min is specified DVFS will > > automatically pick the lowest idle frequency required by the display > > resolution. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED91C47425 for ; Fri, 2 Oct 2020 07:03:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 762ED20719 for ; Fri, 2 Oct 2020 07:03:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="L8wFd+Hl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 762ED20719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E32886E916; Fri, 2 Oct 2020 07:02:52 +0000 (UTC) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id DFD086E063 for ; Thu, 1 Oct 2020 19:45:58 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id k25so5671746ljg.9 for ; Thu, 01 Oct 2020 12:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c2gfbOiiR0so3N0eX6gQPc6WKY7PeKJeRfa9G0R50hA=; b=L8wFd+HleRUy2It+KmWJB1fwyoQVZjtyVGCA52KJRhRXbSNUGkkwN3/7mIaxQepJR7 iuog+JhLqKQBpndNTN35oHdPDn2rnXahO3Xx7vmOsxZXqDUs1JrtwY5UwiWm423plAQj lo4HD9GZCPKZ25/bwDhXwjYcudcL/Zg3xzqRhLqf4r9rXjw1u5njkPwGOnFinErUgbBz YCDMiwdlkMrqWJj2GxZ5QqLrv8qMsrR+Iqj0LfK5k4TPlCzy3PughEAPTlwiNRXlpGVR XFx8eCdsk0HIUFNeGUhrVgk3rWB5BrHFd9Ow8NqbjOPmaYbuAs3sCg2YWbchqAuzJNzK 2vUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c2gfbOiiR0so3N0eX6gQPc6WKY7PeKJeRfa9G0R50hA=; b=huvcWgbQa+BfdwtXpAW3FUWlwoL8RNgBqUMYbF77X2wmwtl2qD2spxH38ZokiD2nJC 7z8EARO7+xcEdiGzMWe6n41kdtC/8DxRDFtp8Pc85rIPxf5oqT3JSvTW11KtuQ+VbOUY nXv8jh5rHrWJTXnh4+5BLPiriotdvyer0lRc/KFy2cDXMrlDAcO6z87q8IS7EdixqsAh C+rJFJ3FM/8VsHGFaXe5ox5KCDch0dcOv32JbCl8RIN3rRK1Ks1JKiOYH+r6l0n8LOmk PzaCo+NjWZDMVHulYVCj81JKEzS7OUdqGy88KDYInYAtsKiNz1wtX11Bmem4LoF0jcuL cOxA== X-Gm-Message-State: AOAM533I+G+FDYzq4ywTl/eeuiZJypMtfJ8EeHDAGQslvyMpk8zyGIM8 hE3ZcyZJn41CJY5BXiqLfAaxOFTc2yRjxcvTosw+vw== X-Google-Smtp-Source: ABdhPJzhr62N6D/DY0NMD6Re7tm+lJuTbYgAQTgrVa6ZpBk/+rg4S7xE0mJMNKGk9FcSYDYEXfBWz/WFBYcaS/gYx8o= X-Received: by 2002:a2e:804f:: with SMTP id p15mr2979567ljg.199.1601581557161; Thu, 01 Oct 2020 12:45:57 -0700 (PDT) MIME-Version: 1.0 References: <20200929221526.GA1370981@ubuntu-m3-large-x86> <20200930140758.gummt3umouva3wyu@gilmour.lan> <20200930163823.GA237050@ubuntu-m3-large-x86> <20201001064843.dlewcu3b7dvqanyy@gilmour.lan> <20201001085402.t6mzzwzplviunhoc@gilmour.lan> <8bc3f2b0d1b5ae59996bc9316a401a68c92ebac7.camel@suse.de> In-Reply-To: <8bc3f2b0d1b5ae59996bc9316a401a68c92ebac7.camel@suse.de> From: Tim Gover Date: Thu, 1 Oct 2020 20:45:45 +0100 Message-ID: Subject: Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline To: Nicolas Saenz Julienne X-Mailman-Approved-At: Fri, 02 Oct 2020 07:02:50 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Chanwoo Choi , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , Nathan Chancellor , Hoegeun Kwon , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Sorry, my previous statement was misleading. enable_uart will select the mini_uart for gpio14,15 unless the disable-bt device tree overlay is loaded. As well as disabling bluetooth disable-bt swaps the uart0 pin configs to point the regular UART to gpio 14,15. After resolving the DT overlays the firmware does the initial UART setup according to which controller is pointed at pins 14,15. I'll have to speak to others about exactly when the fixing of the core clock takes effect. There have been a few changes related to the initial turbo frequency configuration and how this is reported via the mbox APIs On Thu, 1 Oct 2020 at 17:47, Nicolas Saenz Julienne wrote: > > Hi Tim, thanks for the info! > > On Thu, 2020-10-01 at 11:15 +0100, Tim Gover wrote: > > hdmi_enable_4k60=1 causes the firmware to select 3.3 GHz for the PLLC > > VCO to support a core-frequency of 550 MHz which is the minimum > > frequency required by the HVS at 4Kp60. The side effect is that if the > > display clock requirements are lower than 4Kp60 then you will see > > different core frequencies selected by DVFS. > > > > If enable_uart=1 and the mini-uart is selected (default unless > > What is the actual test made to check if mini-uart is selected? I can't get > firmware to trigger this behaviour with 64-bit upstream kernel/dts. Note that I > see the core clk setup at 200MHz just before having VC4 set it to 500MHz. > > The only thing I've got on my config.txt is: > > enable_uart=1 > arm_64bit=1 > > Maybe we're missing some kind of DT alias upstream? > > Regards, > Nicolas > > > bluetooth is disabled) then the firmware will pin the core-frequency > > to either core_freq max (500 or 550). Although, I think there is a way > > of pinning it to a lower fixed frequency. > > > > The table in overclocking.md defines options for setting the maximum > > core frequency but unless core_freq_min is specified DVFS will > > automatically pick the lowest idle frequency required by the display > > resolution. > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel