From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752452Ab1HVNGh (ORCPT ); Mon, 22 Aug 2011 09:06:37 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:51602 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175Ab1HVNGe convert rfc822-to-8bit (ORCPT ); Mon, 22 Aug 2011 09:06:34 -0400 MIME-Version: 1.0 In-Reply-To: <20110822043107.GB23010@core.coreip.homeip.net> References: <1313812912-2848-1-git-send-email-martinez.javier@gmail.com> <1313812912-2848-2-git-send-email-martinez.javier@gmail.com> <20110822043107.GB23010@core.coreip.homeip.net> From: Javier Martinez Canillas Date: Mon, 22 Aug 2011 09:06:18 -0400 Message-ID: Subject: Re: [PATCH 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support To: Dmitry Torokhov Cc: Kevin McNeely , Henrik Rydberg , Srikar , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 22, 2011 at 12:31 AM, Dmitry Torokhov wrote: > Hi Javier, > Hi Dmitry, Thank you very much for the review. > > Still reading through the patches, but have one question: > > > Why do we need to get gpio/irq from platform data instead of having > board code set up controllers appropriately and use IRQ either from I2C > client structure or from SPI? > > Thanks. > > -- > Dmitry > The original author of this driver is Kevin McNeely (cc'ed in this patch submission). I've only added multi-touch protocol type B support (which was a requirement for upstream acceptance) and resubmit the patch-set. I think he will better answer your questions about the driver design. Kevin? Best regards, -- Javier Martínez Canillas (+34) 682 39 81 69 Barcelona, Spain From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support Date: Mon, 22 Aug 2011 09:06:18 -0400 Message-ID: References: <1313812912-2848-1-git-send-email-martinez.javier@gmail.com> <1313812912-2848-2-git-send-email-martinez.javier@gmail.com> <20110822043107.GB23010@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:51602 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175Ab1HVNGe convert rfc822-to-8bit (ORCPT ); Mon, 22 Aug 2011 09:06:34 -0400 In-Reply-To: <20110822043107.GB23010@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Kevin McNeely , Henrik Rydberg , Srikar , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Aug 22, 2011 at 12:31 AM, Dmitry Torokhov wrote: > Hi Javier, > Hi Dmitry, Thank you very much for the review. > > Still reading through the patches, but have one question: > > > Why do we need to get gpio/irq from platform data instead of having > board code set up controllers appropriately and use IRQ either from I= 2C > client structure or from SPI? > > Thanks. > > -- > Dmitry > The original author of this driver is Kevin McNeely (cc'ed in this patch submission). I've only added multi-touch protocol type B support (which was a requirement for upstream acceptance) and resubmit the patch-set. I think he will better answer your questions about the driver design. Kevin? Best regards, --=20 Javier Mart=C3=ADnez Canillas (+34) 682 39 81 69 Barcelona, Spain -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html