From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755930Ab1INHPJ (ORCPT ); Wed, 14 Sep 2011 03:15:09 -0400 Received: from mail-gy0-f174.google.com ([209.85.160.174]:55370 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755684Ab1INHPF convert rfc822-to-8bit (ORCPT ); Wed, 14 Sep 2011 03:15:05 -0400 MIME-Version: 1.0 In-Reply-To: <20110913082448.GA5046@polaris.bitmath.org> References: <1315029042-27513-1-git-send-email-martinez.javier@gmail.com> <1315029042-27513-2-git-send-email-martinez.javier@gmail.com> <20110913082448.GA5046@polaris.bitmath.org> From: Javier Martinez Canillas Date: Wed, 14 Sep 2011 09:14:50 +0200 Message-ID: Subject: Re: [PATCH V2 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support To: Henrik Rydberg Cc: Kevin McNeely , Dmitry Torokhov , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2011 at 10:24 AM, Henrik Rydberg wrote: > Hi Javier, > >> Cypress TrueTouch(tm) Standard Product controllers are found in >> a wide range of embedded devices. This driver add support for a >> variety of TTSP controllers. >> >> The driver is composed of a core driver that process the data sent by >> the contacts and a set of bus specific interface modules. This patch >> adds the base core TTSP driver. >> >> The original author of the driver is Kevin McNeely >> >> Since the hardware is capable of tracking identifiable contacts and the >> original driver used multi-touch protocol type A (stateless), multi-touch >> protocol type B (stateful) support was added by Javier Martinez Canillas. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> Changes since v1: Fix issues called out by Dmitry Torokhov >>      - Add msleep() delays between retries for read and write operations >>      - Change cyttsp_core_init() to receive the IRQ from the client data >>        instead of obtaining from the platform_data > > Compared to the staging version you sent earlier, this version seems > to be a step back towards the original version regarding the MT > implementation. Is this the right patch? > > Thanks, > Henrik > Hello Henrik, Yes it is the right patch, or at least the patch I meant to send. The staging version I send earlier didn't support multi-touch protocol type A. Since Cypress HW can do finger (contact) tracking, a requirement was to add multi-touch protocol type B support to the driver. This patch-set does that and also fixes some issues that Dmitry had with this patch-set in its V1. Even when Cypress touchscreen can keep track of each contact, it doesn't preserve the contact index. So if I have 3 fingers that were pressed in order and the touchscreen assigned it the values: 10 11 12 And then I lift the first finger (10), the hardware reports: 11 12 Maybe that is why the driver seems complex, you have to keep a copy of the hardware state and iterate over all previous contacts to see if there are new fingers and if the old ones have been lifted. Best regards, -- Javier Martínez Canillas (+34) 682 39 81 69 Barcelona, Spain From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH V2 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support Date: Wed, 14 Sep 2011 09:14:50 +0200 Message-ID: References: <1315029042-27513-1-git-send-email-martinez.javier@gmail.com> <1315029042-27513-2-git-send-email-martinez.javier@gmail.com> <20110913082448.GA5046@polaris.bitmath.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-gy0-f174.google.com ([209.85.160.174]:55370 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755684Ab1INHPF convert rfc822-to-8bit (ORCPT ); Wed, 14 Sep 2011 03:15:05 -0400 In-Reply-To: <20110913082448.GA5046@polaris.bitmath.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Henrik Rydberg Cc: Kevin McNeely , Dmitry Torokhov , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Sep 13, 2011 at 10:24 AM, Henrik Rydberg = wrote: > Hi Javier, > >> Cypress TrueTouch(tm) Standard Product controllers are found in >> a wide range of embedded devices. This driver add support for a >> variety of TTSP controllers. >> >> The driver is composed of a core driver that process the data sent b= y >> the contacts and a set of bus specific interface modules. This patch >> adds the base core TTSP driver. >> >> The original author of the driver is Kevin McNeely >> >> Since the hardware is capable of tracking identifiable contacts and = the >> original driver used multi-touch protocol type A (stateless), multi-= touch >> protocol type B (stateful) support was added by Javier Martinez Cani= llas. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> Changes since v1: Fix issues called out by Dmitry Torokhov >> =C2=A0 =C2=A0 =C2=A0- Add msleep() delays between retries for read a= nd write operations >> =C2=A0 =C2=A0 =C2=A0- Change cyttsp_core_init() to receive the IRQ f= rom the client data >> =C2=A0 =C2=A0 =C2=A0 =C2=A0instead of obtaining from the platform_da= ta > > Compared to the staging version you sent earlier, this version seems > to be a step back towards the original version regarding the MT > implementation. Is this the right patch? > > Thanks, > Henrik > Hello Henrik, Yes it is the right patch, or at least the patch I meant to send. The staging version I send earlier didn't support multi-touch protocol type A. Since Cypress HW can do finger (contact) tracking, a requirement was to add multi-touch protocol type B support to the driver. This patch-set does that and also fixes some issues that Dmitry had with this patch-set in its V1. Even when Cypress touchscreen can keep track of each contact, it doesn't preserve the contact index. So if I have 3 fingers that were pressed in order and the touchscreen assigned it the values: 10 11 12 And then I lift the first finger (10), the hardware reports: 11 12 Maybe that is why the driver seems complex, you have to keep a copy of the hardware state and iterate over all previous contacts to see if there are new fingers and if the old ones have been lifted. Best regards, --=20 Javier Mart=C3=ADnez Canillas (+34) 682 39 81 69 Barcelona, Spain -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html