From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,HTTPS_HTTP_MISMATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC318C54FD0 for ; Mon, 27 Apr 2020 13:53:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8EAA2064A for ; Mon, 27 Apr 2020 13:53:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G8XER+Eu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8EAA2064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D6126E2D5; Mon, 27 Apr 2020 13:53:45 +0000 (UTC) Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5E0E6E2D5 for ; Mon, 27 Apr 2020 13:53:43 +0000 (UTC) Received: by mail-pj1-x102f.google.com with SMTP id fu13so6876621pjb.5 for ; Mon, 27 Apr 2020 06:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6szZhgyjnmkFBKYFpC3eFpf3XKWlJBfKX0ymXbIlxDc=; b=G8XER+EuAwI97ZZZBkCf7jH7wnFgF67OIvisLnRRyjTVGveq/bQTVFreUDQ6Pe4etJ UcPsFnQayM947mAfuueNTbu/gTRD1cx5J5kghOMNHx0snvT6FOYICati1nXj9ixQQEU/ 6m0PXu3TXBu63u11+LgK0Ob2X2Ev5JAjKb2V66t0AanFPNjCPsC6VEDvsS6vUmzxCKkb hsJtW6HWLwWnghF/nyMb3T+vs/EfEK9S578lOwkPYxmqpYGWX7pNWnXFtW59PUt9KBkx dvn7QLxxTpSFFB2rjFxEgUj2YlteI013Z3uXOwKcq/XZKaA//Dz1mJ5KW7OMfya8BRtG gCkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6szZhgyjnmkFBKYFpC3eFpf3XKWlJBfKX0ymXbIlxDc=; b=oGfNGaAwHbg6W9pDheyNU9Qt927zi1Zm/zO16E7PJCetHgLJPeZrLmSuhMs5wYLmj1 o+ib+jHD/ggPRqsD38ws/UqxGwA7orx0j4T1UUxP3iVPnYFITFNObMBoC8RwrjTrf2cy 3ryqEcZwEFibHPTnLDUZ+rC/mdnbkLspME44gbVGZHHCSsIGOsLReiTQ5RM8bFL/JRhm wsYjTe9SYgwhO4xxVEHTjf9orMWy/Qwi6dM/XSH8GEYtZLOt1orSgeoeyYklPeY7OgCH MrWlX4ZP1QJ1ikY5R6SNLTOouuNIp6ckRWMquwwQHuWocoNQW08quUVjZwLAy0OUjpio eKvg== X-Gm-Message-State: AGi0PuZtyCAjYW91GA+IlSmLPCeDfCP0CidswoFyUzf/wPqRVohDTCnX ahNjnGdmkN31p0E7uWncKoT8In+c8fGUaPPO1dIPm1Ln X-Google-Smtp-Source: APiQypLc7J757Fpj1IX5LbqO/bJOp/TT/fIk8IrVRJ18ht5tC2EjzVQyenruVkbve7uMFCb6/1lNUxtmyht4UDOLbIk= X-Received: by 2002:a17:902:a50d:: with SMTP id s13mr13607507plq.5.1587995622598; Mon, 27 Apr 2020 06:53:42 -0700 (PDT) MIME-Version: 1.0 References: <71c2f3e9-a734-5887-b5ce-7fa8b011d372@gmail.com> <659c4b65-764e-85a8-6ac6-0a9daaa6437e@amd.com> In-Reply-To: From: =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= Date: Mon, 27 Apr 2020 09:53:06 -0400 Message-ID: Subject: Re: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10) To: "Deucher, Alexander" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Koenig, Christian" , amd-gfx mailing list Content-Type: multipart/mixed; boundary="===============1106559039==" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" --===============1106559039== Content-Type: multipart/alternative; boundary="000000000000fd6b6e05a4460ac8" --000000000000fd6b6e05a4460ac8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I've already pushed the patch and marked it for stable. I added a note into the commit message to discard the version bump for stable. The GCR packet is always supported in the ring regardless of firmware. Marek On Mon, Apr 27, 2020 at 9:01 AM Deucher, Alexander < Alexander.Deucher@amd.com> wrote: > [AMD Official Use Only - Internal Distribution Only] > > Please split the patch into two, one to update the emit IB sequence, and > one to bump the minor version. That way we can make sure older kernels g= et > the new sequence. Also do we need an sdma fw version check for the new > packet in the emi IB function? > > Alex > ------------------------------ > *From:* amd-gfx on behalf of > Christian K=C3=B6nig > *Sent:* Sunday, April 26, 2020 4:52 AM > *To:* Marek Ol=C5=A1=C3=A1k > *Cc:* amd-gfx mailing list > *Subject:* Re: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10) > > Thought so, we should try to get this get it committed ASAP. And maybe ad= d > a CC: stable tag as well. > > Patch is Reviewed-by: Christian K=C3=B6nig > . > > Thanks, > Christian. > > Am 26.04.20 um 02:28 schrieb Marek Ol=C5=A1=C3=A1k: > > Not without a mandatory firmware update. The gcr packet support for IBs > was added into the sdma firmware just two weeks ago. > > Marek > > On Sat., Apr. 25, 2020, 11:04 Christian K=C3=B6nig, < > ckoenig.leichtzumerken@gmail.com> wrote: > > Could we do this in userspace as well? > > Am 25.04.20 um 10:52 schrieb Marek Ol=C5=A1=C3=A1k: > > This should fix SDMA hangs on gfx10. > > Marek > > _______________________________________________ > amd-gfx mailing listamd-gfx@lists.freedesktop.orghttps://lists.freedeskto= p.org/mailman/listinfo/amd-gfx > > > > --000000000000fd6b6e05a4460ac8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I've already pushed the patch and marked it for s= table.

I added a note into the commit message to d= iscard the version bump for stable.

The GCR packet= is always supported in the ring regardless of firmware.

=
Marek

On Mon, Apr 27, 2020 at 9:01 AM Deucher, Alexande= r <Alexander.Deucher@amd.co= m> wrote:

[AMD Official Use Only - Internal Distribution Only]


Please split the patch into two, one to update the emit IB sequence, and on= e to bump the minor version.=C2=A0 That way we can make sure older kernels = get the new sequence.=C2=A0 Also do we need an sdma fw version check for th= e new packet in the emi IB function?

Alex
Fro= m: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf = of Christian K=C3=B6nig <christian.koenig@amd.com>
Sent: Sunday, April 26, 2020 4:52 AM
To: Marek Ol=C5=A1=C3=A1k <maraeo@gmail.com>
Cc: amd-gfx mailing list <amd-gfx@lists.freedesktop.org>
Subject: Re: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10)
=C2=A0
Thought so, we should try to get this get it committed ASAP. And maybe= add a CC: stable tag as well.

Patch is Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>.

Thanks,
Christian.

Am 26.04.20 um 02:28 schrieb Marek Ol=C5=A1=C3=A1k:
Not without a mandatory firmware update. The gcr packet s= upport for IBs was added into the sdma firmware just two weeks ago.

Marek

On Sat., Apr. 25, 2020, 11:04 Christian K=C3=B6nig, <ckoenig= .leichtzumerken@gmail.com> wrote:
Could we do this in userspace as well?

Am 25.04.20 um 10:52 schrieb Marek Ol=C5=A1=C3=A1k:
This should fix SDMA hangs on gfx10.

Marek

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-g=
fx


--000000000000fd6b6e05a4460ac8-- --===============1106559039== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx --===============1106559039==--