From: Tom St Denis <tstdenis82-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Deucher,
Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>,
Andres Rodriguez
<andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"StDenis, Tom" <Tom.StDenis-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet"
Date: Tue, 04 Apr 2017 19:59:28 +0000 [thread overview]
Message-ID: <CAAzXoR+TJHk1Eo_h0HJGg-KGfON-uLWE7e27Q-95PXyBY3zcOw@mail.gmail.com> (raw)
In-Reply-To: <BN6PR12MB1652D90B12B8A60F1F725AC0F70B0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 3721 bytes --]
I'm using the latest from all open (our internal FC24 repo). I'll fetch
the exact later with "umr -c".
Tom
On Tue, Apr 4, 2017 at 3:48 PM Deucher, Alexander <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>
wrote:
> > -----Original Message-----
> > From: amd-gfx [mailto:amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org] On Behalf
> > Of Andres Rodriguez
> > Sent: Tuesday, April 04, 2017 3:39 PM
> > To: StDenis, Tom; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> > Subject: Re: [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet"
> >
> >
> >
> > On 2017-04-04 08:27 AM, Tom St Denis wrote:
> > > On 03/04/17 04:25 PM, Andres Rodriguez wrote:
> > >> Commit e579f56 results in a KCQ initialization error for polaris10
> > >> cards. Providing the full SET_RESOURCES packet instead of the
> truncated
> > >> version fixes the problem.
> > >>
> > >> I think this patch may have been one of the stabs at fixing the KCQ
> > >> suspend/resume errors. I *think* it may no longer be needed if that is
> > >> the case.
> > >>
> > >> Sending this mostly as an FYI to get the patch removed from the
> 4.12-wip
> > >>
> > >> This reverts commit e579f564c333a7eaddf7e12b1b8414410c36e80f.
> > >> ---
> > >> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++-
> > >> 1 file changed, 5 insertions(+), 1 deletion(-)
> > >>
> > >> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> > >> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> > >> index 2d8d7bb..4c3bf51 100644
> > >> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> > >> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> > >> @@ -4647,10 +4647,14 @@ static int gfx_v8_0_kiq_kcq_enable(struct
> > >> amdgpu_device *adev)
> > >> return r;
> > >> }
> > >> /* set resources */
> > >> - amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES, 2));
> > >> + amdgpu_ring_write(kiq_ring, PACKET3(PACKET3_SET_RESOURCES,
> > 6));
> > >> amdgpu_ring_write(kiq_ring, 0); /* vmid_mask:0 queue_type:0
> > >> (KIQ) */
> > >> amdgpu_ring_write(kiq_ring, 0x000000FF); /* queue mask lo */
> > >> amdgpu_ring_write(kiq_ring, 0); /* queue mask hi */
> > >> + amdgpu_ring_write(kiq_ring, 0); /* gws mask lo */
> > >> + amdgpu_ring_write(kiq_ring, 0); /* gws mask hi */
> > >> + amdgpu_ring_write(kiq_ring, 0); /* oac mask */
> > >> + amdgpu_ring_write(kiq_ring, 0); /* gds heap base:0, gds heap
> > >> size:0 */
> > >> for (i = 0; i < adev->gfx.num_compute_rings; i++) {
> > >> struct amdgpu_ring *ring = &adev->gfx.compute_ring[i];
> > >> uint64_t mqd_addr = amdgpu_bo_gpu_offset(ring->mqd_obj);
> > >>
> > >
> > > This fixes init issues with my polaris board but there's still a clock
> > > problem (CP is pegged at 100% as read by umr) resulting in the GPU
> clock
> > > staying at 1200MHz the entire time.
> > >
> >
> > Yeah I sent this out because I was having KCQ init issues on my
> > polaris10 card. However, I'm not seeing the CP pegged at 100% as you
> > mentioned. Everything sitting quietly at 0% here.
>
> Which firmware are you using?
>
> Alex
>
> >
> >
> > > Tom
> > > _______________________________________________
> > > amd-gfx mailing list
> > > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
[-- Attachment #1.2: Type: text/html, Size: 7241 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-04-04 19:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 20:25 [RFC] Revert "drm/amdgpu/gfx8: Fix SET_RESOURCES packet" Andres Rodriguez
[not found] ` <20170403202534.3311-1-andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-04 12:27 ` Tom St Denis
[not found] ` <3ae98951-f12f-3860-e10a-00e0be2b9e84-5C7GfCeVMHo@public.gmane.org>
2017-04-04 19:39 ` Andres Rodriguez
[not found] ` <d4fbb81c-be3a-c54a-6d56-17dc4ae27895-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-04 19:46 ` Deucher, Alexander
[not found] ` <BN6PR12MB1652D90B12B8A60F1F725AC0F70B0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-04-04 19:59 ` Tom St Denis [this message]
[not found] ` <CAAzXoR+TJHk1Eo_h0HJGg-KGfON-uLWE7e27Q-95PXyBY3zcOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-04 20:01 ` Andres Rodriguez
[not found] ` <32c1f7e8-54a4-8db7-c764-8bae55bf3f94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-04 20:03 ` Deucher, Alexander
[not found] ` <BN6PR12MB1652C9E0D15D794E02FAB2ADF70B0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-04-04 20:17 ` Andres Rodriguez
[not found] ` <CAFQ_0eH8wU1NOfj5TXR+SKWAbFcRqqS4mK-xEFWuSG82V-zozg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-05 11:30 ` Tom St Denis
[not found] ` <08b6ee6a-f201-272c-d812-7f7404a51863-5C7GfCeVMHo@public.gmane.org>
2017-04-05 13:06 ` Alex Deucher
[not found] ` <CADnq5_O7KZy08QQ2P0mqGMkOdFtFYRh5jrJx_Gfm5Ahxvse8Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-05 13:14 ` Tom St Denis
[not found] ` <682c9bb0-19d6-f64a-84d1-73dd77824aa4-5C7GfCeVMHo@public.gmane.org>
2017-04-05 13:56 ` Deucher, Alexander
[not found] ` <BN6PR12MB1652D439580DE76681B0EFA7F70A0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-04-05 15:34 ` Andres Rodriguez
[not found] ` <CAFQ_0eHiU=HNCpPA=2+Op0944anFsb1w-=Q3923LXPY02Pia3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-05 16:49 ` Tom St Denis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAzXoR+TJHk1Eo_h0HJGg-KGfON-uLWE7e27Q-95PXyBY3zcOw@mail.gmail.com \
--to=tstdenis82-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Alexander.Deucher-5C7GfCeVMHo@public.gmane.org \
--cc=Tom.StDenis-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.