All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-omap@vger.kernel.org, Nishanth Menon <nm@ti.com>
Subject: Re: tidspbridge issue with omap_dm_timer_free
Date: Tue, 23 Aug 2011 18:03:50 -0500	[thread overview]
Message-ID: <CAB-zwWjtO1-cU+TYJ=z-s3qFUen62-dDOomdZEh1ou953ebp9A@mail.gmail.com> (raw)
In-Reply-To: <CAMP44s2MpAE09sa-ow0k6qUjUwd-4+z-czzNaO7mv+fu0zipeA@mail.gmail.com>

Hi,

On Sun, Aug 14, 2011 at 2:44 AM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> Yeah, but with the current approach it would be possible that
> everything works fine, and then the DSP goes to hibernation, a module
> is loaded that uses one dm timer, and then when the DSP wakes up, that
> timer would fail, there isn't even a check for that. If I follow the
> code correctly, when the DSP goes back to hibernation, there would be
> a crash, as a NULL timer would be freed. I think that's too error
> prone.

Yes, this scenario could trigger such error condition. So, FWIW, I'm
fine with just a check or your approach. If possible to apply the same
mechanism for the other clocks, so in the enable/disable functions all
the clocks are then enabled/disabled avoiding mixed behavior of
enable/request, disable/free between gpt and mcbsp clocks.

Regards,

Omar

  reply	other threads:[~2011-08-23 23:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 18:42 tidspbridge issue with omap_dm_timer_free Felipe Contreras
2011-08-10 23:27 ` Felipe Contreras
2011-08-13 17:20   ` Ramirez Luna, Omar
2011-08-14  7:44     ` Felipe Contreras
2011-08-23 23:03       ` Ramirez Luna, Omar [this message]
2011-08-13 17:12 ` Ramirez Luna, Omar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB-zwWjtO1-cU+TYJ=z-s3qFUen62-dDOomdZEh1ou953ebp9A@mail.gmail.com' \
    --to=omar.ramirez@ti.com \
    --cc=felipe.contreras@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.