From: "François Perrad" <francois.perrad@gadz.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lua: refactor with a common template lua.pc.in
Date: Mon, 21 Aug 2017 18:42:37 +0200 [thread overview]
Message-ID: <CAB0FRsv2PZrHTtcV7ekSfE-RQrfVpKuv4j0XVB5jDQqh55f10A@mail.gmail.com> (raw)
In-Reply-To: <20170820141553.0d626cd1@windsurf>
2017-08-20 14:15 GMT+02:00 Thomas Petazzoni <
thomas.petazzoni@free-electrons.com>:
> Hello,
>
> On Sun, 20 Aug 2017 10:38:56 +0200, Francois Perrad wrote:
>
> > +define LUA_CONFIGURE_CMDS
> > + sed -e "s/@VERSION@/$(LUA_VERSION)/;s/@ABI@/$(LUAINTERPRETER_
> ABIVER)/;s/@MYLIBS@/$(LUA_MYLIBS)/" \
> > + package/lua/lua.pc.in > $(@D)/lua.pc
> > +endef
> > +
> > +define HOST_LUA_CONFIGURE_CMDS
> > + sed -e "s/@VERSION@/$(LUA_VERSION)/;s/@ABI@/$(LUAINTERPRETER_
> ABIVER)/;s/@MYLIBS@/$(HOST_LUA_MYLIBS)/" \
> > + package/lua/lua.pc.in > $(@D)/lua.pc
> > +endef
>
> I still disagree, and still believe that it should be done as part of
> the <pkg>_BUILD_CMDS step.
>
> Also, could you clarify if you intend this patch to be merged in the
> master branch or in the next branch.
>
It is not a fix, just an improvement of the recent Jorg Krause's work
which was never released.
That saids master branch could be prefered.
Fran?ois.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170821/3aa68926/attachment.html>
prev parent reply other threads:[~2017-08-21 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-20 8:38 [Buildroot] [PATCH] lua: refactor with a common template lua.pc.in Francois Perrad
2017-08-20 12:15 ` Thomas Petazzoni
2017-08-21 16:42 ` François Perrad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB0FRsv2PZrHTtcV7ekSfE-RQrfVpKuv4j0XVB5jDQqh55f10A@mail.gmail.com \
--to=francois.perrad@gadz.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.