From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Fran=C3=A7ois_Perrad?= Date: Fri, 5 Oct 2018 21:04:01 +0200 Subject: [Buildroot] [PATCH 1/2] lua: fix dynamic library install In-Reply-To: References: <20180928173519.9731-1-fontaine.fabrice@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Le sam. 29 sept. 2018 ? 09:39, Fran?ois Perrad a ?crit : > > > Le ven. 28 sept. 2018 ? 19:35, Fabrice Fontaine < > fontaine.fabrice at gmail.com> a ?crit : > >> In 0002-shared-libs-for-lua.patch, revision number is used to set >> library name: >> TO_SOLIB = liblua.so.$(R) >> >> However, library is built using PKG_VERSION which is passed only during >> build step: >> $(CC) -o $@.$(PKG_VERSION) -shared -Wl,-soname="$@.$(PKG_VERSION)" $? >> >> As a result, dynamic library is not installed in staging or target paths >> since bump to lua 5.3.5 >> >> So, instead of replacing R by PKG_VERSION and passing this variable in >> all steps, simply update R to 5 >> >> Fixes: >> - >> http://autobuild.buildroot.net/results/28b6672188bb0082ac1467d3b45904880e3634f3 >> >> Signed-off-by: Fabrice Fontaine >> > > Acked-by: Francois Perrad > > This commit is useful in branch 2018.08.x too. Fran?ois --- >> .../lua/5.3.5/0003-fix-revision-number.patch | 31 +++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> create mode 100644 package/lua/5.3.5/0003-fix-revision-number.patch >> >> diff --git a/package/lua/5.3.5/0003-fix-revision-number.patch >> b/package/lua/5.3.5/0003-fix-revision-number.patch >> new file mode 100644 >> index 0000000000..ed2e0460eb >> --- /dev/null >> +++ b/package/lua/5.3.5/0003-fix-revision-number.patch >> @@ -0,0 +1,31 @@ >> +Fix revision number >> + >> +In 0002-shared-libs-for-lua.patch, revision number is used to set >> +library name: >> +TO_SOLIB = liblua.so.$(R) >> + >> +However, library is built using PKG_VERSION which is passed only during >> +build step: >> +$(CC) -o $@.$(PKG_VERSION) -shared -Wl,-soname="$@.$(PKG_VERSION)" $? >> + >> +As a result, dynamic library is not installed in staging or target paths >> +since bump to lua 5.3.5 >> + >> +So, instead of replacing R by PKG_VERSION and passing this variable in >> +all steps, simply update R to 5 >> + >> +Signed-off-by: Fabrice Fontaine >> + >> +Index: b/Makefile >> +=================================================================== >> +--- a/Makefile >> ++++ b/Makefile >> +@@ -47,6 +47,6 @@ >> + >> + # Lua version and release. >> + V= 5.3 >> +-R= $V.4 >> ++R= $V.5 >> + >> + # Targets start here. >> + all: $(PLAT) >> -- >> 2.17.1 >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: