From: "François Perrad" <francois.perrad@gadz.org>
To: buildroot@busybox.net
Subject: [Buildroot] [V2 1/2] dropbear: bump to version 2018.76
Date: Wed, 21 Mar 2018 16:42:21 +0100 [thread overview]
Message-ID: <CAB0FRsvzP073h4OzsfvrgMtn+mskpkB96nJBDsfUgm53dQDzmw@mail.gmail.com> (raw)
In-Reply-To: <20180321053927.zwtbohigenottppb@tarshish>
2018-03-21 6:39 GMT+01:00 Baruch Siach <baruch@tkos.co.il>:
> Hi Francois,
>
> On Tue, Mar 20, 2018 at 08:56:48PM +0100, Francois Perrad wrote:
> > with this new version:
> > - "configure --enable-static" should now be used instead of
> > "make STATIC=1"
> > - any customised options should be put in localoptions.h
> >
> > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
>
> Reviewed-by: Baruch Siach <baruch@tkos.co.il>
>
> One small nit below.
>
> [...]
>
> > define DROPBEAR_ENABLE_REVERSE_DNS
> > - $(SED) 's:.*\(#define DO_HOST_LOOKUP\).*:\1:' $(@D)/options.h
> > + echo '#define DO_HOST_LOOKUP 1' >> $(@D)/localoptions.h
> > endef
> >
> > define DROPBEAR_BUILD_SMALL
> > - $(SED) 's:.*\(#define NO_FAST_EXPTMOD\).*:\1:' $(@D)/options.h
> > + echo '#define DROPBEAR_SMALL_CODE 1' >> $(@D)/localoptions.h
>
> This is the default. Since we already rely on the default in the
> DO_HOST_LOOKUP case above, maybe we can do the same here.
>
>
So, DROPBEAR_BUILD_SMALL could be fully removed.
Fran?ois
> But that's for another patch, anyway.
>
> > endef
> >
> > define DROPBEAR_BUILD_FEATURED
> > - $(SED) 's:^#define DROPBEAR_SMALL_CODE::' $(@D)/options.h
> > - $(SED) 's:.*\(#define DROPBEAR_BLOWFISH\).*:\1:' $(@D)/options.h
> > - $(SED) 's:.*\(#define DROPBEAR_TWOFISH128\).*:\1:' $(@D)/options.h
> > - $(SED) 's:.*\(#define DROPBEAR_TWOFISH256\).*:\1:' $(@D)/options.h
> > + echo '#define DROPBEAR_SMALL_CODE 0' >> $(@D)/localoptions.h
> > + echo '#define DROPBEAR_BLOWFISH 1' >> $(@D)/localoptions.h
> > + echo '#define DROPBEAR_TWOFISH128 1' >> $(@D)/localoptions.h
> > + echo '#define DROPBEAR_TWOFISH256 1' >> $(@D)/localoptions.h
> > endef
> >
> > define DROPBEAR_DISABLE_STANDALONE
> > - $(SED) 's:\(#define NON_INETD_MODE\):/*\1 */:' $(@D)/options.h
> > + echo '#define NON_INETD_MODE 0' >> $(@D)/localoptions.h
> > endef
> >
> > define DROPBEAR_INSTALL_INIT_SYSTEMD
>
> baruch
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open
> Systems
> =}------------------------------------------------ooO--U--
> Ooo------------{=
> - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180321/29b7b343/attachment.html>
prev parent reply other threads:[~2018-03-21 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 19:56 [Buildroot] [V2 1/2] dropbear: bump to version 2018.76 Francois Perrad
2018-03-20 19:56 ` [Buildroot] [V2 2/2] dropbear: unbundle libtomath & libtomcrypt Francois Perrad
2018-03-21 6:53 ` Baruch Siach
2018-03-21 5:39 ` [Buildroot] [V2 1/2] dropbear: bump to version 2018.76 Baruch Siach
2018-03-21 15:42 ` François Perrad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB0FRsvzP073h4OzsfvrgMtn+mskpkB96nJBDsfUgm53dQDzmw@mail.gmail.com \
--to=francois.perrad@gadz.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.