From mboxrd@z Thu Jan 1 00:00:00 1970 From: srishtishar@gmail.com (srishti sharma) Date: Sat, 4 Feb 2017 04:20:53 +0530 Subject: driver todo's In-Reply-To: <20170203223949.GA29934@kroah.com> References: <20170203223949.GA29934@kroah.com> Message-ID: To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org I got this warning for a structure to be defined as constant , I have fixed it by adding const , now this variable is not being used in this file , so I was wondering if I should fix such warnings ? What if this variable is used in some other file and the developer didn't want it to be constant despite it producing a warning ? Maybe I am wrong . On Sat, Feb 4, 2017 at 4:09 AM, Greg KH wrote: > On Sat, Feb 04, 2017 at 03:36:02AM +0530, srishti sharma wrote: >> when driver has checkpatch cleanups in it's todo , does that also >> including fixing warnings , should one try to fix them ? > > Why wouldn't you do so?