Re: [PATCH] voicecall: send CallRemoved for calls when voicecall atom is unregistered

* Re: [PATCH] voicecall: send CallRemoved for calls when voicecall atom is unregistered
  2012-04-18 22:02 [PATCH] voicecall: send CallRemoved for calls when voicecall atom is unregistered Mike Brudevold
@ 2012-04-18 15:52 ` Denis Kenzior
  2012-04-19 20:50   ` Mike
  0 siblings, 1 reply; 5+ messages in thread
From: Denis Kenzior @ 2012-04-18 15:52 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]

Hi Mike,

On 04/18/2012 05:02 PM, Mike Brudevold wrote:
> From: Michael Brudevold <michael.brudevold@logicpd.com>
> 
> The CallRemoved signal was not being sent for existing calls when the voicecall
> atom was unregistered. An example of this is the lack of a CallRemoved signal
> when an HFP AG is disconnected due to SLC timeout while a call is active.
> ---
>  src/voicecall.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/src/voicecall.c b/src/voicecall.c
> index 104b600..263f1ee 100644
> --- a/src/voicecall.c
> +++ b/src/voicecall.c
> @@ -2699,8 +2699,11 @@ static void voicecall_unregister(struct ofono_atom *atom)
>  	if (vc->dial_req)
>  		dial_request_finish(vc);
>  
> -	for (l = vc->call_list; l; l = l->next)
> +	for (l = vc->call_list; l; l = l->next) {
> +		voicecalls_emit_call_removed(vc, l->data);
> +
>  		voicecall_dbus_unregister(vc, l->data);
> +	}
>  

In some respect this is on purpose, the application should listen to the
PropertyChanged on the main Modem object and keep track of Interfaces
property.  e.g. if the VoiceCallManager goes away the application can
pretty much assume that all calls are gone.

I could use some more convincing that this is really needed...

Regards,
-Denis

>  	g_slist_free(vc->call_list);
>  	vc->call_list = NULL;

^ permalink raw reply	[flat|nested] 5+ messages in thread