All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike <puffy.taco@gmail.com>
To: wyrles@ytram.com
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	linux-bluetooth <linux-bluetooth@vger.kernel.org>
Subject: Re: PTS / linkkey issue
Date: Mon, 23 Apr 2012 19:36:49 -0500	[thread overview]
Message-ID: <CAB7rCTjkUwp5ETBmypRFw+qbf+Se4mUxJ3sXnUjj+_jQVTKYfQ@mail.gmail.com> (raw)
In-Reply-To: <05a501cd21a3$083836a0$18a8a3e0$@ytram.com>

Hi Tom,

>> > I don't think it's a good idea to mix the security level
>> > (MITM/no-MITM) requirement with the permanence requirement
>> > (no-bonding/bonding). Those really are and should remain as orthogonal
>> > requirements. Even though OPP is the only profile we know that it's
>> > natural to use no-bonding for there may well be use cases where you
>> > want a secure connection for sensitive data but want to forget about
>> > the security relationship once the connection is gone.
>> >
>> > I also think this is what the core spec intends since you've got the
>> > option of no-bonding with MITM and no-bonding without MITM. Even the
>> > table (5.7, page 1671) that defines the security levels talks nothing
>> > about the permanence of the link key but only about authenticated vs
>> > unauthenticated and MITM vs no MITM. Mixing the no-bonding stuff into
>> > the security level would then also confuse anyone thinking that our
>> > security levels are mappings to how the core spec defines them to be.
>>
>> fair point. Let them get the PTS fixed.
>>
>> However we could add an extra option to the security field that would ma=
ke
>> it depend on the pairing setting. This is all still speculation since we=
 have no
>> idea if it would not break GAP qualification.
>>
>> Regards
>>
>> Marcel
>
>
> Hi All -
>
> Out of curiosity, what is the PIXIT value TSPX_delete_link_key set to?

Not 100% sure since I'm not the one running PTS.  From what I've been
told (and have a trace of), if the value is FALSE, we can hardly even
run the tests because the tests expect the other side to authenticate
against that key, which it won't.  If it is TRUE, we pass most of the
tests.

> From the discussion that has been going on here, I think it should set to=
 FALSE in all of the profiles where you want the bonding to persist.

Ideally, yes, but BlueZ is deleting the link key because of the "No
Bonding" type.  From what the BlueZ developers say, this is the
correct behavior.  Unless that is refuted, it is PTS that must change.

> As you might guess from its name: TSPX_delete_link_key set to TRUE will d=
elete the stored link key at the start of a test case. In other words, dele=
te the bonding. TSPX_delete_link_key set to FALSE will leave the stored lin=
k key in place and use it during the authentication process -- that is, usi=
ng the existing bonding.
>
> There are some issues with selecting the proper security mode and I/O Cap=
abilities. Part of it >>> seems <<< to be related to the security module in=
 our host stack ignoring the security configuration we send down from the t=
est cases. ("Seems" because it feels that way to me but I have no hard evid=
ence.)
>
> For the issues that have been reported, some combination of TSPX_delete_l=
ink_key is a workaround. Sometimes it works best to set it one way, sometim=
es the other.
>
> At times, setting it to TRUE to trigger a pairing process and then settin=
g it to FALSE works best.
>
> Because of the available workaround, the issues that Mike mentioned earli=
er have not been given a high priority. A general review/repair of the secu=
rity management situation is on my list of projects for later for this year=
. It may get bumped up in priority due to some other work I am doing where =
I need "fine granularity" control over the security configuration.
>
>
> So, in summary, play with TSPX_delete_link_key and see if that helps. I k=
now that it's not a satisfying solution, I >>> personally <<< don't like it=
 either. But, a workaround is a workaround until something better comes alo=
ng :-).

We have, only partially helps.  I'll know tomorrow if the CreateDevice
workaround is effective.  It may be.  If not, the only real solution
to passing TP/OOR/BV-02-I is for PTS to request "General Bonding".

Thanks,
Mike

  reply	other threads:[~2012-04-24  0:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 22:40 PTS / linkkey issue Mike
2012-04-21  0:28 ` Tom Allebrandi
2012-04-21  0:45   ` Mike
2012-04-21  1:57     ` Mike
2012-04-21 10:35 ` Marcel Holtmann
2012-04-21 17:06   ` Mike
2012-04-21 19:09     ` Marcel Holtmann
2012-04-21 20:17       ` Mike
2012-04-21 21:13         ` Marcel Holtmann
2012-04-22 17:42           ` Mike
2012-04-22 20:08             ` Marcel Holtmann
2012-04-22 20:33               ` Mike
2012-04-22 21:35                 ` Marcel Holtmann
2012-04-22 22:22                   ` Johan Hedberg
2012-04-23  7:02                     ` Marcel Holtmann
2012-04-23  8:24                       ` Luiz Augusto von Dentz
2012-04-23  9:14                       ` Johan Hedberg
2012-04-23  9:40                         ` Marcel Holtmann
2012-04-23 22:46                           ` Tom Allebrandi
2012-04-24  0:36                             ` Mike [this message]
2012-04-26 17:31                               ` Mike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAB7rCTjkUwp5ETBmypRFw+qbf+Se4mUxJ3sXnUjj+_jQVTKYfQ@mail.gmail.com \
    --to=puffy.taco@gmail.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=wyrles@ytram.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.