Re: How best to integrate dmClock QoS library into ceph codebase

[sheng qiu <herbert1984106@gmail.com>]

hi Eric,

we are pretty interested in your dmclock integration work with CEPH.
After reading your pull request, i am a little confusing.
May i ask if the setting in config such as
osd_op_queue_mclock_client_op_res functioning in your added dmclock's
queues and their enqueue and dequeue methods?
the below enqueue function insert request into a map<priority,
subqueue>, i guess for mclock_opclass queue, you set high priority for
client op and lower for scrub, recovery, etc.
Within each subqueue of same priority, did you do FIFO?

void enqueue_strict(K cl, unsigned priority, T item) override final {
    high_queue[priority].enqueue(cl, 0, item);
}

I am appreciated if you can provide some comments, especially if i
didn't understand correctly.

Thanks,
Sheng


On Tue, May 16, 2017 at 5:29 AM, J. Eric Ivancich <ivancich@redhat.com> wrote:
> On 05/15/2017 10:46 PM, Ming Lin wrote:
>> Hi Eric,
>>
>> Do you have any integration patches I can have a try?
> Hi Ming,
>
> The dmClock library became part of the master branch in early May.
>
> Also, two implementations of the dmClock QoS are in a pull request
> currently being reviewed:
>
>     https://github.com/ceph/ceph/pull/14997
>
> Eric
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html