From: Xuewen Yan <xuewen.yan94@gmail.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Vincent Donnefort <vincent.donnefort@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Benjamin Segall <bsegall@google.com>,
Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Ryan Y <xuewyan@foxmail.com>
Subject: Re: [PATCH] sched/pelt: Add UTIL_AVG_UNCHANGED flag for last_enqueued_diff
Date: Fri, 7 May 2021 18:26:24 +0800 [thread overview]
Message-ID: <CAB8ipk-6BV_+qQg_9aoRFA34Ys8x8CB+8SJmGvQXGNoWnXocVw@mail.gmail.com> (raw)
In-Reply-To: <CAKfTPtDUEwvLXOVcGztGALrUx0dqi=KtT2vAcxK15yQJswyHfA@mail.gmail.com>
On Fri, May 7, 2021 at 2:53 PM Vincent Guittot
<vincent.guittot@linaro.org> wrote:
>
> On Fri, 7 May 2021 at 03:36, Xuewen Yan <xuewen.yan94@gmail.com> wrote:
> >
> > On Fri, May 7, 2021 at 12:26 AM Vincent Donnefort
> > <vincent.donnefort@arm.com> wrote:
> > >
> > > On Thu, May 06, 2021 at 08:46:08PM +0800, Xuewen Yan wrote:
> > > > Hi
> > > > On Thu, May 6, 2021 at 8:28 PM Vincent Donnefort
> > > > <vincent.donnefort@arm.com> wrote:
> > > > >
> > > > > On Thu, May 06, 2021 at 07:09:36PM +0800, Xuewen Yan wrote:
> > > > > > From: Xuewen Yan <xuewen.yan@unisoc.com>
> > > > > >
> > > > > > The UTIL_AVG_UNCHANGED flag had been cleared when the task util changed.
> > > > > > And the enqueued is equal to task_util with the flag, so it is better
> > > > > > to add the UTIL_AVG_UNCHANGED flag for last_enqueued_diff.
> > >
> > > Could we change the description here a bit? I don't think this is accurately
> > > explaning the issue. Would probably be interesting to mention that by not
> > > setting the flag, which is the LSB, we add +1 to the diff. This is therefore
> > > reducing slightly UTIL_EST_MARGIN.
> >
> > ok, If you agree with this patch, I'll change it in V2.
>
> Although the impact is not significant , it's worth having an accurate
> computation. So the patch makes sense to me. Please submit a v2
Okay, I'll submit a v2 later.
prev parent reply other threads:[~2021-05-07 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 11:09 [PATCH] sched/pelt: Add UTIL_AVG_UNCHANGED flag for last_enqueued_diff Xuewen Yan
2021-05-06 12:28 ` Vincent Donnefort
2021-05-06 12:46 ` Xuewen Yan
2021-05-06 16:26 ` Vincent Donnefort
2021-05-07 1:34 ` Xuewen Yan
2021-05-07 6:53 ` Vincent Guittot
2021-05-07 10:26 ` Xuewen Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB8ipk-6BV_+qQg_9aoRFA34Ys8x8CB+8SJmGvQXGNoWnXocVw@mail.gmail.com \
--to=xuewen.yan94@gmail.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=xuewyan@foxmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.