From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6F6C433F5 for ; Wed, 30 Mar 2022 07:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243899AbiC3HiI (ORCPT ); Wed, 30 Mar 2022 03:38:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243896AbiC3HiE (ORCPT ); Wed, 30 Mar 2022 03:38:04 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0023B55BE0; Wed, 30 Mar 2022 00:36:18 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id e9so13996005ilu.9; Wed, 30 Mar 2022 00:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K4jqbVE230M9wS+1QXIPRjVS4MYSGVkCyAOthMzzuT8=; b=NdX1PJx79ceLi53HWoka1JaM+2R9nUAaulmuuGNGSXDWk/ZLlchEF0lgouHL3SrPUx cXgivj92UK2ugRw0qCpIPkaphY97RGnb3cDtRBFdKtEusG2csEkg/ocbKfiwzf8uLsYh +bkh+5M3oRdQq/gJtJQUGM66Pgv1ZAlPR4H8xJSNmoB1AHqqqEbWMoECXc7OSo9da4+y qlkS5AXnoguqnqNBAG7FzqVjEkM3CRFkpKKW3qRXjSS4B9FzOZLEjZXaEWoqJ2qs7rNL 24WgjHYrMvxs4vMR7mgqhDldrvzsn5Oej6F+eb0octlfFWvbZOJcqNvEgSN7zLKcvUjr ix6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K4jqbVE230M9wS+1QXIPRjVS4MYSGVkCyAOthMzzuT8=; b=Vt0NvpuPJxfD4gQf2IddAi17YifMUEamc0HdWtQV+P3Ywu3k/NYOAYS7xd48xoXv5L krWdEDSZAQQqbe5hTZMDcSv3IhottPRrtQRKu9jQawlBmQ61QS5yr8s7oYkZBaODTuwL CsP6Bn2opFYuukSFzbyzB2f1kK1BTrA7jm8iTfsYp4c69KLIl5vWlr5sZS2YD6r6qz9Q xvhhEIasdTiD97Mnp3Z/+xtBygw6NWA+7HdCyzCl/NUOTS27RSG7yxMyMkuxWFdTRDEy VIX1PfDJBMeJU8UKvSryzrFv+AElDfRyEavksjxQ7vgMZ1m+Q4UY1OMOUvOSER6rzIwB 4IfA== X-Gm-Message-State: AOAM532BwH+ASTVvdshoyM9skIYGK6ao3p1AT6XwseeneFJy+3fkLgBI XXsGNrRz6lfRvMeYdH5iwA/K50IlqEaYO/vW+1O1OiwHgss= X-Google-Smtp-Source: ABdhPJzILfjbvZouqSmF9BbpFgISbz1vhLK8IKxTWZkYOnBLLHk90MwqMsffPeqph/YKwubQzseyj2lyXH0FBB958EQ= X-Received: by 2002:a05:6e02:d88:b0:2c8:713f:dcff with SMTP id i8-20020a056e020d8800b002c8713fdcffmr10307147ilj.289.1648625778394; Wed, 30 Mar 2022 00:36:18 -0700 (PDT) MIME-Version: 1.0 References: <20220327121404.1702631-1-eugene.shalygin@gmail.com> <20220327121404.1702631-3-eugene.shalygin@gmail.com> In-Reply-To: From: Eugene Shalygin Date: Wed, 30 Mar 2022 09:36:06 +0200 Message-ID: Subject: Re: [PATCH 2/4] hwmon: (asus-ec-sensors) implement locking via the ACPI global lock To: Guenter Roeck Cc: darcagn@protonmail.com, Jean Delvare , linux-hwmon@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Wed, 30 Mar 2022 at 01:37, Guenter Roeck wrote: > > On 3/29/22 15:11, Eugene Shalygin wrote: > > On Tue, 29 Mar 2022 at 23:23, Guenter Roeck wrote: > > > >>> +/* Moniker for the ACPI global lock (':' is not allowed in ASL identifiers) */ > >>> +#define ACPI_GLOBAL_LOCK_PSEUDO_PATH ":GLOBAL_LOCK" > >>> + > >> > >> That needs to be documented. > > > > Do you mean a note in the /Documentation/..../...rst or adding details > > here? There is an additional bit of information on this identifier > > below, in the ec_board_info struct declaration. > > > My understanding was that the user would/could request its use via > the module parameter, so it needs to be documented in the rst file. I see now, thank you. > >>> + if (!mutex_path || !strlen(mutex_path)) { > >> > >> When would mutex_path be NULL ? > > When it is set to NULL in the board definition struct ec_board_info. > > > > Are there any such board definitions ? I don't recall seeing any. You are right, there are no such definitions neither in this submission nor before. I'm messaging with a user who showed a hint that such boards might exist [1]. We have not confirmed it yet, but I thought this little test is obvious enough to be put in the code already. Best regards, Eugene [1] https://github.com/zeule/asus-ec-sensors/issues/19