All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugene Shalygin <eugene.shalygin@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Denis Pauk <pauk.denis@gmail.com>,
	andy.shevchenko@gmail.com, platform-driver-x86@vger.kernel.org,
	Tor Vic <torvic9@mailbox.org>, kernel test robot <lkp@intel.com>,
	Jean Delvare <jdelvare@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI.
Date: Thu, 14 Oct 2021 16:36:54 +0200	[thread overview]
Message-ID: <CAB95QAT44kyBR19cu6sP0kFJwFtVnmULqMzTQPArL94x2oxGkQ@mail.gmail.com> (raw)
In-Reply-To: <e1a141d4-20e7-62c4-fae3-11166b8d0a66@roeck-us.net>

> The compiler aligns the data nicely anyway (it will just leave
> a 1-byte hole where needed), so the packing is really irrelevant.
> Apart of that, does the above suggest that some information/
> code is now missing from the driver ?

It is perhaps an unnecessary removal which will need to be undone
anyway when I (or others) add the south bridge voltage sensor.
Everything is OK with that change now, but since the size of the
address struct or union is 32 bits anyway, I would not remove that
field.

Eugene

  reply	other threads:[~2021-10-14 14:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14  7:25 [PATCH v6 0/2] Update ASUS WMI supported boards Denis Pauk
2021-10-14  7:25 ` [PATCH v6 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI Denis Pauk
2021-10-14 12:08   ` Eugene Shalygin
2021-10-14 14:25     ` Guenter Roeck
2021-10-14 14:36       ` Eugene Shalygin [this message]
2021-10-14 16:45         ` Guenter Roeck
2021-10-14 13:52   ` Oleksandr Natalenko
2021-10-14 14:36   ` Guenter Roeck
2021-10-14 15:10   ` Thomas Weißschuh
2021-10-14  7:25 ` [PATCH v6 2/2] hwmon: (asus_wmi_sensors) Support X370 " Denis Pauk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAB95QAT44kyBR19cu6sP0kFJwFtVnmULqMzTQPArL94x2oxGkQ@mail.gmail.com \
    --to=eugene.shalygin@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=corbet@lwn.net \
    --cc=jdelvare@suse.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lkp@intel.com \
    --cc=pauk.denis@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=torvic9@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.