From: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] cfg80211: allow beaconing after CAC
Date: Tue, 29 Oct 2013 11:45:00 +0100 [thread overview]
Message-ID: <CAB=NE6VBx8rF6MNrmcx=aUfqky-89WE4n9Y6fRy1pV-qq1GoVw@mail.gmail.com> (raw)
In-Reply-To: <CALhHN=oThh7HMW5cHQmW_U0yrzN5x3+ZW6a+yd9fc8fyjcuL+w@mail.gmail.com>
On Tue, Oct 29, 2013 at 11:32 AM, Janusz Dziedzic
<janusz.dziedzic@tieto.com> wrote:
> On 29 October 2013 11:25, Luis R. Rodriguez <mcgrof@do-not-panic.com> wrote:
>> How do we know that prohibited_flags won't have IEEE80211_CHAN_RADAR
>> or IEEE80211_CHAN_NO_IBSS set?
>>
>> Also why is IEEE80211_CHAN_NO_IBSS used and not IEEE80211_CHAN_NO_IR
>> instead? I sent patches to help clarify this situation around usage of
>> both no-ibss and active scan flags, by merging them to no-ir. I'm not
>> sure of the status of those patches going in.
>>
>
> I am not sure.
OK please try to be for changes like these.
> Even without my patch seems IEEE80211_CHAN_RADAR is
> added to prohibited_flags and have different meaning (I think).
IEEE80211_CHAN_RADAR has only one meaning, its not subjective.
> In orginal code we have:
>
> if (c->flags & prohibited_flags & ~IEEE80211_CHAN_RADAR)
>
> So, we skiping CHAN_RADAR anyway? I am not sure we should change
> prohibited_flags to different name or stop skiping CHAN_RADAR and
> modify upper layer - cfg80211_reg_can_beacon() in such case.
I took a look and I'd prefer that this be dealt with elsewhere, in
particular you are right that cfg80211_reg_can_beacon() seems like a
much more suitable place for this check now.
Luis
prev parent reply other threads:[~2013-10-29 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 6:15 [PATCH] cfg80211: allow beaconing after CAC Janusz Dziedzic
2013-10-29 10:25 ` Luis R. Rodriguez
2013-10-29 10:32 ` Janusz Dziedzic
2013-10-29 10:45 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB=NE6VBx8rF6MNrmcx=aUfqky-89WE4n9Y6fRy1pV-qq1GoVw@mail.gmail.com' \
--to=mcgrof@do-not-panic.com \
--cc=janusz.dziedzic@tieto.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.