From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [RFC v2 1/4] bridge: enable interfaces to opt out from becoming the root bridge Date: Thu, 20 Feb 2014 12:01:25 -0800 Message-ID: References: <1392433180-16052-1-git-send-email-mcgrof@do-not-panic.com> <1392433180-16052-2-git-send-email-mcgrof@do-not-panic.com> <20140216105754.63738163@nehalam.linuxnetplumber.net> <1392803559.23084.99.camel@kazak.uk.xensource.com> <5304C13F.3030802@citrix.com> <530600C5.3070107@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WGZob-000535-1s for xen-devel@lists.xenproject.org; Thu, 20 Feb 2014 20:01:49 +0000 Received: by mail-la0-f43.google.com with SMTP id pv20so1665471lab.16 for ; Thu, 20 Feb 2014 12:01:46 -0800 (PST) In-Reply-To: <530600C5.3070107@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Zoltan Kiss Cc: Ian Campbell , kvm@vger.kernel.org, "netdev@vger.kernel.org" , bridge@lists.linux-foundation.org, "linux-kernel@vger.kernel.org" , Stephen Hemminger , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, Feb 20, 2014 at 5:19 AM, Zoltan Kiss wrote: > How about this: netback sets the root_block flag and a random MAC by > default. So the default behaviour won't change, DAD will be happy, and > userspace don't have to do anything unless it's using netback for STP root > bridge (I don't think there are too many toolstacks doing that), in which > case it has to remove the root_block flag instead of setting a random MAC. :D that's exactly what I ended up proposing too. I mentioned how xen-netback could do this as well, we'd keep or rename the flag I added, and then the bridge could would look at it and enable the root block if the flag is set. Stephen however does not like having the bridge code look at magic flags for this behavior and would prefer for us to get the tools to ask for the root block. Let's follow more up on that thread. Luis