From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [PATCH v1 04/12] xen/hvmlite: Bootstrap HVMlite guest Date: Tue, 26 Jan 2016 18:16:25 -0800 Message-ID: References: <1453498558-6028-1-git-send-email-boris.ostrovsky@oracle.com> <1453498558-6028-5-git-send-email-boris.ostrovsky@oracle.com> <20160122233218.GA20964@wotan.suse.de> <56A2C99A.2050701@citrix.com> <56A39300.8050802@citrix.com> <20160125221920.GG20964@wotan.suse.de> <56A6A7C6.8060906@oracle.com> <20160126203023.GI20964@wotan.suse.de> <56A7EA6A.2030502@oracle.com> <20160127000435.GK20964@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aOFf7-0003fM-Im for xen-devel@lists.xenproject.org; Wed, 27 Jan 2016 02:16:49 +0000 Received: by mail-yk0-f196.google.com with SMTP id v14so16074604ykd.1 for ; Tue, 26 Jan 2016 18:16:46 -0800 (PST) In-Reply-To: <20160127000435.GK20964@wotan.suse.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: Juergen Gross , Jeremy Fitzhardinge , Rusty Russell , Andrew Cooper , X86 ML , "linux-kernel@vger.kernel.org" , Andy Lutomirski , David Vrabel , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Borislav Petkov , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= List-Id: xen-devel@lists.xenproject.org On Tue, Jan 26, 2016 at 4:04 PM, Luis R. Rodriguez wrote: > You go: > > hvmlite_start_xen() --> > HVM stub > startup_64() | (startup_32() Hrm, does HVMlite work well with load_ucode_bsp(), note the patches to rebrand pv_enabled() to pv_legacy() or whatever, this PV type will not be legacy or crap / old, so we'd need a way to catch it if we should not use that code for this PV type. This begs the question, are you also sure other callers in startup_32() or startup_64() might be OK as well where previously guarded with pv_enabled() ? Luis