From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759327AbcDIA0P (ORCPT ); Fri, 8 Apr 2016 20:26:15 -0400 Received: from mail.kernel.org ([198.145.29.136]:42796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754358AbcDIA0O convert rfc822-to-8bit (ORCPT ); Fri, 8 Apr 2016 20:26:14 -0400 MIME-Version: 1.0 In-Reply-To: <1459273313-5139-1-git-send-email-mcgrof@kernel.org> References: <20160316171719.GE2195@8bytes.org> <1459273313-5139-1-git-send-email-mcgrof@kernel.org> From: "Luis R. Rodriguez" Date: Fri, 8 Apr 2016 17:25:49 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu To: Joerg Roedel , christian.koenig@amd.com, oded.gabbay@gmail.com Cc: iommu@lists.linux-foundation.org, "linux-kernel@vger.kernel.org" , "Luis R. Rodriguez" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez wrote: > We need to ensure amd iommu v2 initializes before > driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c, > to do this make its init routine a subsys_initcall() which > ensures its load init is called first than modules when > built-in. > > This reverts the old work around implemented through commit > 1bacc894c227fad8a7 ("drivers: Move iommu/ before gpu/ in Makefile"), > instead of making the dependency implicit by linker order this > makes the ordering requirement explicit through proper kernel > APIs. > > Cc: Oded Gabbay > Cc: Christian König > Signed-off-by: Luis R. Rodriguez *poke* Luis From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu Date: Fri, 8 Apr 2016 17:25:49 -0700 Message-ID: References: <20160316171719.GE2195@8bytes.org> <1459273313-5139-1-git-send-email-mcgrof@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1459273313-5139-1-git-send-email-mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel , christian.koenig-5C7GfCeVMHo@public.gmane.org, oded.gabbay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Luis R. Rodriguez" List-Id: iommu@lists.linux-foundation.org T24gVHVlLCBNYXIgMjksIDIwMTYgYXQgMTA6NDEgQU0sIEx1aXMgUi4gUm9kcmlndWV6IDxtY2dy b2ZAa2VybmVsLm9yZz4gd3JvdGU6Cj4gV2UgbmVlZCB0byBlbnN1cmUgYW1kIGlvbW11IHYyIGlu aXRpYWxpemVzIGJlZm9yZQo+IGRyaXZlciB1c2VzIHN1Y2ggYXMgZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRrZmQva2ZkX21vZHVsZS5jLAo+IHRvIGRvIHRoaXMgbWFrZSBpdHMgaW5pdCByb3V0aW5l IGEgc3Vic3lzX2luaXRjYWxsKCkgd2hpY2gKPiBlbnN1cmVzIGl0cyBsb2FkIGluaXQgaXMgY2Fs bGVkIGZpcnN0IHRoYW4gbW9kdWxlcyB3aGVuCj4gYnVpbHQtaW4uCj4KPiBUaGlzIHJldmVydHMg dGhlIG9sZCB3b3JrIGFyb3VuZCBpbXBsZW1lbnRlZCB0aHJvdWdoIGNvbW1pdAo+IDFiYWNjODk0 YzIyN2ZhZDhhNyAoImRyaXZlcnM6IE1vdmUgaW9tbXUvIGJlZm9yZSBncHUvIGluIE1ha2VmaWxl IiksCj4gaW5zdGVhZCBvZiBtYWtpbmcgdGhlIGRlcGVuZGVuY3kgaW1wbGljaXQgYnkgbGlua2Vy IG9yZGVyIHRoaXMKPiBtYWtlcyB0aGUgb3JkZXJpbmcgcmVxdWlyZW1lbnQgZXhwbGljaXQgdGhy b3VnaCBwcm9wZXIga2VybmVsCj4gQVBJcy4KPgo+IENjOiBPZGVkIEdhYmJheSA8b2RlZC5nYWJi YXlAYW1kLmNvbT4KPiBDYzogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQu Y29tPgo+IFNpZ25lZC1vZmYtYnk6IEx1aXMgUi4gUm9kcmlndWV6IDxtY2dyb2ZAa2VybmVsLm9y Zz4KCipwb2tlKgoKIEx1aXMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24u b3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lv bW11