Re: [PATCH v2] ARM: DTS: OMAP4: Add OMAP4 Blaze Tablet support

[Ruslan Bilovol <ruslan.bilovol@ti.com>]

Hi Nishanth,

On Wed, Jun 26, 2013 at 4:13 PM, Nishanth Menon <nm@ti.com> wrote:
> On Wed, Jun 26, 2013 at 3:03 AM, Ruslan Bilovol <ruslan.bilovol@ti.com> wrote:
>> Hi Nishanth,
>>
>> On Tue, Jun 25, 2013 at 3:43 PM, Nishanth Menon <nm@ti.com> wrote:
>>> On 06/25/2013 07:01 AM, Nishanth Menon wrote:
>>>>
>>>> On 06/25/2013 06:32 AM, Ruslan Bilovol wrote:
>>>>>
>>>>> The OMAP4 Blaze Tablet is TI OMAP4 processor-based
>>>>> development platform in a tablet formfactor.
>>>>> The platform contains many of the features found in
>>>>> present-day handsets (such as audio, video, wireless
>>>>> functions and user interfaces) and in addition
>>>>> contains features for software development and test.
>>>>>
>>>>> This patch adds initial support for the OMAP4 Blaze
>>>>> Tablet development platform. Additional functionality
>>>>> depends on different drivers and code modifications that
>>>>> are not upstreamed yet or do not support DT yet, so will
>>>>> be added later.--
>>>>
>>>>
>>>> http://svtronics.com/omap/sevm4460,blaze,omap might help too :)
>>
>> Yes, forgot to add this information from cover-letter from previous
>> version of patch :)
>
> ;) - link was wrong!

I know, but don't worry about it - I will put correct one in v3 :)

> http://svtronics.com/omap?product_id=15 is more like it -> Blaze
> tablet by default comes in 4460/4470 variants. I suggest introducing
> 4470 variant here.
> I am aware of the SOM compatibility and ability to support 4430 SOM on
> tablet as well, but to keep tablet alive and reduce scope of testing,
> keeping just 4470 in place might be a good choice.

Yes, this makes sense. I think as soon as OMAP4470 reach upstream, we can easily
switch the BlazeTablet's  .dts to 4470

>
> just my 2 cents, no strong feelings towards either. :)
>
>>
>>>> [...]
>>>>>
>>>>> +
>>>>> +#include "twl6030.dtsi"
>>>>> +
>>>>
>>>> Might be good to see the TWL interrupt pin information made available as
>>>> well?
>>>
>>> Allow me to rephrase a comment a little bit more :)
>>> Similar to twl4030_omap3.dtsi, we could introduce twl6030_omap4.dtsi. this
>>> could contain the common pins used for 6030.
>>>  &omap4_pmx_wkup {
>>>          pinctrl-names = "default";
>>>          pinctrl-0 = <
>>>                          &twl6030_wkup_pins
>>>          >;
>>>
>>>          twl6030_wkup_pins: pinmux_twl6030_wkup_pins {
>>>                  pinctrl-single,pins = <
>>>                          0x14 (PIN_OUTPUT | MUX_MODE2)
>>>                  >;
>>>          };
>>>  };
>>>
>>>         twl6030_pins: pinmux_twl6030_pins {
>>>                 pinctrl-single,pins = <
>>>                         0x15e (WAKEUP_EN | PIN_INPUT_PULLUP | MUX_MODE0)
>>> /* sys_nirq1.sys_nirq1 */
>>>                 >;
>>>         };
>>>
>>> which is now already duplicated in 2 places (SDP and Panda), and in this
>>> patch duplicated again.
>>
>> Agree, I'm planning to do this later as part of moving common things into
>> some System-On-Module(SOM)-specific files, as discussed previously
>> here https://patchwork.kernel.org/patch/2118371/
>>
> I dont think I was mentioning about that - I just would really like to
> avoid duplication of 6030 information all over the place. if we can
> avoid it, lets start consolidating.

Okay, I got your point. Will prepare the patch in v3..

> Regards,
> Nishanth Menon


-- 
Best regards,
Ruslan Bilvol


> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html