[PATCH BlueZ] gdbus: properly init client connected state

[PATCH BlueZ] gdbus: properly init client connected state

[Matt Schulte]

GDBusClient struct's connected member was being initialize to false for
all new clients even if the connection was connected. This changes the
GDBusClient connected field to be initialized from the state of the dbus
connection
---
 gdbus/client.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdbus/client.c b/gdbus/client.c
index eaab7d50b..a41ce1a7f 100644
--- a/gdbus/client.c
+++ b/gdbus/client.c
@@ -1316,7 +1316,7 @@ GDBusClient *g_dbus_client_new_full(DBusConnection *connection,
 	client->service_name = g_strdup(service);
 	client->base_path = g_strdup(path);
 	client->root_path = g_strdup(root_path);
-	client->connected = FALSE;
+	client->connected = dbus_connection_get_is_connected(connection);
 
 	client->match_rules = g_ptr_array_sized_new(1);
 	g_ptr_array_set_free_func(client->match_rules, g_free);
-- 
2.16.1

Re: [PATCH BlueZ] gdbus: properly init client connected state

[Luiz Augusto von Dentz]

Hi Matt,

On Tue, Feb 6, 2018 at 6:51 AM, Matt Schulte <schultetwin1@gmail.com> wrote:
> GDBusClient struct's connected member was being initialize to false for
> all new clients even if the connection was connected. This changes the
> GDBusClient connected field to be initialized from the state of the dbus
> connection
> ---
>  gdbus/client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdbus/client.c b/gdbus/client.c
> index eaab7d50b..a41ce1a7f 100644
> --- a/gdbus/client.c
> +++ b/gdbus/client.c
> @@ -1316,7 +1316,7 @@ GDBusClient *g_dbus_client_new_full(DBusConnection *connection,
>         client->service_name = g_strdup(service);
>         client->base_path = g_strdup(path);
>         client->root_path = g_strdup(root_path);
> -       client->connected = FALSE;
> +       client->connected = dbus_connection_get_is_connected(connection);

This is actually to track if the client service name is available on
the bus, not the local connection passed as parameter which shall
always be connected, if the service has not been acquired yet it will
wait until it appears.

>         client->match_rules = g_ptr_array_sized_new(1);
>         g_ptr_array_set_free_func(client->match_rules, g_free);
> --
> 2.16.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Luiz Augusto von Dentz