All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 5.13-rc4] Bluetooth: Fix VIRTIO_ID_BT assigned number
@ 2021-06-03 19:20 Marcel Holtmann
  2021-06-03 20:03 ` Luiz Augusto von Dentz
  0 siblings, 1 reply; 2+ messages in thread
From: Marcel Holtmann @ 2021-06-03 19:20 UTC (permalink / raw)
  To: linux-bluetooth

It turned out that the VIRTIO_ID_* are not assigned in the virtio_ids.h
file in the upstream kernel. Picking the next free one was wrong and
there is a process that has been followed now.

See https://github.com/oasis-tcs/virtio-spec/issues/108 for details.

Fixes: afd2daa26c7a ("Bluetooth: Add support for virtio transport driver")
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
 include/uapi/linux/virtio_ids.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h
index f0c35ce8628c..4fe842c3a3a9 100644
--- a/include/uapi/linux/virtio_ids.h
+++ b/include/uapi/linux/virtio_ids.h
@@ -54,7 +54,7 @@
 #define VIRTIO_ID_SOUND			25 /* virtio sound */
 #define VIRTIO_ID_FS			26 /* virtio filesystem */
 #define VIRTIO_ID_PMEM			27 /* virtio pmem */
-#define VIRTIO_ID_BT			28 /* virtio bluetooth */
 #define VIRTIO_ID_MAC80211_HWSIM	29 /* virtio mac80211-hwsim */
+#define VIRTIO_ID_BT			40 /* virtio bluetooth */
 
 #endif /* _LINUX_VIRTIO_IDS_H */
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 5.13-rc4] Bluetooth: Fix VIRTIO_ID_BT assigned number
  2021-06-03 19:20 [PATCH 5.13-rc4] Bluetooth: Fix VIRTIO_ID_BT assigned number Marcel Holtmann
@ 2021-06-03 20:03 ` Luiz Augusto von Dentz
  0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2021-06-03 20:03 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: linux-bluetooth

Hi Marcel,

On Thu, Jun 3, 2021 at 12:22 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> It turned out that the VIRTIO_ID_* are not assigned in the virtio_ids.h
> file in the upstream kernel. Picking the next free one was wrong and
> there is a process that has been followed now.
>
> See https://github.com/oasis-tcs/virtio-spec/issues/108 for details.
>
> Fixes: afd2daa26c7a ("Bluetooth: Add support for virtio transport driver")
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  include/uapi/linux/virtio_ids.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h
> index f0c35ce8628c..4fe842c3a3a9 100644
> --- a/include/uapi/linux/virtio_ids.h
> +++ b/include/uapi/linux/virtio_ids.h
> @@ -54,7 +54,7 @@
>  #define VIRTIO_ID_SOUND                        25 /* virtio sound */
>  #define VIRTIO_ID_FS                   26 /* virtio filesystem */
>  #define VIRTIO_ID_PMEM                 27 /* virtio pmem */
> -#define VIRTIO_ID_BT                   28 /* virtio bluetooth */
>  #define VIRTIO_ID_MAC80211_HWSIM       29 /* virtio mac80211-hwsim */
> +#define VIRTIO_ID_BT                   40 /* virtio bluetooth */
>
>  #endif /* _LINUX_VIRTIO_IDS_H */
> --
> 2.31.1

Applied to bluetooth.git, thanks.

-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-03 20:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 19:20 [PATCH 5.13-rc4] Bluetooth: Fix VIRTIO_ID_BT assigned number Marcel Holtmann
2021-06-03 20:03 ` Luiz Augusto von Dentz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.