Re: [PATCH BlueZ 1/2] a2dp: disallow multiple SetConfiguration to same local SEP

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: patchwork-bot+bluetooth@kernel.org
Cc: Pauli Virtanen <pav@iki.fi>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ 1/2] a2dp: disallow multiple SetConfiguration to same local SEP
Date: Mon, 13 Jun 2022 14:02:29 -0700	[thread overview]
Message-ID: <CABBYNZ+c0uTY0KfW-p48B1VDViKchQNm87B+eM2gLP1k9X+2LA@mail.gmail.com> (raw)
In-Reply-To: <165514381522.24573.3468564396925092282.git-patchwork-notify@kernel.org>

Hi Pauli,

On Mon, Jun 13, 2022 at 12:47 PM <patchwork-bot+bluetooth@kernel.org> wrote:
>
> Hello:
>
> This series was applied to bluetooth/bluez.git (master)
> by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
>
> On Sun,  5 Jun 2022 15:29:26 +0300 you wrote:
> > Using the remote SEP SetConfiguration DBus API, it's possible to make
> > multiple remote endpoints use the same local SEP, if they are endpoints
> > from different connected devices. This is invalid: successful
> > configuration shall prevent a different device configuring the same SEP
> > (AVDTP v1.3 Sec. 5.3).  Moreover, this breaks the assumption in the
> > AVDTP code that each SEP has at most a single stream, and causes
> > misbehavior later on (subsequent transport acquires fail with EPERM).
> >
> > [...]
>
> Here is the summary with links:
>   - [BlueZ,1/2] a2dp: disallow multiple SetConfiguration to same local SEP
>     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5f9d9a9a0b38
>   - [BlueZ,2/2] a2dp: error return paths in a2dp_reconfig must free allocated setup
>     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9c288dd23a3b
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
>

Ive ended applying since I'm not sure you would be working on
supporting reusing the same endpoint properly and leaving the code as
is not working properly.

-- 
Luiz Augusto von Dentz