Re: [V2,2/3] tools/btpclientctl: Add btpclient test application

[Luiz Augusto von Dentz <luiz.dentz@gmail.com>]

Hi Tedd, Marcel,

On Wed, Aug 12, 2020 at 2:27 PM <bluez.test.bot@gmail.com> wrote:
>
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> While we are preparing for reviewing the patches, we found the following
> issue/warning.
>
> Test Result:
> checkpatch Failed
>
> Outputs:
> WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #49: FILE: tools/btpclientctl.c:1:
> +/*

It might be a good idea to start using SPDX license identifiers
though, @Marcel any thoughts on that?

> ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
> #67: FILE: tools/btpclientctl.c:19:
> + *  along with this program; if not, write to the Free Software$
>
> ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
> #68: FILE: tools/btpclientctl.c:20:
> + *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA$
>
> WARNING:TYPO_SPELLING: 'arguement' may be misspelled - perhaps 'argument'?
> #215: FILE: tools/btpclientctl.c:167:
> +       bt_shell_printf("Invalid arguement %s\n", argv[1]);
>
> WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
> #2124: FILE: tools/btpclientctl.c:2076:
> +static const char *help[] = {
>
> - total: 2 errors, 3 warnings, 2175 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> Your patch has style problems, please review.
>
> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
>
> ---
> Regards,
> Linux Bluetooth



-- 
Luiz Augusto von Dentz