From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F33446A2 for ; Fri, 24 Jun 2022 20:00:01 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id t25so6249723lfg.7 for ; Fri, 24 Jun 2022 13:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WvmDAzTeYnupXcG5hwsscAPrC58RhTGzJ0Vo8l3mK6I=; b=ZOq9fW+Rs+ykcVbWeLp0QcFyIdMqwZyrUqdE/sJI5lxFsKo/+C6VcXqKIZxzkOnjAD EpWiRtZtaf6r1Ao0YgJAF38wMTlgUSCJkPE53mOcG14ksbnqNf4hDHE/AYR+tALy0zHq jE8cJQJnRUeOK9BunmDNpY+oAaItYa13rgtZEu3j5xBhp/IEx0uSesHtnFp5MGjQKN3H No8erGGfX+4LISYMLIW8asHv9+bTR5cQdXifJ8TR9AtNqf/u8kPi8DzIhxe2cAMu5iQf cbs53YmoLyRjAPpEBaC0/z4Zy8wW66MntKwOGBHMnzyt9ov+QsiG95rbyzi3QaDfGwd9 FaEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WvmDAzTeYnupXcG5hwsscAPrC58RhTGzJ0Vo8l3mK6I=; b=znBusGo8Bm5GFhyr7Vd/4MqKmo+9C6Q9IHrugdSdSKdkebDoTVDMihUyLbbGBUm4DU aKx6ATnTmPiDqqZLhSbGUivXYKNrkITPP+h4CpYNDdGn3bG1x2iPIdV2YUP7H4T9mAdh H5M5n6AHYjN/8jl8ZAKyFtXL8HMG/Bma+Ne9idF+XUclZ0iwEDJakARM8CGppqELb6Pv BVaXzZuSqsXgYYiuE+u8U2MKzz6UMOME7Ziuu7nPNbjEmsTOHrFGWFJVjRl2vgSv8PC3 xEX4U9H5lmwnhNkHAAXM5/ZRbMwyf5XuIabZEz7lWhDmQFY8nxd/9AWZV8Y1uyyQkxTr LfZQ== X-Gm-Message-State: AJIora8k6LHce+WU+vHxDkMBS1fL2/TMOBT+XAzOLVxdl2wq4mk/v3S7 MujGAhiKZmD94GlH3tCuGGgNqA/RiirXHIfR6Ro= X-Google-Smtp-Source: AGRyM1vrKVgDrOfjjVywF6J2BvIXoa3NNDaYPHZ0XyxTdYGGf+g+ftfevhkkr+MIvOkZfEB2MI2ITMpLeoNEvluY2wI= X-Received: by 2002:a05:6512:31d0:b0:47f:92c6:99f1 with SMTP id j16-20020a05651231d000b0047f92c699f1mr383198lfe.198.1656100799021; Fri, 24 Jun 2022 12:59:59 -0700 (PDT) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <8d5c4724-d511-39b1-21d7-116c91cada45@pengutronix.de> <1d1b76cf-df6f-3935-5cd2-c45ea78f2c33@pengutronix.de> <1a5ec80d-690f-285c-3da8-ccdaf5516d85@pengutronix.de> In-Reply-To: <1a5ec80d-690f-285c-3da8-ccdaf5516d85@pengutronix.de> From: Luiz Augusto von Dentz Date: Fri, 24 Jun 2022 12:59:47 -0700 Message-ID: Subject: Re: [BUG] BLE device unpairing triggers kernel panic To: Ahmad Fatoum Cc: "linux-bluetooth@vger.kernel.org" , Marcel Holtmann , "regressions@lists.linux.dev" , Pengutronix Kernel Team , Tedd Ho-Jeong An Content-Type: text/plain; charset="UTF-8" Hi Ahmad, On Fri, Jun 24, 2022 at 5:53 AM Ahmad Fatoum wrote: > > Hi Tedd, Luiz, > > On 21.06.22 20:52, Luiz Augusto von Dentz wrote: > > Hi Ahmad, Tedd, > > > > On Tue, Jun 21, 2022 at 1:32 AM Ahmad Fatoum wrote: > >> > >> Hello Luiz, > >> > >> On 20.06.22 22:18, Luiz Augusto von Dentz wrote: > >>> On Mon, Jun 20, 2022 at 3:06 AM Ahmad Fatoum wrote: > >>>> Disconnect of connection #1 being processed after new connection #2 > >>>> concluded sounds wrong. Would I be able to reconnect > >>>> afterwards or would all connections, but the first, be directly > >>>> disconnected...? > >>> > >>> That depends on the order you have queued the commands, it will be > >>> processed in the exact order it is received, that why I said it is > >>> single queue design, and it is done like that to prevent messing up > >>> with states since we know the exact order the commands will be sent. > >>> > >>>>> otherwise we need a > >>>>> different queue to handle command that abort/cancel other already in > >>>>> the queue. > >>>> > >>>> Is the revert an acceptable interim solution or are there issues > >>>> I am missing? > >>> > >>> Afaik there were problem with concurrent connections request, so what > >>> would really help us here is to have some tests to emulate this > >>> scenario with our CI, in the meantime please check if the following > >>> fixes your problem: > >>> > >>> https://gist.github.com/Vudentz/b4fff292c7f4ad55ca3299fd5ab797ae > >> > >> Doesn't help unfortunately. First pairing works as before. > >> Second still fails: > >> > >> Bluetooth: hci0: Opcode 0x200d failed: -110 > >> Bluetooth: hci0: request failed to create LE connection: err -110 > > > > Can we try to add a test in mgmt-tester to reproduce the error above? > > I am not familiar with mgmt-tester. What information do you > need to reproduce? In the meantime, can we revert the commit? > I understand that this may break other uses, but I believe > previously working stuff should have precedence.. Have a looks at: https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc/test-runner.txt And then run with: sudo tools/test-runner -k -- tools/mgmt-tester Btw, can we have the exact steps to reproduce it using bluetoothctl if possible? > Cheers, > Ahmad > > > > >> Cheers, > >> Ahmad > >> > >>> > >>>> Cheers, > >>>> Ahmad > >>>> > >>>>> > >>>>>> We've been deploying the revert for a while now and I just posted > >>>>>> it to the mailing list[1]. There have been other reports > >>>>>> of this issue with different hardware too and fixing sent_cmd > >>>>>> would likely be too complicated/time intensive for me. > >>>>>> > >>>>>> I am happy to test future patches that fix this properly though. > >>>>>> > >>>>>> [1]: https://lore.kernel.org/linux-bluetooth/20220616092418.738877-1-a.fatoum@pengutronix.de/T/#t > >>>>>> > >>>>>> Cheers, > >>>>>> Ahmad > >>>>>> > >>>>>> > >>>>>> > >>>>>>> > >>>>>>> Cheers, > >>>>>>> Ahmad > >>>>>>> > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> Pengutronix e.K. | | > >>>>>> Steuerwalder Str. 21 | http://www.pengutronix.de/ | > >>>>>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > >>>>>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > >>>>> > >>>>> > >>>>> > >>>> > >>>> > >>>> -- > >>>> Pengutronix e.K. | | > >>>> Steuerwalder Str. 21 | http://www.pengutronix.de/ | > >>>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > >>>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > >>> > >>> > >>> > >> > >> > >> -- > >> Pengutronix e.K. | | > >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | > >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > > > > > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- Luiz Augusto von Dentz