From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A217AC48BCD for ; Wed, 9 Jun 2021 17:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E006608FC for ; Wed, 9 Jun 2021 17:11:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231216AbhFIRNv (ORCPT ); Wed, 9 Jun 2021 13:13:51 -0400 Received: from mail-yb1-f180.google.com ([209.85.219.180]:34786 "EHLO mail-yb1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230152AbhFIRNu (ORCPT ); Wed, 9 Jun 2021 13:13:50 -0400 Received: by mail-yb1-f180.google.com with SMTP id i6so21877237ybm.1 for ; Wed, 09 Jun 2021 10:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=26jC/wgBZ+t1Ap5tkofW0NlWVxgOjqt14XFXYTZhyC4=; b=kFjRh2cfpp7Sb35yP/Rkj5hjgxutlnQ2M22Z6wIOe4LDfoZvDtqrrq8IaGyFB2PoVc nEkymGsVDmZQwEDSDyib8z/OQ0A8mtp5z1AOqZTNMTvYxrXNUU26mmk6fAwnoF9aliay k+FziOh3jBNynVfNc0oi1l1g2YF13GbsMXu3n+4+LV/Q/5Y/o0zshP6kOFcxGjABMElf Y2e/W0rN2ikuJdAfpPWOiKDHBb5s7q37aD/TgJzcNmmFGV7RJQ7SFFbyfLdCs238St/F i6Uo2rMArB/sP74iD8axsDXmOO2ZFvK7WzGIFjeUwGi+75eEGGd+5Vmgs/ps2a5C+BWZ a17w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=26jC/wgBZ+t1Ap5tkofW0NlWVxgOjqt14XFXYTZhyC4=; b=uecexJ2lyFxu29XQfS4nk9+FeuRn4Fl1MD21+hTy+BKXscZhXKTM4gi1rSrIjq8fta mHZGQzN/WygUeez3KdoIhd8jXql4qTYhZXNZlTP2LcwjItbUfW+u+gzaD7c+366b1ccC ffPI5Fds3IS86+xLQMKHcxypCx6onLArZ/ridXQxxdxd/bfUEXGtZTGJ7ZHZc7ay6SLQ O6e4hG4ekzMFUq7jWNSmUCUOf+pYyF+2bQRrmVK915zNUFXHMOh/7Pm7CTbr8e5hSxTT ROszqRn2RxLtnBwD+TUMnkNezlrQmYScLD+zWSIKdhKCq0GFAgbtNhLO/BLzEiWBlmvf olQw== X-Gm-Message-State: AOAM530XvPflqCkxAo2Esjf1TWdGGH7ZjXbVv086U5jrvxeGYOfjrJn3 clgP7Ln5GbOvKsmkSO8pCZDIMLdCf/siHfAQqaXXNA36 X-Google-Smtp-Source: ABdhPJyK5r+ySLCfrd9lsg7PSoxi6Qyy37pk+0Q7wzkfFNM8CYoTyLuXcOw3XB0Rg6dv1hyyXmk0FwTxY66PaQP8xBo= X-Received: by 2002:a25:c60a:: with SMTP id k10mr1360290ybf.264.1623258643018; Wed, 09 Jun 2021 10:10:43 -0700 (PDT) MIME-Version: 1.0 References: <20210608184457.3069064-1-luiz.dentz@gmail.com> <6AC22489-B3C4-49B8-AF19-A0AEC8CFD91B@holtmann.org> In-Reply-To: <6AC22489-B3C4-49B8-AF19-A0AEC8CFD91B@holtmann.org> From: Luiz Augusto von Dentz Date: Wed, 9 Jun 2021 10:10:32 -0700 Message-ID: Subject: Re: [PATCH] Bluetooth: HCI: Fix Set Extended (Scan Response) Data To: Marcel Holtmann Cc: "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Marcel, On Tue, Jun 8, 2021 at 9:52 PM Marcel Holtmann wrote: > > Hi Luiz, > > > These command do have variable length and the length can go up to 251, > > so this changes the struct to not use a fixed size and then when > > creating the PDU only the actual length of the data send to the > > controller. > > > > Signed-off-by: Luiz Augusto von Dentz > > --- > > include/net/bluetooth/hci.h | 6 ++-- > > include/net/bluetooth/hci_core.h | 8 ++--- > > net/bluetooth/hci_request.c | 51 ++++++++++++++++++-------------- > > 3 files changed, 37 insertions(+), 28 deletions(-) > > if possible, please git blame and add Fixes: tag. > > Regards > > Marcel Will do. -- Luiz Augusto von Dentz