From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Daniel Winkler <danielwinkler@google.com>
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
ChromeOS Bluetooth Upstreaming
<chromeos-bluetooth-upstreaming@chromium.org>,
Miao-chen Chou <mcchou@chromium.org>
Subject: Re: [Bluez PATCH v3 3/3] doc/advertising-api: Add adv SupportedFeatures to doc
Date: Mon, 8 Mar 2021 10:36:02 -0800 [thread overview]
Message-ID: <CABBYNZKeiHhiro2tryrku=3vjWMXuBsWfGvgnJB6Ka-7orf-Pw@mail.gmail.com> (raw)
In-Reply-To: <20210305155113.Bluez.v3.3.Ieb6522963e3f54b0d63dd88ed3ce24a8942ed73e@changeid>
Hi Daniel,
On Fri, Mar 5, 2021 at 3:59 PM Daniel Winkler <danielwinkler@google.com> wrote:
>
> Add supported features to advertising dbus api.
>
> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> ---
>
> Changes in v3:
> - Rebased onto master
>
> Changes in v2:
> - Doc: Expect empty SupportedFeatures if no support available
>
> doc/advertising-api.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/doc/advertising-api.txt b/doc/advertising-api.txt
> index 541c57004..ba9eacaae 100644
> --- a/doc/advertising-api.txt
> +++ b/doc/advertising-api.txt
> @@ -235,6 +235,7 @@ Properties byte ActiveInstances
> "2M"
> "Coded"
>
> +
Extra empty line.
> dict SupportedCapabilities [Experimental]
>
> Enumerates Advertising-related controller capabilities
> @@ -257,3 +258,22 @@ Properties byte ActiveInstances
> int16 MaxTxPower
>
> Max advertising tx power (dBm)
> +
> +
> + array{string} SupportedFeatures [readonly, optional]
This shall probably be marked as experimental for now.
> +
> + List of supported platform features. If no features
> + are available on the platform, the SupportedFeatures
> + array will be empty.
> +
> + Possible values: "CanSetTxPower"
> +
> + Indicates whether platform can
> + specify tx power on each
> + advertising instance.
> +
> + "HardwareOffload"
> +
> + Indicates whether multiple
> + advertising will be offloaded
> + to the controller.
> --
> 2.30.1.766.gb4fecdf3b7-goog
>
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2021-03-08 18:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 23:52 [Bluez PATCH v3 0/3] Expose extended adv feature support via bluez API Daniel Winkler
2021-03-05 23:52 ` [Bluez PATCH v3 1/3] advertising: Add SupportedFeatures to LEAdvertisingManager1 Daniel Winkler
2021-03-06 1:12 ` Expose extended adv feature support via bluez API bluez.test.bot
2021-03-08 18:38 ` [Bluez PATCH v3 1/3] advertising: Add SupportedFeatures to LEAdvertisingManager1 Luiz Augusto von Dentz
2021-03-05 23:52 ` [Bluez PATCH v3 2/3] client: Add adv SupportedFeatures to bluetoothctl Daniel Winkler
2021-03-05 23:52 ` [Bluez PATCH v3 3/3] doc/advertising-api: Add adv SupportedFeatures to doc Daniel Winkler
2021-03-08 18:36 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABBYNZKeiHhiro2tryrku=3vjWMXuBsWfGvgnJB6Ka-7orf-Pw@mail.gmail.com' \
--to=luiz.dentz@gmail.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=danielwinkler@google.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mcchou@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.