All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Howard Chung <howardchung@google.com>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	Yun-Hao Chung <howardchung@chromium.org>
Subject: Re: [Bluez PATCH v9 00/13] Admin policy series
Date: Wed, 4 Aug 2021 15:05:03 -0700	[thread overview]
Message-ID: <CABBYNZL9eY0ux92AMLZosUXa1p9t8d62WqLoTnrkxNg4Vq=3Ew@mail.gmail.com> (raw)
In-Reply-To: <20210803114317.801840-1-howardchung@google.com>

Hi Howard,

On Tue, Aug 3, 2021 at 4:43 AM Howard Chung <howardchung@google.com> wrote:
>
> From: Yun-Hao Chung <howardchung@chromium.org>
>
>
> Hi manintainers,
>
> This series is to
> 1. Implement a few methods in core so that a plugin can have control of
>    allowing / disallowing certain service connections.
> 2. Implement the AdminPolicy plugin. The plugin provides interfaces
>    AdminPolicySet and AdminPolicyStatus. For each policy, users should
>    set the value thorugh AdminPolicySet and query the current setting
>    through AdminPolicyStatus. We separeted these two interfaces so that
>    developers can assign different groups of users to these interfaces.
>    Currently the only policy is ServiceAllowList, which make bluez only
>    allow a list of service by specified their UUIDs, but the plugin is
>    also expected to provide more controls over other bluez behaviors.
> Since the second part is a plugin, it might not be necessary to land in
> upstream tree.
>
> Thanks.
>
> Changes in v9:
> - Fix gitlint error in patch 'core: add device callbacks to adapter
>   driver'
>
> Changes in v8:
> - Remove changes in profiles/health/
>
> Changes in v7:
> - Fix compiler errors in profiles/hdp.c
>
> Changes in v6:
> - include <errno.h> instead of <error.h> in plugins/admin.c
>
> Changes in v5:
> - Fix compiler errors in plugins/admin.c
>
> Changes in v4:
> - Update commit message (admin_policy -> admin)
> - remove old plugins/admin_policy.c
>
> Changes in v3:
> - Rename plugins/admin_policy.c -> plugins/admin.c
> - Use device_added callback in btd_adapter_driver instead of listen for
>   dbus
> - Add authorization method in profiles/health/mcap.c and block incoming
>   connections in adapter authorization function.
>
> Changes in v2:
> - Move bt_uuid_hash and bt_uuid_equal functions to adapter.c.
> - Modify the criteria to say a device is `Affected` from any-of-uuid
>   to any-of-auto-connect-profile.
> - Remove the code to remove/reprobe disallowed/allowed profiles,
>   instead, check if the service is allowed in bt_io_accept connect_cb.
> - Fix a typo in emit_property_change in
>   plugin/admin_policy.c:set_service_allowlist
> - Instead of using device_state_cb, utilize D-BUS client to watch device
>   added/removed.
> - Add a document in doc/
>
> Yun-Hao Chung (13):
>   core: add is_allowed property in btd_service
>   core: add device callbacks to adapter driver
>   core: add adapter and device allowed_uuid functions
>   core: block not allowed UUID connect in auth
>   plugins: new plugin
>   plugins/admin: add admin_policy adapter driver
>   plugins/admin: add ServiceAllowList method
>   plugins/admin: add ServiceAllowList property
>   plugins/admin: add device callbacks
>   plugins/admin: add AffectedByPolicy property
>   plugins/admin: persist policy settings
>   doc: add description of admin policy
>   doc: add admin policy file storage description
>
>  Makefile.plugins         |   5 +
>  bootstrap-configure      |   1 +
>  configure.ac             |   4 +
>  doc/admin-policy-api.txt |  65 +++++
>  doc/settings-storage.txt |  20 ++
>  plugins/admin.c          | 590 +++++++++++++++++++++++++++++++++++++++
>  src/adapter.c            | 169 ++++++++++-
>  src/adapter.h            |  22 +-
>  src/device.c             |  65 ++++-
>  src/device.h             |   2 +
>  src/profile.c            |  11 +
>  src/service.c            |  33 +++
>  src/service.h            |   2 +
>  13 files changed, 980 insertions(+), 9 deletions(-)
>  create mode 100644 doc/admin-policy-api.txt
>  create mode 100644 plugins/admin.c
>
> --
> 2.32.0.554.ge1b32706d8-goog

Applied, thanks.

-- 
Luiz Augusto von Dentz

      parent reply	other threads:[~2021-08-04 22:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03 11:43 [Bluez PATCH v9 00/13] Admin policy series Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 01/13] core: add is_allowed property in btd_service Howard Chung
2021-08-03 12:51   ` Admin policy series bluez.test.bot
2021-08-03 11:43 ` [Bluez PATCH v9 02/13] core: add device callbacks to adapter driver Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 03/13] core: add adapter and device allowed_uuid functions Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 04/13] core: block not allowed UUID connect in auth Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 05/13] plugins: new plugin Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 06/13] plugins/admin: add admin_policy adapter driver Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 07/13] plugins/admin: add ServiceAllowList method Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 08/13] plugins/admin: add ServiceAllowList property Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 09/13] plugins/admin: add device callbacks Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 10/13] plugins/admin: add AffectedByPolicy property Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 11/13] plugins/admin: persist policy settings Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 12/13] doc: add description of admin policy Howard Chung
2021-08-03 11:43 ` [Bluez PATCH v9 13/13] doc: add admin policy file storage description Howard Chung
2021-08-04 22:05 ` Luiz Augusto von Dentz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABBYNZL9eY0ux92AMLZosUXa1p9t8d62WqLoTnrkxNg4Vq=3Ew@mail.gmail.com' \
    --to=luiz.dentz@gmail.com \
    --cc=howardchung@chromium.org \
    --cc=howardchung@google.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.