All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Arman Uguray <armansito@chromium.org>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ v1 00/14] Rewrite local GATT server using shared/gatt
Date: Mon, 16 Feb 2015 11:13:38 +0200	[thread overview]
Message-ID: <CABBYNZLYNq69wxYhSAzbzTtkNC_eQciwkoufptmq3tfchg=CBQ@mail.gmail.com> (raw)
In-Reply-To: <1423711064-7390-1-git-send-email-armansito@chromium.org>

Hi Arman,

On Thu, Feb 12, 2015 at 5:17 AM, Arman Uguray <armansito@chromium.org> wrote:
> *v1: Addressed comments by jamuraa and vudentz:
>   - Now passing bt_att instead of bdaddr_t in gatt_db callbacks and functions.
>     I have not run the tests on the android side here, so I would appreciate it
>     if you can run them.
>   - Renamed src/gatt-server to src/gatt-database for now. Added TODO item for
>     refactoring this later.
>   - Updated the TODO items for GATT.
>
> This patch set includes patches that rewrite the local GATT server using
> shared/gatt. This in effect invalidates the existing src/attrib-server in
> favor of a new src/gatt-server.
>
> Arman Uguray (14):
>   CHROMIUM: shared/att: Add bt_att_get_fd
>   CHROMIUM: shared/gatt: Pass bt_att instead of bdaddr_t
>   CHROMIUM: core: Introduce btd_gatt_database
>   CHROMIUM: core: Attach gatt-server to bt_att
>   CHROMIUM: core: gatt: Add GATT/GAP services to local db
>   CHROMIUM: core: Add GATT UUIDs to Adapter1.UUIDs
>   CHROMIUM: core: Support per-client CCC state
>   CHROMIUM: core: Setup added/removed handlers in GATT database
>   CHROMIUM: core: Add Service Changed characteristic
>   CHROMIUM: core: device: Add getter for GATT server
>   CHROMIUM: core: gatt-server: Send "Service Changed"
>   CHROMIUM: core: adapter: Send UUIDs changed for GATT services
>   CHROMIUM: shared/gatt: Don't incorrectly terminate discovery
>   TODO: Update GATT items.
>
>  Makefile.am               |   1 +
>  TODO                      |  54 ++--
>  android/gatt.c            |  98 ++++--
>  src/adapter.c             |  59 +++-
>  src/device.c              |  52 +++-
>  src/device.h              |   1 +
>  src/gatt-client.c         |   1 +
>  src/gatt-database.c       | 766 ++++++++++++++++++++++++++++++++++++++++++++++
>  src/gatt-database.h       |  29 ++
>  src/main.c                |   3 +
>  src/shared/att.c          |   8 +
>  src/shared/att.h          |   2 +
>  src/shared/gatt-client.c  |   6 +-
>  src/shared/gatt-db.c      |  10 +-
>  src/shared/gatt-db.h      |   8 +-
>  src/shared/gatt-helpers.c |   3 +-
>  src/shared/gatt-server.c  |  32 +-
>  tools/btgatt-server.c     |  18 +-
>  unit/test-gatt.c          |   5 +-
>  19 files changed, 1052 insertions(+), 104 deletions(-)
>  create mode 100644 src/gatt-database.c
>  create mode 100644 src/gatt-database.h
>
> --
> 2.2.0.rc0.207.ga3a616c

First 2 are now applied, I reworking the btd_gatt_database API.



-- 
Luiz Augusto von Dentz

      parent reply	other threads:[~2015-02-16  9:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12  3:17 [PATCH BlueZ v1 00/14] Rewrite local GATT server using shared/gatt Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 01/14] shared/att: Add bt_att_get_fd Arman Uguray
2015-02-12 13:40   ` Luiz Augusto von Dentz
2015-02-12 18:21     ` Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 02/14] shared/gatt: Pass bt_att instead of bdaddr_t Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 03/14] core: Introduce btd_gatt_database Arman Uguray
2015-02-13 16:06   ` Luiz Augusto von Dentz
2015-02-13 16:21     ` Arman Uguray
2015-02-17 12:03       ` Luiz Augusto von Dentz
2015-02-18  0:43         ` Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 04/14] core: Attach gatt-server to bt_att Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 05/14] core: gatt: Add GATT/GAP services to local db Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 06/14] core: Add GATT UUIDs to Adapter1.UUIDs Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 07/14] core: Support per-client CCC state Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 08/14] core: Setup added/removed handlers in GATT database Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 09/14] core: Add Service Changed characteristic Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 10/14] core: device: Add getter for GATT server Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 11/14] core: gatt-server: Send "Service Changed" Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 12/14] core: adapter: Send UUIDs changed for GATT services Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 13/14] shared/gatt: Don't incorrectly terminate discovery Arman Uguray
2015-02-12  3:17 ` [PATCH BlueZ v1 14/14] TODO: Update GATT items Arman Uguray
2015-02-16  9:13 ` Luiz Augusto von Dentz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABBYNZLYNq69wxYhSAzbzTtkNC_eQciwkoufptmq3tfchg=CBQ@mail.gmail.com' \
    --to=luiz.dentz@gmail.com \
    --cc=armansito@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.