From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0202110E0 for ; Mon, 16 May 2022 15:45:20 +0000 (UTC) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-2ef5380669cso157872867b3.9 for ; Mon, 16 May 2022 08:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fnKHIkN0TU++izapmIFi8Ty+LNPCPzgGOdIpl087eMA=; b=iTcoOlahc6mNkkH9KN1UbL8/FqrKWmwWC3yXua2GycFg92x6rtngNdWTVZd0vbWmvo IS31fC3vbQgVufrjL9knZDTJqUptFr2aaqDFIneUmpWLvFJa+Wu+UxrjhyP7Rgj7bYw6 zGYLwfOJbeMXxZZo4hcNGWPwaUtzNrt3Su/koMOjF0/lJfcxtgYk49vf4uomzBQ/y5my 1yNpaUl8mO2poMKwfULV989QV1N1BB5iZDEFJA+CXZ4MAPWqN9ygMf71IFgVuS2VYweH bgcJ++RWpGXf45WXPIGOJztqFDbRlw5pqIk7yfMCXeIH15TdPWKecQfiVFMacIT+G95P EkFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fnKHIkN0TU++izapmIFi8Ty+LNPCPzgGOdIpl087eMA=; b=SQ0ZZ7bmROjbyYET34pe9kLvQ+k/NJHQeEDG6IYztCUZuTr4GczW49HjA4tAbulZ38 mKSTpLGxRt1ShQZiYzRtYBqtOKgvAhJ98jISGqrFU8UW9YEWjUPUeyM6LKBVwoElMxyk E96Ly8e5cReLgu8sTbxahnNkg0OFtIhJF3ARf0SkOvCK0wmS9jd5CCCIKvLN8u4LgXmt BuZjZXTMFT3jZwUpVu6ponVVDXgvVq00KhEKPqZ7FiQiYzYIk16kepaGDtLKa20IWK7t q26H1foZ6fk9mkPU7DPVWVZqik93RaL01wncj0ws0gK15Q9ENVmhujBc5U+2A2SJhDZV Wipw== X-Gm-Message-State: AOAM531v9wzclwow2NjuTtIEJwQ1gfFQRS6FkpmoECZ0hLWNHev9z1Sq z4awRhwcIT82P41lN/Sroik1ZnDmIUh4e4mle96t6Q== X-Google-Smtp-Source: ABdhPJwi/PDSBCPu8w13weeGP3GKG4Kc/dHnqpDwTulTE1xr8903vsYGeGb18xGWe7Di7/TDqqAZCDtrmcivBggYEX4= X-Received: by 2002:a81:4ecf:0:b0:2fe:d9f2:15b3 with SMTP id c198-20020a814ecf000000b002fed9f215b3mr10749397ywb.305.1652715919792; Mon, 16 May 2022 08:45:19 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-9-samitolvanen@google.com> <202205141449.87738FDF@keescook> In-Reply-To: <202205141449.87738FDF@keescook> From: Sami Tolvanen Date: Mon, 16 May 2022 08:44:44 -0700 Message-ID: Subject: Re: [RFC PATCH v2 08/21] psci: Fix the function type for psci_initcall_t To: Kees Cook Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Sat, May 14, 2022 at 2:50 PM Kees Cook wrote: > > On Fri, May 13, 2022 at 01:21:46PM -0700, Sami Tolvanen wrote: > > Functions called through a psci_initcall_t pointer all have > > non-const arguments. Fix the type definition to avoid tripping > > indirect call checks with CFI_CLANG. > > > > Reported-by: Mark Rutland > > Signed-off-by: Sami Tolvanen > > This could land separately from this series, too, yes? Correct. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64EA6C433F5 for ; Mon, 16 May 2022 15:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bwsx6jvGmSyyCRhTOX/M2SJmEn4veZExPDnFtO/2Hnc=; b=OKvQZxiDQ5h3+D V024TrY4voAvJPWcFP+HqNA/AKcIIE0E5VRLR47xzGXtSrLE0hv+rxU9GbvAvKgM1xJdQkoWJerzr AOagJwCOgXTPhklItt5s1TsbP8wGzetOCpYRdFNw4O4H1zNff5unKETbm9lPRWg47c8IEmx21+nmn rhOT7FmCvaRhvXpuqLghUUvOP4PfmEF7Bmubr0LIfrzwG9oS7SYQ0sTUzZoXz7HLoCWF9AwI2RrPq G2ixhAPN9YILDR8dvJoUFH3EAVbS2ffuLXT+Lb4e7bEdhMR1Ocyc61hL5VkV3xblZrPNixxY+06kO ZyARXiVr25m8C+eN9myQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqcuT-008jAM-VJ; Mon, 16 May 2022 15:45:26 +0000 Received: from mail-yw1-x1130.google.com ([2607:f8b0:4864:20::1130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqcuR-008j94-E9 for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 15:45:24 +0000 Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-2ec42eae76bso157753887b3.10 for ; Mon, 16 May 2022 08:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fnKHIkN0TU++izapmIFi8Ty+LNPCPzgGOdIpl087eMA=; b=iTcoOlahc6mNkkH9KN1UbL8/FqrKWmwWC3yXua2GycFg92x6rtngNdWTVZd0vbWmvo IS31fC3vbQgVufrjL9knZDTJqUptFr2aaqDFIneUmpWLvFJa+Wu+UxrjhyP7Rgj7bYw6 zGYLwfOJbeMXxZZo4hcNGWPwaUtzNrt3Su/koMOjF0/lJfcxtgYk49vf4uomzBQ/y5my 1yNpaUl8mO2poMKwfULV989QV1N1BB5iZDEFJA+CXZ4MAPWqN9ygMf71IFgVuS2VYweH bgcJ++RWpGXf45WXPIGOJztqFDbRlw5pqIk7yfMCXeIH15TdPWKecQfiVFMacIT+G95P EkFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fnKHIkN0TU++izapmIFi8Ty+LNPCPzgGOdIpl087eMA=; b=OiJ4fQV0pzPlfX4011ZnMoWIPW0wuwnkpOXD06GM0kLvw6DiBUpXxIteMDjTgDHqL1 09iaGWluHjmCWr36s55/1R1EgF06ys2nPLbHM4Vi1r9irA0fe3jbKcq3YkDecBXW6Vb8 2dwa20y4pRoV/CD3yNIYcXhBXaKBaU1Y8Xl4/sriPqeCPIrO7dPqo5du2nkkMdURVhCo LbcnlS5gzyE/7g9U0AwF6FjBWSdLDkecUQWueUqYHSCViplXmA+gcvMoiBsgSCcOhORm CLynh0cY48HPRLYNCbKYbpABjEh0PLP+GgmEzEvRUzdkUz6ngOnOCb70uWosyARQU91p oAiA== X-Gm-Message-State: AOAM532PirSJHFYFCV5FtJxGGaXM5iWlTR+fZ1GP3rYXe/u4q2ea0RTE uqpqDibnRWoWW5hImWumoWxwjz6zX8FY1kL6282i0g== X-Google-Smtp-Source: ABdhPJwi/PDSBCPu8w13weeGP3GKG4Kc/dHnqpDwTulTE1xr8903vsYGeGb18xGWe7Di7/TDqqAZCDtrmcivBggYEX4= X-Received: by 2002:a81:4ecf:0:b0:2fe:d9f2:15b3 with SMTP id c198-20020a814ecf000000b002fed9f215b3mr10749397ywb.305.1652715919792; Mon, 16 May 2022 08:45:19 -0700 (PDT) MIME-Version: 1.0 References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-9-samitolvanen@google.com> <202205141449.87738FDF@keescook> In-Reply-To: <202205141449.87738FDF@keescook> From: Sami Tolvanen Date: Mon, 16 May 2022 08:44:44 -0700 Message-ID: Subject: Re: [RFC PATCH v2 08/21] psci: Fix the function type for psci_initcall_t To: Kees Cook Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_084523_503471_45CA122D X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 14, 2022 at 2:50 PM Kees Cook wrote: > > On Fri, May 13, 2022 at 01:21:46PM -0700, Sami Tolvanen wrote: > > Functions called through a psci_initcall_t pointer all have > > non-const arguments. Fix the type definition to avoid tripping > > indirect call checks with CFI_CLANG. > > > > Reported-by: Mark Rutland > > Signed-off-by: Sami Tolvanen > > This could land separately from this series, too, yes? Correct. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel