From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 703EAC34056 for ; Wed, 19 Feb 2020 18:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44D7420801 for ; Wed, 19 Feb 2020 18:27:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DMdoPkJf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726651AbgBSS1q (ORCPT ); Wed, 19 Feb 2020 13:27:46 -0500 Received: from mail-vk1-f195.google.com ([209.85.221.195]:33409 "EHLO mail-vk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726582AbgBSS1p (ORCPT ); Wed, 19 Feb 2020 13:27:45 -0500 Received: by mail-vk1-f195.google.com with SMTP id i78so427507vke.0 for ; Wed, 19 Feb 2020 10:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l8bheu//eOsUC2rG1tcM8D2woU+rRRO7+NHd/SAby40=; b=DMdoPkJfjI8vEiQ931OXimak2rqeezogGTA8Jz0YUFlSK+iP3iGUiJm8P0zxfSazbl sTLes5Pdhak910J52lP/cGVjDxzDihqkqyUztiFUlwZg0VhXzKO1IB9YGArPtZqB6CV3 5i85IFWDdO9zpfwEZ9XXCunsWgqWEwKKlhfY1B2U5wv6+QD3YcbhFr+s44GC4sg72+rA n2ie3yBEKdehbzyFS5WDKMUNUnSdwc2SvQkZ5DylB/so9f2QssueydxU/mKohLfzAbZz K3OtN1dWSEkKMUwc/C1SbRHw0naFdurKZuH+kXBfdy4MpfLQng5Kl2vAtDn1OZwbvUbU +EpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l8bheu//eOsUC2rG1tcM8D2woU+rRRO7+NHd/SAby40=; b=Usbu8iqTAxBGN+HT66U77xD18pfmBbrXVY6RTmcMsu7A7/UxHXCObRYtkl+6vrWjQE iPiDNKjuScA/23heTAPB9+aonqxosTIeCfW0BFx+NevpRmc2mnr1hBARnI4PEShkPkv8 wB6aLBbecTGVtE5ART8l1WZKuNQUtRaR/Lexfh4KITrPKHN7bWgyXnUgnDXTIyqgJ0az gjen4cJexq6aH4LNlNyAvcXKzQIelO+GImUCcLbjth1kuy9kxb2Fe63mpMJoX5K8nZ/g MI5yUfvVW7IjHw7F4wliLlDVRoGQghen8SeQjFVmaUfoNRdxv0U1et7S3Js+r3IfYNpI CYqA== X-Gm-Message-State: APjAAAV5SI1WgBVNIpK7nRkw/Kcjv3HSo9yIS2kFShMR/Az7AU1uTpvz 7VOtms1IzuUKv2z3AIxaNVoit9d/zRyDyNTrFdgI4A== X-Google-Smtp-Source: APXvYqz43ZWMlwcCQPP90XUO0jIibofgqeEtAm/3NdUy/lBowdl1d7auUgQbzj7b/uQk3jHx8Zbly6t36F7bSB8gUac= X-Received: by 2002:a1f:e784:: with SMTP id e126mr12203230vkh.102.1582136864292; Wed, 19 Feb 2020 10:27:44 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20200219000817.195049-1-samitolvanen@google.com> <20200219000817.195049-13-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Wed, 19 Feb 2020 10:27:33 -0800 Message-ID: Subject: Re: [PATCH v8 12/12] efi/libstub: disable SCS To: Ard Biesheuvel Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Mark Rutland , James Morse , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 18, 2020 at 11:41 PM Ard Biesheuvel wrote: > > On Wed, 19 Feb 2020 at 01:09, Sami Tolvanen wrote: > > > > +# remove SCS flags from all objects in this directory > > +KBUILD_CFLAGS := $(filter-out -ffixed-x18 $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) > > + > > I don't see why you'd need to remove -ffixed-x18 again here. Not using > x18 anywhere in the kernel is a much more maintainable approach. Sure, I will drop -ffixed-x18 from here in v9. Thanks, Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2052C3405F for ; Wed, 19 Feb 2020 18:27:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A90F020801 for ; Wed, 19 Feb 2020 18:27:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qXizkVIt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="DMdoPkJf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A90F020801 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NoRK7iE6fxsjjHKIAXGco8EbmG58oG4yl0yYhT2lzU4=; b=qXizkVItbpT3eD NaVsTzSrIhFBoix6pm71yOOzC8zujQDzU4NI3DGxxGAfuZusYBU8eX2k2sQ7tU4Ve9KHbPVp5ZGpu 818fOaq5PXr0uY+dyaNDrIA1dnWLV4FKqKOQRN/GVTzL+Uy93DCDK4lNAVr9DaDvVl4wcTjDSzQC5 uUK+IcrU0LSz6w5cVSnMH8CDGeoiVovVQzs/ezdglH7mEQXig79wwfXw/0iZXGa1nyUMw0mU+CPNW 0S289ctp3S3rWZvdoMkYNXBnh+x7ShdUl/q+XZRzsY4PM+Wv2de5NrzBOAXoCASS2hgYhtI9RQOJl EwzdOAYorW4V4i9DhAAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4U4d-0000Td-8E; Wed, 19 Feb 2020 18:27:51 +0000 Received: from mail-vk1-xa41.google.com ([2607:f8b0:4864:20::a41]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4U4a-0000Sq-Cl for linux-arm-kernel@lists.infradead.org; Wed, 19 Feb 2020 18:27:49 +0000 Received: by mail-vk1-xa41.google.com with SMTP id t129so423144vkg.6 for ; Wed, 19 Feb 2020 10:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l8bheu//eOsUC2rG1tcM8D2woU+rRRO7+NHd/SAby40=; b=DMdoPkJfjI8vEiQ931OXimak2rqeezogGTA8Jz0YUFlSK+iP3iGUiJm8P0zxfSazbl sTLes5Pdhak910J52lP/cGVjDxzDihqkqyUztiFUlwZg0VhXzKO1IB9YGArPtZqB6CV3 5i85IFWDdO9zpfwEZ9XXCunsWgqWEwKKlhfY1B2U5wv6+QD3YcbhFr+s44GC4sg72+rA n2ie3yBEKdehbzyFS5WDKMUNUnSdwc2SvQkZ5DylB/so9f2QssueydxU/mKohLfzAbZz K3OtN1dWSEkKMUwc/C1SbRHw0naFdurKZuH+kXBfdy4MpfLQng5Kl2vAtDn1OZwbvUbU +EpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l8bheu//eOsUC2rG1tcM8D2woU+rRRO7+NHd/SAby40=; b=ZLqNUU4c0vYNgHDwW9dxr7wZG0xrWdV2R9aewwjWiseMjwdTZoYBvBVgQfHN1Huqov GJjqvvai7cIF7n4RnrH3NqHJYLsJPS8ZXPuMCChfhbD0EfVhgk50ZDQRzfRKXa98Wnic zGPoGM/tPqQHiXo0E/80lUkwwvvaf6Pu0DfaACgSVW3VfznJUtvSL+0rMexX+Gcg49Kf KiEM5jKbEYjnCLznDqDDa9Rq6oZ+MECvDUqiHT5nw/ykey5Oe9hqXsCh5tStziCvU3nT JaSnsNRDle4yytF8z5nkxF2Wm8YdkfDRZaPAQo3KTnieqtP2bCKSyswDHwEgcDFef6Lp l8cQ== X-Gm-Message-State: APjAAAUOyRkeRlReq4EPZpK5oSHS4Jh7iQIRr8knkKhp6kcCI3KsZtSX oXzzy2SmrYt6ltf7lslO5pmOS/IcbQ4mZx55aIq31w== X-Google-Smtp-Source: APXvYqz43ZWMlwcCQPP90XUO0jIibofgqeEtAm/3NdUy/lBowdl1d7auUgQbzj7b/uQk3jHx8Zbly6t36F7bSB8gUac= X-Received: by 2002:a1f:e784:: with SMTP id e126mr12203230vkh.102.1582136864292; Wed, 19 Feb 2020 10:27:44 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20200219000817.195049-1-samitolvanen@google.com> <20200219000817.195049-13-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Wed, 19 Feb 2020 10:27:33 -0800 Message-ID: Subject: Re: [PATCH v8 12/12] efi/libstub: disable SCS To: Ard Biesheuvel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_102748_454554_FBCCC2E0 X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Jann Horn , Masahiro Yamada , Catalin Marinas , Kernel Hardening , Nick Desaulniers , Linux Kernel Mailing List , Steven Rostedt , Miguel Ojeda , clang-built-linux , James Morse , Masami Hiramatsu , Marc Zyngier , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 18, 2020 at 11:41 PM Ard Biesheuvel wrote: > > On Wed, 19 Feb 2020 at 01:09, Sami Tolvanen wrote: > > > > +# remove SCS flags from all objects in this directory > > +KBUILD_CFLAGS := $(filter-out -ffixed-x18 $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) > > + > > I don't see why you'd need to remove -ffixed-x18 again here. Not using > x18 anywhere in the kernel is a much more maintainable approach. Sure, I will drop -ffixed-x18 from here in v9. Thanks, Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82500C34056 for ; Wed, 19 Feb 2020 18:28:04 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id DA2F420801 for ; Wed, 19 Feb 2020 18:28:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DMdoPkJf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA2F420801 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17848-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 15361 invoked by uid 550); 19 Feb 2020 18:27:57 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 14314 invoked from network); 19 Feb 2020 18:27:56 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l8bheu//eOsUC2rG1tcM8D2woU+rRRO7+NHd/SAby40=; b=DMdoPkJfjI8vEiQ931OXimak2rqeezogGTA8Jz0YUFlSK+iP3iGUiJm8P0zxfSazbl sTLes5Pdhak910J52lP/cGVjDxzDihqkqyUztiFUlwZg0VhXzKO1IB9YGArPtZqB6CV3 5i85IFWDdO9zpfwEZ9XXCunsWgqWEwKKlhfY1B2U5wv6+QD3YcbhFr+s44GC4sg72+rA n2ie3yBEKdehbzyFS5WDKMUNUnSdwc2SvQkZ5DylB/so9f2QssueydxU/mKohLfzAbZz K3OtN1dWSEkKMUwc/C1SbRHw0naFdurKZuH+kXBfdy4MpfLQng5Kl2vAtDn1OZwbvUbU +EpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l8bheu//eOsUC2rG1tcM8D2woU+rRRO7+NHd/SAby40=; b=fTVmwEbiIi05zfp6XSzBIkrpSwjrNDjbAyGe7Mj0H5WwdtMgG2fuuFtW4O9y7O0eoi nQj02nyrF5Q8RdKoxIZCqBoA7BhGaUiMS6JtqduCDdccOHBgHbYYuIchpESZLbwmhKVn +dd9jeGDTNEVSrTNIYW2CUEJDogo9n33HiSqCR14CxhEWf2NpJQZ2DjafIKuLktog6NR Vb6hmKumjNIvV2YR2osAZHZHAYFZuZ+DJYGWcNuko+SCDZjpLAAGEH+fn4JWddgbIvL5 1M/6L5e03XcStKqHPIdtHFbwOfR2/yEcBWC4XBrmnUckPAq2bxYgc+zLbRp2VOLh0rK+ ohVw== X-Gm-Message-State: APjAAAV0dRXwnJFdimBb04bhPh7C2weXGYTNO7X3Mt1ddGQVCSzz2KP0 ZVGxTtmxft5wVOHZURdaAzJ62OPDUu9fn+QaAo7+yQ== X-Google-Smtp-Source: APXvYqz43ZWMlwcCQPP90XUO0jIibofgqeEtAm/3NdUy/lBowdl1d7auUgQbzj7b/uQk3jHx8Zbly6t36F7bSB8gUac= X-Received: by 2002:a1f:e784:: with SMTP id e126mr12203230vkh.102.1582136864292; Wed, 19 Feb 2020 10:27:44 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20200219000817.195049-1-samitolvanen@google.com> <20200219000817.195049-13-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Wed, 19 Feb 2020 10:27:33 -0800 Message-ID: Subject: Re: [PATCH v8 12/12] efi/libstub: disable SCS To: Ard Biesheuvel Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Mark Rutland , James Morse , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" On Tue, Feb 18, 2020 at 11:41 PM Ard Biesheuvel wrote: > > On Wed, 19 Feb 2020 at 01:09, Sami Tolvanen wrote: > > > > +# remove SCS flags from all objects in this directory > > +KBUILD_CFLAGS := $(filter-out -ffixed-x18 $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) > > + > > I don't see why you'd need to remove -ffixed-x18 again here. Not using > x18 anywhere in the kernel is a much more maintainable approach. Sure, I will drop -ffixed-x18 from here in v9. Thanks, Sami