From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2623FC432C3 for ; Fri, 15 Nov 2019 18:34:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F234F20730 for ; Fri, 15 Nov 2019 18:34:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DPVoi3lq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726997AbfKOSel (ORCPT ); Fri, 15 Nov 2019 13:34:41 -0500 Received: from mail-vs1-f68.google.com ([209.85.217.68]:46320 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbfKOSek (ORCPT ); Fri, 15 Nov 2019 13:34:40 -0500 Received: by mail-vs1-f68.google.com with SMTP id m6so6931356vsn.13 for ; Fri, 15 Nov 2019 10:34:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z/RQj5FqYPBFFb/BHpJq3oq0/JIX3F5mcr3Ic1KDLoA=; b=DPVoi3lqXCZqeWh9romeMaws5hqXk7f+VlyR9XfhSR/9BdSIhcYmEux7SQ5St6jgAv Qy7JHhLn5W/E49pgWgOuvApN0oQk7kKUVdvzqM0GYzY6xGnHrcu3/C3H75y46ixSvuca LjPAO51k95incrTQsuJOy8ZRL6zlZ92V+cSt7WAY8zd/QGfPmISheb/46Q0qXikywE7H 4Xh/pOiL99Mk+H/Q9TdrDS1OLq9XHIwJxh3HXyW7oVjDzKgHZwFJFMojZFKSuD9lUD8s TsrwyDeDC5tuRiLuIUH3CjrVYpkyH7ytqD6EnefisDfsVDoa6xNUGa6ZrfAwBeh0RQqM vZrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z/RQj5FqYPBFFb/BHpJq3oq0/JIX3F5mcr3Ic1KDLoA=; b=dpjIMXImc0HQtWl1gSvlMRaA/jUTq1f7LpZv1AV1iWOCQh/TNqEbFPgMRjRh14LbIh /twRYy7g3KMi+LMTIY95+NqJGfiIxmx4bOFqo/XB3j4IOZ0s5jX2Mp2+COSbe7tQIjPL S1Ke8MZdjoN54vGjzIbv8a8N9uxUrTkRl8+ZnquxeIJ5EYrYGcBjG1sHCH2S6nLl4FUR ZFJQOC3mZva2XUqOkRfoJ4SyswE/DFpZrYIY3K71ddtmziZZOEk6UZq6B5kY2eazt93b dnox+XE9R2sfF9Z4dBhqIBOE3+vkY0hFoSxypLwzW4MZf2Jd6dxPNPfeCgmVZI3rfO6Y N0kQ== X-Gm-Message-State: APjAAAVWLAFy/FfnpPemzcnKE2AZQWDJQg/9LyRCzxnhIkr4wE8V8DeW zWuxR/ikWFDzLO6ZBVrXZn9LJJLTBxTDTMJYLk3rHw== X-Google-Smtp-Source: APXvYqy9ZihhNwSz15zAc2n9wuqx0KKCFEmVQyQmPiar9gQiv4PEvu699gEh+PcCmRyXpyUO7fCyzGA8P+JoII/zuY4= X-Received: by 2002:a67:e951:: with SMTP id p17mr5243152vso.112.1573842878866; Fri, 15 Nov 2019 10:34:38 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191105235608.107702-1-samitolvanen@google.com> <20191105235608.107702-6-samitolvanen@google.com> <20191115153705.GJ41572@lakrids.cambridge.arm.com> In-Reply-To: <20191115153705.GJ41572@lakrids.cambridge.arm.com> From: Sami Tolvanen Date: Fri, 15 Nov 2019 10:34:25 -0800 Message-ID: Subject: Re: [PATCH v5 05/14] add support for Clang's Shadow Call Stack (SCS) To: Mark Rutland Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 15, 2019 at 7:37 AM Mark Rutland wrote: > > +config SHADOW_CALL_STACK_VMAP > > + bool > > + depends on SHADOW_CALL_STACK > > + help > > + Use virtually mapped shadow call stacks. Selecting this option > > + provides better stack exhaustion protection, but increases per-thread > > + memory consumption as a full page is allocated for each shadow stack. > > The bool needs some display text to make it selectable. > > This should probably be below SHADOW_CALL_STACK so that when it shows up > in menuconfig it's where you'd expect it to be. > > I locally hacked that in, but when building defconfig + > SHADOW_CALL_STACK + SHADOW_CALL_STACK_VMAP, the build explodes as below: Ugh, thanks for pointing this out. I'll fix this in v6. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E9CC432C3 for ; Fri, 15 Nov 2019 18:34:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A4412073B for ; Fri, 15 Nov 2019 18:34:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sAeRklml"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="DPVoi3lq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A4412073B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l0lsvtzPuXzqBqjUwF2zRsr+IrZc3SuXiUYsc+5Jl+Y=; b=sAeRklmlWtDlXp mSLJzQGDGz2IjlYEIKIdrze6bhRedg8TWormLrS2Td8bv5FFUuONfAc29OeTFKZuuSxY7GjW0cSKQ DhtXdjRea8aBDzsTQl9Zgg5ZwK0sAbUNNumdYoXWWJZXidJQS1jIfWd6CkkyaS4ICqAgOE8AVRwZm EW4KzXK/GfwwQXsdvHAmIpNKh3tkobnA1Ofl9Bw6TUmkb7RqoIzoOCPRJkTaNb36EtQgk7Ndm2XtW 1khHdG7ZA2riqn07xvHFKQlNC+wGKsOp37tkac7ALO1Pz3t3vOr8zJOKGVMWcIsNsQx8Bxnkx7Plv tH/uugpU01iebjXX8uXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVgQi-0000Ds-H4; Fri, 15 Nov 2019 18:34:48 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVgQg-0000D6-D4 for linux-arm-kernel@lists.infradead.org; Fri, 15 Nov 2019 18:34:47 +0000 Received: by mail-vs1-xe44.google.com with SMTP id 190so6952908vss.8 for ; Fri, 15 Nov 2019 10:34:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z/RQj5FqYPBFFb/BHpJq3oq0/JIX3F5mcr3Ic1KDLoA=; b=DPVoi3lqXCZqeWh9romeMaws5hqXk7f+VlyR9XfhSR/9BdSIhcYmEux7SQ5St6jgAv Qy7JHhLn5W/E49pgWgOuvApN0oQk7kKUVdvzqM0GYzY6xGnHrcu3/C3H75y46ixSvuca LjPAO51k95incrTQsuJOy8ZRL6zlZ92V+cSt7WAY8zd/QGfPmISheb/46Q0qXikywE7H 4Xh/pOiL99Mk+H/Q9TdrDS1OLq9XHIwJxh3HXyW7oVjDzKgHZwFJFMojZFKSuD9lUD8s TsrwyDeDC5tuRiLuIUH3CjrVYpkyH7ytqD6EnefisDfsVDoa6xNUGa6ZrfAwBeh0RQqM vZrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z/RQj5FqYPBFFb/BHpJq3oq0/JIX3F5mcr3Ic1KDLoA=; b=WDM50PsJdqvsS//PzsTdCZfbCHia2fE9CY61SMuhJnfRmNjqWjisk5cjcdKknPKYj/ bZIqjFKApi/Jg6Qvc7rTPduArwKf2McfEDgl1FbYY+lx4SEK5Al1WytQmUfSzc4sLjKY TnPS8PPIaV7dXSEw4sacetdL1SfGavRSrmmGBfa+YbmsGnJ4mQmE/+Nk4EmNjQAbk4UG FbdtHylA0wZcBsXSdnKZ/vfWjjGaMaATFDNE79v1oWR2QV+bI5jtYH0Y6GjajmuYSEKU Gl66fMGc3QFfwjIsw2xqlXGa15uL8QzoI8Pq7OXHrtBZWgQnU2Egc6keQcrI2h8xlE0s douA== X-Gm-Message-State: APjAAAUEjE6vyNu/YCUFNG8f5fWlT/twoJl95mGNPTGRu2XfUcrd29c4 /IChZwiN0e1NdYMEjr4CCtn9X5LeV4lPcIyamJIwug== X-Google-Smtp-Source: APXvYqy9ZihhNwSz15zAc2n9wuqx0KKCFEmVQyQmPiar9gQiv4PEvu699gEh+PcCmRyXpyUO7fCyzGA8P+JoII/zuY4= X-Received: by 2002:a67:e951:: with SMTP id p17mr5243152vso.112.1573842878866; Fri, 15 Nov 2019 10:34:38 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191105235608.107702-1-samitolvanen@google.com> <20191105235608.107702-6-samitolvanen@google.com> <20191115153705.GJ41572@lakrids.cambridge.arm.com> In-Reply-To: <20191115153705.GJ41572@lakrids.cambridge.arm.com> From: Sami Tolvanen Date: Fri, 15 Nov 2019 10:34:25 -0800 Message-ID: Subject: Re: [PATCH v5 05/14] add support for Clang's Shadow Call Stack (SCS) To: Mark Rutland X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191115_103446_444348_14675EA2 X-CRM114-Status: GOOD ( 11.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , clang-built-linux , Masami Hiramatsu , Marc Zyngier , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 15, 2019 at 7:37 AM Mark Rutland wrote: > > +config SHADOW_CALL_STACK_VMAP > > + bool > > + depends on SHADOW_CALL_STACK > > + help > > + Use virtually mapped shadow call stacks. Selecting this option > > + provides better stack exhaustion protection, but increases per-thread > > + memory consumption as a full page is allocated for each shadow stack. > > The bool needs some display text to make it selectable. > > This should probably be below SHADOW_CALL_STACK so that when it shows up > in menuconfig it's where you'd expect it to be. > > I locally hacked that in, but when building defconfig + > SHADOW_CALL_STACK + SHADOW_CALL_STACK_VMAP, the build explodes as below: Ugh, thanks for pointing this out. I'll fix this in v6. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 827BCC432C3 for ; Fri, 15 Nov 2019 18:34:59 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id C4C592073B for ; Fri, 15 Nov 2019 18:34:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DPVoi3lq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4C592073B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17392-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 30308 invoked by uid 550); 15 Nov 2019 18:34:51 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 30288 invoked from network); 15 Nov 2019 18:34:51 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z/RQj5FqYPBFFb/BHpJq3oq0/JIX3F5mcr3Ic1KDLoA=; b=DPVoi3lqXCZqeWh9romeMaws5hqXk7f+VlyR9XfhSR/9BdSIhcYmEux7SQ5St6jgAv Qy7JHhLn5W/E49pgWgOuvApN0oQk7kKUVdvzqM0GYzY6xGnHrcu3/C3H75y46ixSvuca LjPAO51k95incrTQsuJOy8ZRL6zlZ92V+cSt7WAY8zd/QGfPmISheb/46Q0qXikywE7H 4Xh/pOiL99Mk+H/Q9TdrDS1OLq9XHIwJxh3HXyW7oVjDzKgHZwFJFMojZFKSuD9lUD8s TsrwyDeDC5tuRiLuIUH3CjrVYpkyH7ytqD6EnefisDfsVDoa6xNUGa6ZrfAwBeh0RQqM vZrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z/RQj5FqYPBFFb/BHpJq3oq0/JIX3F5mcr3Ic1KDLoA=; b=bsfUuMHs1xjYh153MvyaL049R9p39nHsA954ctnVQLHHOdgJoXA6f+wFHxo+oDOepx e/Gg5fNHTTiKuvNnuFKaN0APDXotGBFhXj6q+2GgJkaVYkkdmPtPNquJm8+6DadQJJKm RrnqT15kAvmc66G1rsTIJXlQDGPewnmI15+juJ4IeO8a6Mr5D5IO15RaaL0p1VxkkCKV PxLRjQir+q1VAXujXctHPdx/DvHAtM25B1YRMPuf7u2VepPQj2nrANqEokDhFpqVsEw/ 1+KtY8UsAhERBkO6Izbsoy2gthTrseYxxZjiMRyf1TiYUv86U0iXUrpvV8iLQ7sN6urx uhHg== X-Gm-Message-State: APjAAAWQ7S4LD2lk6HDlD2xUCNKuVito7ns9blQ+FemHuXi31hkRJajT pHXIjhJi9cXVzZ213nMeukW1SbjlPluBXkCFmT5+VA== X-Google-Smtp-Source: APXvYqy9ZihhNwSz15zAc2n9wuqx0KKCFEmVQyQmPiar9gQiv4PEvu699gEh+PcCmRyXpyUO7fCyzGA8P+JoII/zuY4= X-Received: by 2002:a67:e951:: with SMTP id p17mr5243152vso.112.1573842878866; Fri, 15 Nov 2019 10:34:38 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191105235608.107702-1-samitolvanen@google.com> <20191105235608.107702-6-samitolvanen@google.com> <20191115153705.GJ41572@lakrids.cambridge.arm.com> In-Reply-To: <20191115153705.GJ41572@lakrids.cambridge.arm.com> From: Sami Tolvanen Date: Fri, 15 Nov 2019 10:34:25 -0800 Message-ID: Subject: Re: [PATCH v5 05/14] add support for Clang's Shadow Call Stack (SCS) To: Mark Rutland Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" On Fri, Nov 15, 2019 at 7:37 AM Mark Rutland wrote: > > +config SHADOW_CALL_STACK_VMAP > > + bool > > + depends on SHADOW_CALL_STACK > > + help > > + Use virtually mapped shadow call stacks. Selecting this option > > + provides better stack exhaustion protection, but increases per-thread > > + memory consumption as a full page is allocated for each shadow stack. > > The bool needs some display text to make it selectable. > > This should probably be below SHADOW_CALL_STACK so that when it shows up > in menuconfig it's where you'd expect it to be. > > I locally hacked that in, but when building defconfig + > SHADOW_CALL_STACK + SHADOW_CALL_STACK_VMAP, the build explodes as below: Ugh, thanks for pointing this out. I'll fix this in v6. Sami