From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BDC2CA9EA0 for ; Fri, 18 Oct 2019 17:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E06F421835 for ; Fri, 18 Oct 2019 17:11:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NFaKn8K/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2634479AbfJRRL2 (ORCPT ); Fri, 18 Oct 2019 13:11:28 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:37498 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388005AbfJRRL2 (ORCPT ); Fri, 18 Oct 2019 13:11:28 -0400 Received: by mail-vs1-f67.google.com with SMTP id p13so4517290vsr.4 for ; Fri, 18 Oct 2019 10:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XATsmiiQ65kT4ODqJ8G67gOZ75F3gzeYi1y9XLQaIlM=; b=NFaKn8K/6s2O1InStTL9sLz1AskGb0puzLhWcn2tdgY8ZmCLY7XOJRYveX8vbFZU0f AivKBQvkf/pODzLL5A4lcri/koO4kVh6iykeyqn4iKMkTaY1LVSs0gwEl9DJOigy8q8Q WPtHpYV0+uIe6amcTjkQLuADzSGPUx4rs/QmPrhO0WC+aS/VPjA8tDxGnOE6xkLGpQLv lTimTCE/K9U0RF4C039OIDi0j2iIowkJYeW6TPrBZBYFSBCJ9uXp+uP1gTWL63kz/VIn F7pEhz3ucREkKYmQDI91cCQ4B4+VGr1SMl0Byq8KA2sUVL6ZDahv6K/J2fUilePUK8ER 3UWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XATsmiiQ65kT4ODqJ8G67gOZ75F3gzeYi1y9XLQaIlM=; b=aBvhGhxhayJKoDW5nVybNwjFCyrrYc6NlX8VK+9k7jXEqETGC2fLnRZ1UWWpTIicXf 8RuK2Q8sWeAiKkeLPtre13Onrv+lvG2aHXSaXflK4oCn+hko69NYYvZB3Le5klBf44dC 6Ts8XzhgUS7+S6PYphK0f+2OpGTEMNYF1SKxx/xabzic/hRW0Ki3HMrFA+kVDQK6zXAP pG00JBl/nfnylgqeQiLq4iy7gpKiWYuDZiO/K1Z94isFAvS0BV0jlsPTxcOb2JpNo5bF farkBAGvAhrkWKpY/DSnu/Qwhvo2YJsIdT+1Fbq6Ne7HtSYz3phPruHCGdCsZKjVJIhI WcHw== X-Gm-Message-State: APjAAAUoZWMoxuOJTv56Wgo90c6J3IKfmJPihlQOODzJzpg6DrC+Gger y8ZRoDMNOvOiJwUJP9HrwR/CQj0d2y37ivMWGuwg7Q== X-Google-Smtp-Source: APXvYqxbFqx52fMmsudugE6XC0yz5SmZysXaFv9YWU7egAQ4sBR35UABj4n5x4ayDTqcJ+9yTIIHMtatlqnJPxGnKEw= X-Received: by 2002:a67:ed8b:: with SMTP id d11mr6025118vsp.104.1571418687239; Fri, 18 Oct 2019 10:11:27 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-7-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Fri, 18 Oct 2019 10:11:16 -0700 Message-ID: Subject: Re: [PATCH 06/18] add support for Clang's Shadow Call Stack (SCS) To: Nick Desaulniers Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , clang-built-linux , Kernel Hardening , Linux ARM , LKML , Miguel Ojeda Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 18, 2019 at 10:08 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > > index 333a6695a918..9af08391f205 100644 > > --- a/include/linux/compiler-clang.h > > +++ b/include/linux/compiler-clang.h > > @@ -42,3 +42,5 @@ > > * compilers, like ICC. > > */ > > #define barrier() __asm__ __volatile__("" : : : "memory") > > + > > +#define __noscs __attribute__((no_sanitize("shadow-call-stack"))) > > It looks like this attribute, (and thus a requirement to use this > feature), didn't exist until Clang 7.0: https://godbolt.org/z/p9u1we > (as noted above) > > I think it's better to put __noscs behind a __has_attribute guard in > include/linux/compiler_attributes.h. Otherwise, what will happen when > Clang 6.0 sees __noscs, for example? (-Wunknown-sanitizers will > happen). Good point, I'll fix this in v2. Thanks. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53D65CA9EA0 for ; Fri, 18 Oct 2019 17:11:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2759621835 for ; Fri, 18 Oct 2019 17:11:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VJNURTZ1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="NFaKn8K/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2759621835 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lI2xr0xdx57UO31GhjGIxeNN8Qb005swDGATEU5xWhE=; b=VJNURTZ1a6RDSP vP1RZwYwX7bspiiHOMp3afBH9RNM8Y36Zz76Z1pzKV5rVmi3qgWkNMwXheo9rwJa3VVmxCKCnsh8f /SSJVCagKMFf4GIfGGpsFlCy4ihII5FYElZ3zJeYjpJzCpxqobYlb3I7o7K4xf+edTzDQ/BnWqFdH zAkEyRz5hzZbzG04igF6lee+JiEI2nDz3BQX36i5iLxkTknMoMuVbUt6/xRLE75hmb21VVai2zmOJ 0cy+3zwh6mFeZbNI5RAlaairbJjjks67oJ8bdMfZPY/v1RybCzn0mBz34MSpRmggLZXV+pVaFtB95 JphI7ipyiKSAp5pDj68w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLVmn-0004vN-Vd; Fri, 18 Oct 2019 17:11:33 +0000 Received: from mail-vs1-xe43.google.com ([2607:f8b0:4864:20::e43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLVmk-0004u5-NW for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2019 17:11:32 +0000 Received: by mail-vs1-xe43.google.com with SMTP id z14so4482834vsz.13 for ; Fri, 18 Oct 2019 10:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XATsmiiQ65kT4ODqJ8G67gOZ75F3gzeYi1y9XLQaIlM=; b=NFaKn8K/6s2O1InStTL9sLz1AskGb0puzLhWcn2tdgY8ZmCLY7XOJRYveX8vbFZU0f AivKBQvkf/pODzLL5A4lcri/koO4kVh6iykeyqn4iKMkTaY1LVSs0gwEl9DJOigy8q8Q WPtHpYV0+uIe6amcTjkQLuADzSGPUx4rs/QmPrhO0WC+aS/VPjA8tDxGnOE6xkLGpQLv lTimTCE/K9U0RF4C039OIDi0j2iIowkJYeW6TPrBZBYFSBCJ9uXp+uP1gTWL63kz/VIn F7pEhz3ucREkKYmQDI91cCQ4B4+VGr1SMl0Byq8KA2sUVL6ZDahv6K/J2fUilePUK8ER 3UWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XATsmiiQ65kT4ODqJ8G67gOZ75F3gzeYi1y9XLQaIlM=; b=Z8t5G/W9UIrK7/xaPLEkCNNk55gxg1L+PpuOyJ1QRRKHeMFRanXL8+PjqVJEiqAQ+x CWt4NKRnIB4CYTCWv6IVMssPFjWpfb3kB4HsKN0ncXBrBvoYQTHzSpSHBvILb2Kh3chX GPb+eF1QYXmGr68JKdZTv1At6UxVstM5cyehAKDzJcgv7mlFwxC6aLyUDKbfJCFUaYUf 676j2ulZkg7fUcIQjTDXhmr0gAStLQqj8gk5y1mnZrEPtVE3nL65pVqm8ErlH6ICOUnZ 0WJMOClCi9Mq+3VhNREPBF9Qv+lFUMLtznZMX8c7w2SNpbr86nCzMWyEkUE28U2dyS1r RCQA== X-Gm-Message-State: APjAAAW4Fl+c2rKBD6MAj6Nn6JjBi8/xfkSrLjRjyJaI6ZIzUDcSoNB8 TFOsaySW6V9XEqGAOrHMQcZZpWI67b4cCrmTMSE1mA== X-Google-Smtp-Source: APXvYqxbFqx52fMmsudugE6XC0yz5SmZysXaFv9YWU7egAQ4sBR35UABj4n5x4ayDTqcJ+9yTIIHMtatlqnJPxGnKEw= X-Received: by 2002:a67:ed8b:: with SMTP id d11mr6025118vsp.104.1571418687239; Fri, 18 Oct 2019 10:11:27 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-7-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Fri, 18 Oct 2019 10:11:16 -0700 Message-ID: Subject: Re: [PATCH 06/18] add support for Clang's Shadow Call Stack (SCS) To: Nick Desaulniers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191018_101130_793739_A76271C7 X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Catalin Marinas , Kernel Hardening , LKML , Steven Rostedt , clang-built-linux , Miguel Ojeda , Laura Abbott , Will Deacon , Dave Martin , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 18, 2019 at 10:08 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > > index 333a6695a918..9af08391f205 100644 > > --- a/include/linux/compiler-clang.h > > +++ b/include/linux/compiler-clang.h > > @@ -42,3 +42,5 @@ > > * compilers, like ICC. > > */ > > #define barrier() __asm__ __volatile__("" : : : "memory") > > + > > +#define __noscs __attribute__((no_sanitize("shadow-call-stack"))) > > It looks like this attribute, (and thus a requirement to use this > feature), didn't exist until Clang 7.0: https://godbolt.org/z/p9u1we > (as noted above) > > I think it's better to put __noscs behind a __has_attribute guard in > include/linux/compiler_attributes.h. Otherwise, what will happen when > Clang 6.0 sees __noscs, for example? (-Wunknown-sanitizers will > happen). Good point, I'll fix this in v2. Thanks. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 706E7CA9EA9 for ; Fri, 18 Oct 2019 17:55:01 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id B8D0921835 for ; Fri, 18 Oct 2019 17:55:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NFaKn8K/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8D0921835 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17052-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 13416 invoked by uid 550); 18 Oct 2019 17:54:37 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 23949 invoked from network); 18 Oct 2019 17:11:39 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XATsmiiQ65kT4ODqJ8G67gOZ75F3gzeYi1y9XLQaIlM=; b=NFaKn8K/6s2O1InStTL9sLz1AskGb0puzLhWcn2tdgY8ZmCLY7XOJRYveX8vbFZU0f AivKBQvkf/pODzLL5A4lcri/koO4kVh6iykeyqn4iKMkTaY1LVSs0gwEl9DJOigy8q8Q WPtHpYV0+uIe6amcTjkQLuADzSGPUx4rs/QmPrhO0WC+aS/VPjA8tDxGnOE6xkLGpQLv lTimTCE/K9U0RF4C039OIDi0j2iIowkJYeW6TPrBZBYFSBCJ9uXp+uP1gTWL63kz/VIn F7pEhz3ucREkKYmQDI91cCQ4B4+VGr1SMl0Byq8KA2sUVL6ZDahv6K/J2fUilePUK8ER 3UWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XATsmiiQ65kT4ODqJ8G67gOZ75F3gzeYi1y9XLQaIlM=; b=p+QIgNfrrsiM28r2O3rVCGKmbE8jwV4LZVi5C91PeN6U7DrVCp6FSeNSeUkQyRIGUW la3osIvfA49lSC/hCk/T+IlOqcVBJhuqqfdLwqORivk9FU7cOTW9P4FoZI2mftrxqlqG d7Rq2FKbBupisaozp3cMd3lUInOvpXyxukReTWHyaQIK9JIDH4xmb64UmdJnhAMJWccx kdMSL6XEzujQ9SOa+lClOzVl/ZpN23RXQWNWgjKFlwR4XGYmy0PaOIzjmRqRZh4vdPfO eA7YNSk3ZF5a1yv/ZuaFAtjCXOfU8Icod2X9Xx4LFhoKfMjRm9lmehW/bjK5a3ueYq2V rVCg== X-Gm-Message-State: APjAAAW9NFyn8lghHI59dM5TaYuNSOF/pBnyYKhGX7T8Dn23q5yQ/P13 qVl3IZRw/zuni/18JzD3bdvP5sDnnC9bc3BuV9Rpcw== X-Google-Smtp-Source: APXvYqxbFqx52fMmsudugE6XC0yz5SmZysXaFv9YWU7egAQ4sBR35UABj4n5x4ayDTqcJ+9yTIIHMtatlqnJPxGnKEw= X-Received: by 2002:a67:ed8b:: with SMTP id d11mr6025118vsp.104.1571418687239; Fri, 18 Oct 2019 10:11:27 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-7-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Fri, 18 Oct 2019 10:11:16 -0700 Message-ID: Subject: Re: [PATCH 06/18] add support for Clang's Shadow Call Stack (SCS) To: Nick Desaulniers Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , clang-built-linux , Kernel Hardening , Linux ARM , LKML , Miguel Ojeda Content-Type: text/plain; charset="UTF-8" On Fri, Oct 18, 2019 at 10:08 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > > index 333a6695a918..9af08391f205 100644 > > --- a/include/linux/compiler-clang.h > > +++ b/include/linux/compiler-clang.h > > @@ -42,3 +42,5 @@ > > * compilers, like ICC. > > */ > > #define barrier() __asm__ __volatile__("" : : : "memory") > > + > > +#define __noscs __attribute__((no_sanitize("shadow-call-stack"))) > > It looks like this attribute, (and thus a requirement to use this > feature), didn't exist until Clang 7.0: https://godbolt.org/z/p9u1we > (as noted above) > > I think it's better to put __noscs behind a __has_attribute guard in > include/linux/compiler_attributes.h. Otherwise, what will happen when > Clang 6.0 sees __noscs, for example? (-Wunknown-sanitizers will > happen). Good point, I'll fix this in v2. Thanks. Sami