From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D60A3200 for ; Mon, 4 Apr 2022 19:41:23 +0000 (UTC) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-2e68c95e0f9so112975057b3.0 for ; Mon, 04 Apr 2022 12:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eAwv7CFZ3JOlEcNj8j8D2/v921PTmZNLQHl33SWwbZQ=; b=pMdBBCRgdJWrkxOB7Vi/srVNde9bJufkX4hVHEeS+pFF8yy6ccmz7kB+1UwHKEIDFa JDg37ysNC2VzPqSfgLQnu7iYkS3/sbzzt9U66P4qidAB+SU4mTF1PntYeWGtGxMrXI94 c7VlnLx3YhtB0XEymV2HzG/wPESttE7jFSEYKhmWuLId0C4CdBpHGprn+S1rZ+skseYr R5O2AESDpF9Nha3NUhigFuCto1zYZ+Q5FUlSL9jPB/joOa9jbDMtEx1Y2YhBi+lkRwGp DyTmqM/Fr5UV5yGB2tMELqq9tO6uUup/Raugo78JKi2NLR+3NMDswAsxgK2+Xfgbv0HL ywZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eAwv7CFZ3JOlEcNj8j8D2/v921PTmZNLQHl33SWwbZQ=; b=G4tfX6ullXPEWK/LVH3wBuUKyOM88t2B4YGSvvOvMVmdOM5x2nfgwE+5rbGTGmc4mZ wDgKyfdA8yJNgyd3sUcDnjwVOE0XFzhuFdqY7dCTfJnK1zdifmDW/JaY82bZHwz1KNQy 1CPfr4Idn00FO8SgU8hgY8SaqxgJBEENX0ljeCFZNZHYQXECmTCXHXiWc7XxgU1lhS26 JGlbpWwNUdvDpwkXCuNE/Syrs/Sq6s7CAMb657ZH85mfqV2t7Yv09+VcnqXnSu2SdGnr dnSadM7IrIqEbI0xyH2F5zNqcJGDxrIZbIuoqhvcQxklfJoQY49vLUQv7xtEZVMi0LP3 VK9w== X-Gm-Message-State: AOAM532lGJGjdlsVxDtScfyOveEt23ZPVjV2mYTP4N1g1smJAq1pOito qQonqmzEr4WCFG3C0e+iCgtCTD4oJ0IGMMjteRf9fA== X-Google-Smtp-Source: ABdhPJx7D6TDafv3kiS/i/Qp7m7WK4qbRCfugunFo5wbxlDRV34SM1qNDg9LlBTyO66YQQqmXk6cb/7CTestETLhn4E= X-Received: by 2002:a81:3a4a:0:b0:2e5:a9e9:f43c with SMTP id h71-20020a813a4a000000b002e5a9e9f43cmr1490010ywa.243.1649101281897; Mon, 04 Apr 2022 12:41:21 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220401201916.1487500-1-samitolvanen@google.com> <20220401201916.1487500-2-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Mon, 4 Apr 2022 12:40:46 -0700 Message-ID: Subject: Re: [PATCH 1/3] kbuild: Change CFI_CLANG to depend on __builtin_function_start To: Masahiro Yamada Cc: Kees Cook , Catalin Marinas , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Will Deacon , linux-arm-kernel , Linux Kernel Mailing List , llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Sat, Apr 2, 2022 at 6:32 AM Masahiro Yamada wrote: > > On Sat, Apr 2, 2022 at 5:19 AM Sami Tolvanen wrote: > > > > Clang 14 added support for the __builtin_function_start() > > built-in function, which allows us to implement function_nocfi() > > without architecture-specific inline assembly. This patch changes > > CONFIG_CFI_CLANG to depend on the built-in and effectively upgrades > > the minimum supported compiler version for CFI to Clang 14. > > From this description, I think the straight-forward change would be: > > depends on CLANG_VERSION >= 120000 > --> > depends on CLANG_VERSION >= 140000 > > Any reason to avoid this? I thought testing for the compiler feature was preferred, but I can certainly just increase the minimum version number here too. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85F92C433EF for ; Mon, 4 Apr 2022 19:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9yO37OGVeFxDNxRbDP111sS28u3ATwQ8NMY0HhNeAjI=; b=MdYnypdpD2FZRL 51Ewqr6qOSHGQDhmGpSUNYXpTwwYpox4gXcgfWPFpGWNnk0uQQQ7Ytse25cLG5QwhWd7n4BqemYvb rToANHvnp1eGc8tBeL3NVI7M8LVQ62739xryQF1vVlkvbLeABoakmUB1iPfcjwcXSMOrzWYqJjbW4 XJiRbGuNf8cPRHo5WOR6y88N9Om+G0f/kAnppJzjIx3AhPk4PRS+T9TgwwV+lG6eNwI1n6lUZuZ/4 tLkXr4tFrLJnlmYRKJcs7nWdn2vSjA8a4eylx1WUYHkesEuQ6ngqYobgztg4CZMq84MzK58att6Uq uODApClGV5jkM+MOF3CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbSZt-00GITC-JR; Mon, 04 Apr 2022 19:41:29 +0000 Received: from mail-yw1-x112a.google.com ([2607:f8b0:4864:20::112a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbSZq-00GISR-Pa for linux-arm-kernel@lists.infradead.org; Mon, 04 Apr 2022 19:41:28 +0000 Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-2eb46d33db9so59045077b3.12 for ; Mon, 04 Apr 2022 12:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eAwv7CFZ3JOlEcNj8j8D2/v921PTmZNLQHl33SWwbZQ=; b=pMdBBCRgdJWrkxOB7Vi/srVNde9bJufkX4hVHEeS+pFF8yy6ccmz7kB+1UwHKEIDFa JDg37ysNC2VzPqSfgLQnu7iYkS3/sbzzt9U66P4qidAB+SU4mTF1PntYeWGtGxMrXI94 c7VlnLx3YhtB0XEymV2HzG/wPESttE7jFSEYKhmWuLId0C4CdBpHGprn+S1rZ+skseYr R5O2AESDpF9Nha3NUhigFuCto1zYZ+Q5FUlSL9jPB/joOa9jbDMtEx1Y2YhBi+lkRwGp DyTmqM/Fr5UV5yGB2tMELqq9tO6uUup/Raugo78JKi2NLR+3NMDswAsxgK2+Xfgbv0HL ywZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eAwv7CFZ3JOlEcNj8j8D2/v921PTmZNLQHl33SWwbZQ=; b=59qSszG+Ua6TMSOEVNRAQ4Iai0nySDvARGNgvCq0S3GnXRbbngDvctO2o3fOLXdbD5 1gWhF4AvjZJj2C7wssnpDf0sVPyo3TwSbzApdIPcKOerT+D2h98QEt/OIbzwjEQ5uZgv P3lRpklI+MFJ+WdvMW8lvbtnM1+p/U93dzoXuY6KjlJzwZQtWN2VKfM2R4CWK6bMb21l IJ3x+HICkGYkIFpFSm5DovIP3HuNq+xzaGbXBNRQNUY5DAryv7V7gN64t4G6rYOHl3vy DFy5JA9b8cD8+CBt7DbL1Ck4FJrL2eQSROWN8OMBrBpS2Kv37jU34hM8gR5eGkiy9PyU T6mw== X-Gm-Message-State: AOAM530hIQAWVHC3BUjsPOT5koTpyZnTB8QPxafjJ+f09cFzNtv6uqmD RW9E/OOFVgnl6vEfOXjMd4o4kwXddZGrm3/06U46+g== X-Google-Smtp-Source: ABdhPJx7D6TDafv3kiS/i/Qp7m7WK4qbRCfugunFo5wbxlDRV34SM1qNDg9LlBTyO66YQQqmXk6cb/7CTestETLhn4E= X-Received: by 2002:a81:3a4a:0:b0:2e5:a9e9:f43c with SMTP id h71-20020a813a4a000000b002e5a9e9f43cmr1490010ywa.243.1649101281897; Mon, 04 Apr 2022 12:41:21 -0700 (PDT) MIME-Version: 1.0 References: <20220401201916.1487500-1-samitolvanen@google.com> <20220401201916.1487500-2-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Mon, 4 Apr 2022 12:40:46 -0700 Message-ID: Subject: Re: [PATCH 1/3] kbuild: Change CFI_CLANG to depend on __builtin_function_start To: Masahiro Yamada Cc: Kees Cook , Catalin Marinas , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Will Deacon , linux-arm-kernel , Linux Kernel Mailing List , llvm@lists.linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220404_124126_888121_0A62A5C0 X-CRM114-Status: GOOD ( 15.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 2, 2022 at 6:32 AM Masahiro Yamada wrote: > > On Sat, Apr 2, 2022 at 5:19 AM Sami Tolvanen wrote: > > > > Clang 14 added support for the __builtin_function_start() > > built-in function, which allows us to implement function_nocfi() > > without architecture-specific inline assembly. This patch changes > > CONFIG_CFI_CLANG to depend on the built-in and effectively upgrades > > the minimum supported compiler version for CFI to Clang 14. > > From this description, I think the straight-forward change would be: > > depends on CLANG_VERSION >= 120000 > --> > depends on CLANG_VERSION >= 140000 > > Any reason to avoid this? I thought testing for the compiler feature was preferred, but I can certainly just increase the minimum version number here too. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel