From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1717FC433EF for ; Mon, 9 May 2022 23:13:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229673AbiEIXRp (ORCPT ); Mon, 9 May 2022 19:17:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232287AbiEIXRn (ORCPT ); Mon, 9 May 2022 19:17:43 -0400 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92FB22A3BE7 for ; Mon, 9 May 2022 16:13:48 -0700 (PDT) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-2f7c57ee6feso161812777b3.2 for ; Mon, 09 May 2022 16:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oazinpgomaqUG0jSYMm8ubizFPTzpD9YluLXTH1Uf+8=; b=f6fWCk6p41OZaY/aYptJIOS/H7gQoR2LQU/vFrk5Gn4NSNwuGdiZDiDStk7AbG3yZD IKBXb4w884/50UAgGFMYKZ1TW7UWPSrJsR6aU/0xVkQloWI1gv9dqJSDbnU+7ZRlaq+H 5q6FzLE9Jch5W51SjYRwMzmvNSaAVh59pmK1la7G6Ce7QS8+phGNXM1poUTxBJEghkkL rkNzGIHiR6cg7h2j0E68I08LETn6PDCH3Bk2j2CtnK3mFxMH+qkZYlQ5Mbk0pgP96vbx k86u84TYrd/iZlrt9edUpHqGeZQt6sH9DbxxljCpeCMl8DqbX8Q9LTMC9vVENf9lnOH2 8xnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oazinpgomaqUG0jSYMm8ubizFPTzpD9YluLXTH1Uf+8=; b=6rwuvVwp9v+TSPjqOGvXfvAe3DAbfaUzJ4MyTTKUALN57V5awBDTQuc+I/L8bIImpo hop/FhzAn2pNjS30dF0w2L8LPxKSpysettGHX+C1Cuv0vd1sU8xefZfiuw6tHZ+6XH5j IoqFIHc/HLO0bhOCgCz65hakHYr/V2QuyR6KM5iRks7EImFHx3Ecuyk/vOGWuPzqS6BX mLZX6O9xRv48Wy2T2sSTcTfUl9vw+pNI8uLTNHpPZXCJi65eiyUbn41DgTfk01iTE75f 4frfKtkEWMp/n8tWdTsCruav2oKyVHMNnEkTJJDbBRrsvHAoATUEx+ujT9SYeiYCv2op Q0rg== X-Gm-Message-State: AOAM532Rd4H/gmcuXfSQWj2QRXSoOFbBIV8dJ1ydT5QyOc1yB1n6XB9Y wKse5iAeT766mIZjmjoR+oxZk5XQ4ugi9Zsc7wwCeg== X-Google-Smtp-Source: ABdhPJxssHqsbnbsTj81I2dSgjtFlZace94GadSqyvpd5jqz1pk64Y4lHyhr+1TXl7QDxSK2F5OuNrrpLo+K4Kc2AN8= X-Received: by 2002:a81:1108:0:b0:2f7:bf11:3fb9 with SMTP id 8-20020a811108000000b002f7bf113fb9mr17011668ywr.305.1652138027673; Mon, 09 May 2022 16:13:47 -0700 (PDT) MIME-Version: 1.0 References: <20220508190631.2386038-1-masahiroy@kernel.org> <20220508190631.2386038-10-masahiroy@kernel.org> In-Reply-To: <20220508190631.2386038-10-masahiroy@kernel.org> From: Sami Tolvanen Date: Mon, 9 May 2022 16:13:11 -0700 Message-ID: Subject: Re: [PATCH v4 09/14] kbuild: do not create *.prelink.o for Clang LTO or IBT To: Masahiro Yamada Cc: linux-kbuild , LKML , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Peter Zijlstra , linux-modules@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev , clang-built-linux , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: On Sun, May 8, 2022 at 12:10 PM Masahiro Yamada wrote: > > When CONFIG_LTO_CLANG=y, additional intermediate *.prelink.o is created > for each module. Also, objtool is postponed until LLVM bitcode is > converted to ELF. > > CONFIG_X86_KERNEL_IBT works in a similar way to postpone objtool until > objects are merged together. > > This commit stops generating *.prelink.o, so the build flow will look > the same with/without LTO. > > The following figures show how the LTO build currently works, and > how this commit is changing it. > > Current build flow > ================== > > [1] single-object module > > $(LD) > $(CC) +objtool $(LD) > foo.c --------------------> foo.o -----> foo.prelink.o -----> foo.ko > (LLVM bitcode) (ELF) | > | > foo.mod.o --/ > > [2] multi-object module > $(LD) > $(CC) $(AR) +objtool $(LD) > foo1.c -----> foo1.o -----> foo.o -----> foo.prelink.o -----> foo.ko > | (archive) (ELF) | > foo2.c -----> foo2.o --/ | > (LLVM bitcode) foo.mod.o --/ > > One confusion is foo.o in multi-object module is an archive despite of > its suffix. > > New build flow > ============== > > [1] single-object module > > Since there is only one object, we do not need to have the LLVM > bitcode stage. Use $(CC)+$(LD) to generate an ELF object in one > build rule. When LTO is disabled, $(LD) is unneeded because $(CC) > produces an ELF object. > > $(CC)+$(LD)+objtool $(LD) > foo.c ------------------------> foo.o -------> foo.ko > (ELF) | > | > foo.mod.o --/ > > [2] multi-object module > > Previously, $(AR) was used to combine LLVM bitcode into an archive, > but there was no technical reason to do so. > This commit just uses $(LD) to combine and convert them into a single > ELF object. > > $(LD) > $(CC) +objtool $(LD) > foo1.c -------> foo1.o -------> foo.o -------> foo.ko > | (ELF) | > foo2.c -------> foo2.o ---/ | > (LLVM bitcode) foo.mod.o --/ > > Signed-off-by: Masahiro Yamada > Reviewed-by: Nicolas Schier > Tested-by: Nathan Chancellor Looks good, thanks for cleaning this up! Reviewed-by: Sami Tolvanen Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1057EC433EF for ; Mon, 9 May 2022 23:14:30 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Kxxnw4PTXz3c5C for ; Tue, 10 May 2022 09:14:28 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=f6fWCk6p; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::1136; helo=mail-yw1-x1136.google.com; envelope-from=samitolvanen@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=f6fWCk6p; dkim-atps=neutral Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KxxnD2qBxz3bqy for ; Tue, 10 May 2022 09:13:51 +1000 (AEST) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-2f7d621d1caso161486907b3.11 for ; Mon, 09 May 2022 16:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oazinpgomaqUG0jSYMm8ubizFPTzpD9YluLXTH1Uf+8=; b=f6fWCk6p41OZaY/aYptJIOS/H7gQoR2LQU/vFrk5Gn4NSNwuGdiZDiDStk7AbG3yZD IKBXb4w884/50UAgGFMYKZ1TW7UWPSrJsR6aU/0xVkQloWI1gv9dqJSDbnU+7ZRlaq+H 5q6FzLE9Jch5W51SjYRwMzmvNSaAVh59pmK1la7G6Ce7QS8+phGNXM1poUTxBJEghkkL rkNzGIHiR6cg7h2j0E68I08LETn6PDCH3Bk2j2CtnK3mFxMH+qkZYlQ5Mbk0pgP96vbx k86u84TYrd/iZlrt9edUpHqGeZQt6sH9DbxxljCpeCMl8DqbX8Q9LTMC9vVENf9lnOH2 8xnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oazinpgomaqUG0jSYMm8ubizFPTzpD9YluLXTH1Uf+8=; b=e9HhgnaxzTISPaSMXLrhJ0ylVgTPhkG+DWW+5Kkni6VM3b6Ut/Ss4tLfPXU2Bj1ob5 p3gTZFsIeKMzSL6xbgZ4WuLI9HivJavj9WpWr+J2M4x/S06QuY5MryTrTjwek5sBJJ3H 1RQEwPw2o//i37dQlyb35VEW5ZhpJ8WT7XpYa0RkhqyHyLn+hdbraGs4BTB6+SUXrYZD HJePKIrjinIyrkgKGjlDiKPZh37zzJWga0U3p+YYmfip8qgZfFod0qobpZLiye78GCFP nA3xW6Ra6JXNxMjw1q/dUL+VE7qX8juNwlBCyoAnAC68tRiOhW8OtFDTROItG3+sM798 b6Lg== X-Gm-Message-State: AOAM530h6lWmE/PHZp0lzFipd0SMx2GwGe9TGptCvtrCxhGmPSL33M0q ZfIruISLfA2BM8avXIlonO2HbcoO8Lq8GeoHwZ+KTQ== X-Google-Smtp-Source: ABdhPJxssHqsbnbsTj81I2dSgjtFlZace94GadSqyvpd5jqz1pk64Y4lHyhr+1TXl7QDxSK2F5OuNrrpLo+K4Kc2AN8= X-Received: by 2002:a81:1108:0:b0:2f7:bf11:3fb9 with SMTP id 8-20020a811108000000b002f7bf113fb9mr17011668ywr.305.1652138027673; Mon, 09 May 2022 16:13:47 -0700 (PDT) MIME-Version: 1.0 References: <20220508190631.2386038-1-masahiroy@kernel.org> <20220508190631.2386038-10-masahiroy@kernel.org> In-Reply-To: <20220508190631.2386038-10-masahiroy@kernel.org> From: Sami Tolvanen Date: Mon, 9 May 2022 16:13:11 -0700 Message-ID: Subject: Re: [PATCH v4 09/14] kbuild: do not create *.prelink.o for Clang LTO or IBT To: Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, Nicolas Schier , linux-kbuild , Peter Zijlstra , Nick Desaulniers , LKML , Nathan Chancellor , clang-built-linux , linuxppc-dev , Ard Biesheuvel , linux-modules@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, May 8, 2022 at 12:10 PM Masahiro Yamada wrote: > > When CONFIG_LTO_CLANG=y, additional intermediate *.prelink.o is created > for each module. Also, objtool is postponed until LLVM bitcode is > converted to ELF. > > CONFIG_X86_KERNEL_IBT works in a similar way to postpone objtool until > objects are merged together. > > This commit stops generating *.prelink.o, so the build flow will look > the same with/without LTO. > > The following figures show how the LTO build currently works, and > how this commit is changing it. > > Current build flow > ================== > > [1] single-object module > > $(LD) > $(CC) +objtool $(LD) > foo.c --------------------> foo.o -----> foo.prelink.o -----> foo.ko > (LLVM bitcode) (ELF) | > | > foo.mod.o --/ > > [2] multi-object module > $(LD) > $(CC) $(AR) +objtool $(LD) > foo1.c -----> foo1.o -----> foo.o -----> foo.prelink.o -----> foo.ko > | (archive) (ELF) | > foo2.c -----> foo2.o --/ | > (LLVM bitcode) foo.mod.o --/ > > One confusion is foo.o in multi-object module is an archive despite of > its suffix. > > New build flow > ============== > > [1] single-object module > > Since there is only one object, we do not need to have the LLVM > bitcode stage. Use $(CC)+$(LD) to generate an ELF object in one > build rule. When LTO is disabled, $(LD) is unneeded because $(CC) > produces an ELF object. > > $(CC)+$(LD)+objtool $(LD) > foo.c ------------------------> foo.o -------> foo.ko > (ELF) | > | > foo.mod.o --/ > > [2] multi-object module > > Previously, $(AR) was used to combine LLVM bitcode into an archive, > but there was no technical reason to do so. > This commit just uses $(LD) to combine and convert them into a single > ELF object. > > $(LD) > $(CC) +objtool $(LD) > foo1.c -------> foo1.o -------> foo.o -------> foo.ko > | (ELF) | > foo2.c -------> foo2.o ---/ | > (LLVM bitcode) foo.mod.o --/ > > Signed-off-by: Masahiro Yamada > Reviewed-by: Nicolas Schier > Tested-by: Nathan Chancellor Looks good, thanks for cleaning this up! Reviewed-by: Sami Tolvanen Sami