From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E34C63697 for ; Mon, 23 Nov 2020 18:35:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4CA22078E for ; Mon, 23 Nov 2020 18:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="a28npanX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730172AbgKWSe3 (ORCPT ); Mon, 23 Nov 2020 13:34:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729778AbgKWSe2 (ORCPT ); Mon, 23 Nov 2020 13:34:28 -0500 Received: from mail-vk1-xa43.google.com (mail-vk1-xa43.google.com [IPv6:2607:f8b0:4864:20::a43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36777C061A4E for ; Mon, 23 Nov 2020 10:34:28 -0800 (PST) Received: by mail-vk1-xa43.google.com with SMTP id i62so4166431vkb.7 for ; Mon, 23 Nov 2020 10:34:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ducm/uE+sMkPK2UOgkqYMUQ4ilvqi+LJ419ruam/qFs=; b=a28npanXu2b+2Zm6spF8Xxq67i0FF1mofgAXLZrp9sWLlq5VqELCHg7nNtL/fggxfy 4CvQOkS95wisZC5OOhHXgHc7fhFAJxswBiURdiMJ9pvomlaHamPT+ykt9lAJiikZ+dLt osQObvLhHeCEfH726pPrnktuPN+mM05X3eQTo9OM7P951PbVbYXAJtMdKWsW3ZpOJycz Fo60Q7UeI0dsFGaQdho0oc4TBDEtFVDe4gG5sgoLUuJHQYabpl1Mv31/0zpxLkiYJIlP yNiDIkVOpAML5h30am2pinK5OAxNIvR/ui0KubaSslDdw6PBBAOOjQrByts6Koo1ViWx IqJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ducm/uE+sMkPK2UOgkqYMUQ4ilvqi+LJ419ruam/qFs=; b=Sy3GOUncZKwcahHRIuogz9QLOrBpa4IX5D7SRVfy4gb8biaPdk0WnLcXpEiLzy+NRu ub8n6Rde4+YH/dqbqkNVKHAkb5ta03i5mosRkDenGw6tbeOkFjrD2CjtW5Wya+uW0gHI KfDd9qQb01fo5yi3V7c5dx+3q34FFxMYMh4/69/y68nam/8ORsLJ/mZl0V5V+ZGIgUN4 3EvuJ4jUUCQQO+yv98eGTSje3WbsXsRajOsmcrxO4bVmssoVPnl/HXqdNzjdAw1R3EWG Zb+7WFrk6XDqeUONTsCxTYyXIJYqy3iz4eCJIrqwqbqLFKovbJ7SSXyIw1+8t2UnAce/ 0LaA== X-Gm-Message-State: AOAM53194hRZuTP+e5p4KWN68gzn52jJFQciU67sPwtj2JP9BluX9Usq J0S2RSkg+5kGNoyNoBiiLpv8+zNkKfhKgxr0QMiTqQ== X-Google-Smtp-Source: ABdhPJzC0vN0JaDRTG9c5TGsH9fkbupHyjbfe084sm69JglMhlEIa99nGJXCtSMl92Ch4dEphBLEyKdnjfaSUw9p8Ug= X-Received: by 2002:a1f:b245:: with SMTP id b66mr1161485vkf.3.1606156467081; Mon, 23 Nov 2020 10:34:27 -0800 (PST) MIME-Version: 1.0 References: <20201118220731.925424-1-samitolvanen@google.com> <20201118220731.925424-16-samitolvanen@google.com> <20201123102149.ogl642tw234qod62@google.com> In-Reply-To: <20201123102149.ogl642tw234qod62@google.com> From: Sami Tolvanen Date: Mon, 23 Nov 2020 10:34:16 -0800 Message-ID: Subject: Re: [PATCH v7 15/17] KVM: arm64: disable LTO for the nVHE directory To: David Brazdil Cc: Masahiro Yamada , Steven Rostedt , Will Deacon , Josh Poimboeuf , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arch , linux-arm-kernel , linux-kbuild , LKML , linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 23, 2020 at 2:21 AM David Brazdil wrote: > > Hey Sami, > > On Wed, Nov 18, 2020 at 02:07:29PM -0800, Sami Tolvanen wrote: > > We use objcopy to manipulate ELF binaries for the nVHE code, > > which fails with LTO as the compiler produces LLVM bitcode > > instead. Disable LTO for this code to allow objcopy to be used. > > We now partially link the nVHE code (generating machine code) before objcopy, > so I think you should be able to drop this patch now. Tried building your > branch without it, ran a couple of unit tests and all seems fine. Great, thanks for testing this, David! I'll drop this patch from v8. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29110C63697 for ; Mon, 23 Nov 2020 18:35:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC4372078E for ; Mon, 23 Nov 2020 18:35:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="25K086wE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="a28npanX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC4372078E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tlXz4B9R+m4DfXhlr99UfVwevjrbGjD1B8jlnJfUwTo=; b=25K086wEzfl+Or1s4qrf2zQI1 AIRfqGsNVsLyaerIuuw1Tjp7ivTQgRqqV24CS3Q6UPY63Z8AxmanYmw0BZmgkrayW961a+XIyz6a0 e6+dc6uGeV1wlW7rqQSTMCAcfTWSZFZwAGesgVouxO05+pXsq6pROAbS+BIOVMu5PVWgx0TH2eCXv 1t1WC11rZoHc4p1MTKv2oTByz8U4TXI1AWwZ9eaYIpAiLw3nwdlB0v3NnzRPeaDA0LoXjQ7/wYThx iPM100JhoZl7XEyd18PkaQsxrpozgQ07kDLspFNzDzSwr4eNIv7+OzkMtfqn26hcneFol8PddNwT5 JcdftPZUA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khGfZ-0004Uv-CC; Mon, 23 Nov 2020 18:34:33 +0000 Received: from mail-vk1-xa43.google.com ([2607:f8b0:4864:20::a43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khGfX-0004UL-0n for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 18:34:31 +0000 Received: by mail-vk1-xa43.google.com with SMTP id w67so4166601vke.10 for ; Mon, 23 Nov 2020 10:34:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ducm/uE+sMkPK2UOgkqYMUQ4ilvqi+LJ419ruam/qFs=; b=a28npanXu2b+2Zm6spF8Xxq67i0FF1mofgAXLZrp9sWLlq5VqELCHg7nNtL/fggxfy 4CvQOkS95wisZC5OOhHXgHc7fhFAJxswBiURdiMJ9pvomlaHamPT+ykt9lAJiikZ+dLt osQObvLhHeCEfH726pPrnktuPN+mM05X3eQTo9OM7P951PbVbYXAJtMdKWsW3ZpOJycz Fo60Q7UeI0dsFGaQdho0oc4TBDEtFVDe4gG5sgoLUuJHQYabpl1Mv31/0zpxLkiYJIlP yNiDIkVOpAML5h30am2pinK5OAxNIvR/ui0KubaSslDdw6PBBAOOjQrByts6Koo1ViWx IqJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ducm/uE+sMkPK2UOgkqYMUQ4ilvqi+LJ419ruam/qFs=; b=YcTr5MrjO7CizfSLzpth0wYhf2cw0N57f7OU6u2dCWBHh207MrcIw/nnRs6KfundNP 3cfMBB0XIfYwswpByMhduWEzh+7iY8z057XE3fFDRNYNRoE4tblDkl2UbMM0oXaHmdGM F68waOlOeMMts2IPTZ+1bFdeWFzxh2jTT1uxXm433AA7DeWp2mcWmWb+zmYLrWs0qu4v wiDGQadEIeGtQrLHBcPB8y9UL1MV8dUK4K8ZMj6SZJDdiaO96aGvJ1pP2RhZ1Qa+XrLW ueKu9FN+JV4fsvicinOIfre3egFk2/vvChUHb+pmAedo9yJyz0uJk0bBcAQCrsepZXud etmg== X-Gm-Message-State: AOAM532s3b6wM1sU50590u1fjUnDylhQgNjb87qgatyxIMAMU9RVdmlL Zy3ZAtM8KRpXw/fKPEZNfRLtr40p82VS9UPmRExLZQ== X-Google-Smtp-Source: ABdhPJzC0vN0JaDRTG9c5TGsH9fkbupHyjbfe084sm69JglMhlEIa99nGJXCtSMl92Ch4dEphBLEyKdnjfaSUw9p8Ug= X-Received: by 2002:a1f:b245:: with SMTP id b66mr1161485vkf.3.1606156467081; Mon, 23 Nov 2020 10:34:27 -0800 (PST) MIME-Version: 1.0 References: <20201118220731.925424-1-samitolvanen@google.com> <20201118220731.925424-16-samitolvanen@google.com> <20201123102149.ogl642tw234qod62@google.com> In-Reply-To: <20201123102149.ogl642tw234qod62@google.com> From: Sami Tolvanen Date: Mon, 23 Nov 2020 10:34:16 -0800 Message-ID: Subject: Re: [PATCH v7 15/17] KVM: arm64: disable LTO for the nVHE directory To: David Brazdil X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_133431_137408_2DED86DD X-CRM114-Status: GOOD ( 15.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Kees Cook , "Paul E. McKenney" , Kernel Hardening , Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild , Nick Desaulniers , LKML , Steven Rostedt , clang-built-linux , linux-pci@vger.kernel.org, Josh Poimboeuf , Will Deacon , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 23, 2020 at 2:21 AM David Brazdil wrote: > > Hey Sami, > > On Wed, Nov 18, 2020 at 02:07:29PM -0800, Sami Tolvanen wrote: > > We use objcopy to manipulate ELF binaries for the nVHE code, > > which fails with LTO as the compiler produces LLVM bitcode > > instead. Disable LTO for this code to allow objcopy to be used. > > We now partially link the nVHE code (generating machine code) before objcopy, > so I think you should be able to drop this patch now. Tried building your > branch without it, ran a couple of unit tests and all seems fine. Great, thanks for testing this, David! I'll drop this patch from v8. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F9EC2D0E4 for ; Mon, 23 Nov 2020 18:34:49 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id A47982078E for ; Mon, 23 Nov 2020 18:34:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="a28npanX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A47982078E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-20455-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 23889 invoked by uid 550); 23 Nov 2020 18:34:39 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 23863 invoked from network); 23 Nov 2020 18:34:39 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ducm/uE+sMkPK2UOgkqYMUQ4ilvqi+LJ419ruam/qFs=; b=a28npanXu2b+2Zm6spF8Xxq67i0FF1mofgAXLZrp9sWLlq5VqELCHg7nNtL/fggxfy 4CvQOkS95wisZC5OOhHXgHc7fhFAJxswBiURdiMJ9pvomlaHamPT+ykt9lAJiikZ+dLt osQObvLhHeCEfH726pPrnktuPN+mM05X3eQTo9OM7P951PbVbYXAJtMdKWsW3ZpOJycz Fo60Q7UeI0dsFGaQdho0oc4TBDEtFVDe4gG5sgoLUuJHQYabpl1Mv31/0zpxLkiYJIlP yNiDIkVOpAML5h30am2pinK5OAxNIvR/ui0KubaSslDdw6PBBAOOjQrByts6Koo1ViWx IqJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ducm/uE+sMkPK2UOgkqYMUQ4ilvqi+LJ419ruam/qFs=; b=WYCOql6uQFn3LayfwA8JVSgwOsu/KRUz1Fq69lY2cdVDquCstKyX9EPORYv5pMiUs4 LHNiTv4+i62BxgD1RXL/fdpp3RxL5gqnmHsUmBQ3eSBjx8xJLDp3DCe22Hk6GPWYtMYM 8e7Hgso5D+RRtoSWDasVS+A5HT171iW6vckdAPo6F6ILcBhUminMxOdWQtSXncuSQI/q Vwm6EkOllmGDkyQkamwvmvMLDs7Kn7iQbRccZRl5QM3P+wXk5ILh+afuq4PIQ7KzixGY jC6oRHOd7k9Q/qwwW5FpIsxDsvBGW7gYgg/UtaWl/Edu/MJn7jCzCymnnACdbUmOGh2c HHYA== X-Gm-Message-State: AOAM533vRLWkImw9TRCp0dJzn7jXjwbq1HgmaCpw8ixcfQGF7eKT68Y0 4N6OXnz0kX9P7iIje8tgZJjhnJOP5mCLXGm+lDv4Vg== X-Google-Smtp-Source: ABdhPJzC0vN0JaDRTG9c5TGsH9fkbupHyjbfe084sm69JglMhlEIa99nGJXCtSMl92Ch4dEphBLEyKdnjfaSUw9p8Ug= X-Received: by 2002:a1f:b245:: with SMTP id b66mr1161485vkf.3.1606156467081; Mon, 23 Nov 2020 10:34:27 -0800 (PST) MIME-Version: 1.0 References: <20201118220731.925424-1-samitolvanen@google.com> <20201118220731.925424-16-samitolvanen@google.com> <20201123102149.ogl642tw234qod62@google.com> In-Reply-To: <20201123102149.ogl642tw234qod62@google.com> From: Sami Tolvanen Date: Mon, 23 Nov 2020 10:34:16 -0800 Message-ID: Subject: Re: [PATCH v7 15/17] KVM: arm64: disable LTO for the nVHE directory To: David Brazdil Cc: Masahiro Yamada , Steven Rostedt , Will Deacon , Josh Poimboeuf , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arch , linux-arm-kernel , linux-kbuild , LKML , linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Mon, Nov 23, 2020 at 2:21 AM David Brazdil wrote: > > Hey Sami, > > On Wed, Nov 18, 2020 at 02:07:29PM -0800, Sami Tolvanen wrote: > > We use objcopy to manipulate ELF binaries for the nVHE code, > > which fails with LTO as the compiler produces LLVM bitcode > > instead. Disable LTO for this code to allow objcopy to be used. > > We now partially link the nVHE code (generating machine code) before objcopy, > so I think you should be able to drop this patch now. Tried building your > branch without it, ran a couple of unit tests and all seems fine. Great, thanks for testing this, David! I'll drop this patch from v8. Sami