From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 041551361 for ; Mon, 16 May 2022 16:33:04 +0000 (UTC) Received: by mail-yb1-f178.google.com with SMTP id v71so2904891ybi.4 for ; Mon, 16 May 2022 09:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uVOWBi2MNBuehei9huBnd/8loFbnwhqAiuOC/hCYUtE=; b=UMpVvjAskWnfR6g3ci4cMkPkNEchbPVQCDFZURqGgdGBGtyEU0+pfkHuIEsLxzzdxa B18bBKbFeo2JcX6Nz0IkEdagX64XxF2YEDcGnalbPkbzsdXHnZZGaCAZvltIUt8sXuPo zc+e8B4SuenU8MISBWZpTrjTRFvYcwbYxq6tk/fA+vLgbNtNdpbpv9n/FFbrhrGyS4/A hl891Clm6zzMg1ByvOjCgkYC1CBLqqCMd5UMKl7fYoxLVwfMTVOj3WL8d9fGHLWJxHp1 HFHt9MPjqwqb5TyctUJdvK/tYMZpC5GtaKZHEttGWXNLnXoDb1+0WTqUO3MYlQIJ76Hw 42MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uVOWBi2MNBuehei9huBnd/8loFbnwhqAiuOC/hCYUtE=; b=0X3OhiHo7fFLJyL6QO/bLZ4q01Ne2xd+kn+LeOjG1LqU9HD4TvZ2VNbWe0zgxUoYl7 vqvW2UPrVJ7e1m2rjnMPnwW5xhRMQL/VQZthEdqfMhD2XQqmYe3KxcQu7AZDVIWp9fUl WciEmZskVZOnz+clEuvG/70TVDcN0rWEmpymypEEtKwp826XGZu0OD+9xP1YiWqgWVNO WVGmFhD6q3LU2fAIkhkuo5HS3gx0ZAk/yjJZIclUDeA5xslancoQHtw5J+U0x3QOPzvZ Wn9CkLvo6eEM/5aK05geT4p3Uj2D5qjuaX70jmLrHWzqg0JCp3oio/PZxiTWj9xRDQLX cKow== X-Gm-Message-State: AOAM530idtov0cuNZx1u4zxTqRPy7y2a8Bihkv/ex9Mdj6bgwIyQC7y8 2EuRUAJM1RFaDwjvrns/RBsC56i16KoslpoXRSnsLA== X-Google-Smtp-Source: ABdhPJxnm0eijYHOVmrixfo245yISpWoVL7JodzT9EqGHwvEuWoWte/Watn8vMd89vUvUVL2y2IhRQzqqpGLJpOURZA= X-Received: by 2002:a05:6902:90b:b0:64b:233d:8e03 with SMTP id bu11-20020a056902090b00b0064b233d8e03mr18090305ybb.428.1652718783727; Mon, 16 May 2022 09:33:03 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-15-samitolvanen@google.com> <202205141455.0A6F409@keescook> In-Reply-To: <202205141455.0A6F409@keescook> From: Sami Tolvanen Date: Mon, 16 May 2022 09:32:27 -0700 Message-ID: Subject: Re: [RFC PATCH v2 14/21] treewide: Drop __cficanonical To: Kees Cook Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Sat, May 14, 2022 at 2:56 PM Kees Cook wrote: > > On Fri, May 13, 2022 at 01:21:52PM -0700, Sami Tolvanen wrote: > > CONFIG_CFI_CLANG doesn't use a jump table anymore and therefore, > > won't change function references to point elsewhere. Remove the > > __cficanonical attribute and all uses of it. > > > > Signed-off-by: Sami Tolvanen > > --- > > include/linux/compiler_types.h | 4 ---- > > include/linux/init.h | 4 ++-- > > include/linux/pci.h | 4 ++-- > > 3 files changed, 4 insertions(+), 8 deletions(-) > > I think this is missing removing it from include/linux/compiler-clang.h ? That was removed in the earlier patch that switched the CFI implementation. > With that done (or explained why not): I'll add a note about it to the commit message. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5446FC433EF for ; Mon, 16 May 2022 16:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cyKY94o2iMZ/KDFaav3HhB4at34gV/X/c2iMFHtJQNw=; b=K34cPj5UWBPX59 G7/ncUnFVGdAriGmyhKJifZUcJNQzkcYW+tufd2nXEpfnfcjid7D5JM97b0dnXair7N2lgK8ZYntL EauXOooepsTIpUDr6ODCwT0tp8k6sGlZFDrxs+QILmf/5SzRtaX8bigIP1MPnypLajiA1Sx5OyG6b ZvoBfAt2BiTvT9uu4ME0kzHDSZEXbFY+OtWitGhKypmobcRaKEppPz+mrC2Qf7piT+bUaDfBP9VK7 WAyZqr8yuCb7aka1IHVlk05QPFYB1hdC2xYafJ0kHJ0l/4eeqhstpEmtAdwQd8I5zJ0V6xh4vwbPW a8XYmmo2L1HPGXl2upkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqdiN-0093Xl-F0; Mon, 16 May 2022 16:36:59 +0000 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqdeb-0091bq-N3 for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 16:33:07 +0000 Received: by mail-yb1-xb2f.google.com with SMTP id i11so27902522ybq.9 for ; Mon, 16 May 2022 09:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uVOWBi2MNBuehei9huBnd/8loFbnwhqAiuOC/hCYUtE=; b=UMpVvjAskWnfR6g3ci4cMkPkNEchbPVQCDFZURqGgdGBGtyEU0+pfkHuIEsLxzzdxa B18bBKbFeo2JcX6Nz0IkEdagX64XxF2YEDcGnalbPkbzsdXHnZZGaCAZvltIUt8sXuPo zc+e8B4SuenU8MISBWZpTrjTRFvYcwbYxq6tk/fA+vLgbNtNdpbpv9n/FFbrhrGyS4/A hl891Clm6zzMg1ByvOjCgkYC1CBLqqCMd5UMKl7fYoxLVwfMTVOj3WL8d9fGHLWJxHp1 HFHt9MPjqwqb5TyctUJdvK/tYMZpC5GtaKZHEttGWXNLnXoDb1+0WTqUO3MYlQIJ76Hw 42MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uVOWBi2MNBuehei9huBnd/8loFbnwhqAiuOC/hCYUtE=; b=wyx8KdXVyMa2JA1Dvwmf/jbtgXJx7KUDVwsiwTDfNoG5dIhVVbS3xylgQxS+NkNHSX QfgOaz8Xdp6PlLnwU1WB4pfScQWiHJ0iXpiZqCO5bxN7TlRI44RELPd8zYT3LvXXvbHG uU6UwTvLjb9hS/A5dBAfnRK96LPcU72HWuf1sb8DoE8z+NBWYE+Oy3lHPb98a+GQtNON U2ZXhc/3JPL+AifPeNI4qJyZ8Ce6AqcpVQAwcS8c18LCmyDO9Z6E156PwqRKg6QygcKF F0oZ/cxE6h02qG7HrXBqpvmNeXVMDoOQpekpL3+a8v+40JhXRgMA/EeXUf/BybPYlnNs e3+A== X-Gm-Message-State: AOAM530n7eBqK24zVAa+4SlFlOyfQcKH/nHD1eVhHMq8YSyDCcyK1X/v YtKHwMA+T9kMPOat/3l5eoDbGTj2MCfGL2dOwj+dtw== X-Google-Smtp-Source: ABdhPJxnm0eijYHOVmrixfo245yISpWoVL7JodzT9EqGHwvEuWoWte/Watn8vMd89vUvUVL2y2IhRQzqqpGLJpOURZA= X-Received: by 2002:a05:6902:90b:b0:64b:233d:8e03 with SMTP id bu11-20020a056902090b00b0064b233d8e03mr18090305ybb.428.1652718783727; Mon, 16 May 2022 09:33:03 -0700 (PDT) MIME-Version: 1.0 References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-15-samitolvanen@google.com> <202205141455.0A6F409@keescook> In-Reply-To: <202205141455.0A6F409@keescook> From: Sami Tolvanen Date: Mon, 16 May 2022 09:32:27 -0700 Message-ID: Subject: Re: [RFC PATCH v2 14/21] treewide: Drop __cficanonical To: Kees Cook Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_093305_855166_C471CED5 X-CRM114-Status: GOOD ( 18.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 14, 2022 at 2:56 PM Kees Cook wrote: > > On Fri, May 13, 2022 at 01:21:52PM -0700, Sami Tolvanen wrote: > > CONFIG_CFI_CLANG doesn't use a jump table anymore and therefore, > > won't change function references to point elsewhere. Remove the > > __cficanonical attribute and all uses of it. > > > > Signed-off-by: Sami Tolvanen > > --- > > include/linux/compiler_types.h | 4 ---- > > include/linux/init.h | 4 ++-- > > include/linux/pci.h | 4 ++-- > > 3 files changed, 4 insertions(+), 8 deletions(-) > > I think this is missing removing it from include/linux/compiler-clang.h ? That was removed in the earlier patch that switched the CFI implementation. > With that done (or explained why not): I'll add a note about it to the commit message. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel