From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23099CA9ECF for ; Fri, 1 Nov 2019 16:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB07821734 for ; Fri, 1 Nov 2019 16:33:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mVdZ7udl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728912AbfKAQdH (ORCPT ); Fri, 1 Nov 2019 12:33:07 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:38479 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727148AbfKAQdG (ORCPT ); Fri, 1 Nov 2019 12:33:06 -0400 Received: by mail-vs1-f68.google.com with SMTP id b184so3189140vsc.5 for ; Fri, 01 Nov 2019 09:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j5WHWvyJ9Hz5kosmku4ReDEqbYSNCjtYvPAtQ8gov0w=; b=mVdZ7udliBm1Ah/0SRYlDf6bwEJ6TL7x3JmnofXlcyZOXqi5Q9VBuiMbpvt9qFtviY O1dg12Mx/ZqNCdmPnMehixCUQwwDXQwkP8easpaC7ETmB8M+bGzkf5mtTCIfXJepYgXQ UpEXv0+Y/8IRh6Bt9tXSt5I5dm6Naa/8+P0Gfr7zVhf9zJ0enNNpTxkLjpUS3Y3FM1TQ K14mAw/P1HzmMF2Q3lOwbI6KFmRqbDNTH4h5du1QpSKj0tUoB4V/KntCBftt2t3ivGyo CvnopvuGe8ctEsWcfBzhSVdFtD8ECLxaPGft365BahwUkKRXVOufpCDz3m9fqW+WiVMo c2IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j5WHWvyJ9Hz5kosmku4ReDEqbYSNCjtYvPAtQ8gov0w=; b=DfbvkqYAJ0XOhC44NSKL7Bh/O14HLFF+Hx6OA1GWllkrS/9HurfboFEpzv63MYnqD3 eTWamZOcWVfwCvCQ9hx0G3JPkHMcA/Yn1ZNocCYv8SDmh338Ejafs6NEGxuxlz1WBzFi i2x6m5d3kzKb5k5U36NkPcX3vCzBLI41k7YqBlyAHc8qt4Arg1sYj2eDkdH47OKUSl7w guZxpw5nn85NboHImXCj3Xat4xaUwxv5z9SNeGg6QjWYFKdtV8dRXyG43Rw8AmiAXvsJ tO+gXZcOvv05tzTV4QIZBeyO3DAA7OJYy2Qu4ROBbUh7wB14Pt2p5JvaXWz5WfkL/0jQ EyLw== X-Gm-Message-State: APjAAAUaVtOalGdgRgeE8TFytEv80jB9lM+E+T0zoVjy6QPq4CiqBcz4 6Bwo6W/Oqb5VDd3Lmk1ExtTjNpZ3M0FYjAmkO8uqVg== X-Google-Smtp-Source: APXvYqyUC2VNoK3kn3nz3vybeugE+sMvvcm2WU0gwrr3Eljqv0y0V3sHBklXl+ihwCVizGZj+lsXZashNS/ogzG8fqQ= X-Received: by 2002:a05:6102:36a:: with SMTP id f10mr1696654vsa.44.1572625985166; Fri, 01 Nov 2019 09:33:05 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-8-samitolvanen@google.com> <201910312054.3064999E@keescook> In-Reply-To: <201910312054.3064999E@keescook> From: Sami Tolvanen Date: Fri, 1 Nov 2019 09:32:54 -0700 Message-ID: Subject: Re: [PATCH v3 07/17] scs: add support for stack usage debugging To: Kees Cook Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Laura Abbott , Mark Rutland , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 31, 2019 at 8:55 PM Kees Cook wrote: > > On Thu, Oct 31, 2019 at 09:46:27AM -0700, samitolvanen@google.com wrote: > > Implements CONFIG_DEBUG_STACK_USAGE for shadow stacks. > > Did I miss it, or is there no Kconfig section for this? I just realized > I can't find it. I was going to say "this commit log should explain > why/when this option is used", but then figured it might be explained in > the Kconfig ... but I couldn't find it. ;) It's in lib/Kconfig.debug. But yes, I will add a commit message in v4. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B939CA9ECF for ; Fri, 1 Nov 2019 16:33:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2644217D9 for ; Fri, 1 Nov 2019 16:33:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XTDTSQDA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="mVdZ7udl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2644217D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8KyrtAEE8ZWQCjMRTVUZiBUt1oiZe3+j5Ed5I1SPyZg=; b=XTDTSQDAzH01uF zjqECgiTuPi1nolCxbnmYJJylDuWGpgl9ZMxRYjeNNkQowXRJaMrZFJ5pyCRp3GZGCj1IWX0KJaRZ 8EZQLYpv3ELr3NNe5tau6SRybP/RvixlPmLDCjUGaRRR6YVc7P5yYRRl06jYX8H/XyrjfJadrupbX 9LPEYH5et2vyELodTaMOvWDWyRACPfRyFob4qGc0DWJ++niqFuB6QmeWxJLVLhSffXLCBL15j39gj VtwJJWKqBtv9sxMlMjMs9Zz/47MKMLYmxwHMzL0R9ZgM6PFjhZVTP2MqkTMnPMmucw4pMOHzx59sq PVi/hi0nh2Qqlt4zan/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQZrK-0004YH-Ke; Fri, 01 Nov 2019 16:33:10 +0000 Received: from mail-vs1-xe42.google.com ([2607:f8b0:4864:20::e42]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQZrI-0004XI-9c for linux-arm-kernel@lists.infradead.org; Fri, 01 Nov 2019 16:33:09 +0000 Received: by mail-vs1-xe42.google.com with SMTP id l5so6700031vsh.12 for ; Fri, 01 Nov 2019 09:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j5WHWvyJ9Hz5kosmku4ReDEqbYSNCjtYvPAtQ8gov0w=; b=mVdZ7udliBm1Ah/0SRYlDf6bwEJ6TL7x3JmnofXlcyZOXqi5Q9VBuiMbpvt9qFtviY O1dg12Mx/ZqNCdmPnMehixCUQwwDXQwkP8easpaC7ETmB8M+bGzkf5mtTCIfXJepYgXQ UpEXv0+Y/8IRh6Bt9tXSt5I5dm6Naa/8+P0Gfr7zVhf9zJ0enNNpTxkLjpUS3Y3FM1TQ K14mAw/P1HzmMF2Q3lOwbI6KFmRqbDNTH4h5du1QpSKj0tUoB4V/KntCBftt2t3ivGyo CvnopvuGe8ctEsWcfBzhSVdFtD8ECLxaPGft365BahwUkKRXVOufpCDz3m9fqW+WiVMo c2IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j5WHWvyJ9Hz5kosmku4ReDEqbYSNCjtYvPAtQ8gov0w=; b=KPlSHtJsrafTsG0boSDEjyQe7S/gkCm4XMVw72cTfXCz4OZ3nwM3ZF/YqPlCLHA34E o9D3abmx7Ec6v0XI/T6I8joivi67qNbXLLXEp3d5JuFJQyofxrIGVNHG+HaRb7EuqcKw uEPAaPFCpQGQhxSLrBFw02CmJj8WF/zKHXlF7ft9Tm42z9Cz93T1ivWY/Bg1QkZlmyjS xbZM6ElagmspW8fjT3swICdRSKLT3wJCpsVrnRDuK3s6MuD0FG3IyZLmOgROk4Svkp5S YEEiQ4Vua+AoA9KpoLryHtAK2YBFz90uTD7Q9zzcatBzpQhYDV30RuhXN+Be4bL992oe 9SUQ== X-Gm-Message-State: APjAAAVS3+h1wSpPCq+Y9cEMTJYYJEvtU65bEhTI6htt4iQZ9E/l8MKW so2NA5eZNMQNLhUKKwtl3rMdfCNI/UIM4i5AhIGh/A== X-Google-Smtp-Source: APXvYqyUC2VNoK3kn3nz3vybeugE+sMvvcm2WU0gwrr3Eljqv0y0V3sHBklXl+ihwCVizGZj+lsXZashNS/ogzG8fqQ= X-Received: by 2002:a05:6102:36a:: with SMTP id f10mr1696654vsa.44.1572625985166; Fri, 01 Nov 2019 09:33:05 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-8-samitolvanen@google.com> <201910312054.3064999E@keescook> In-Reply-To: <201910312054.3064999E@keescook> From: Sami Tolvanen Date: Fri, 1 Nov 2019 09:32:54 -0700 Message-ID: Subject: Re: [PATCH v3 07/17] scs: add support for stack usage debugging To: Kees Cook X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191101_093308_358856_B8F7BB38 X-CRM114-Status: GOOD ( 11.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , clang-built-linux , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , Masami Hiramatsu , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 31, 2019 at 8:55 PM Kees Cook wrote: > > On Thu, Oct 31, 2019 at 09:46:27AM -0700, samitolvanen@google.com wrote: > > Implements CONFIG_DEBUG_STACK_USAGE for shadow stacks. > > Did I miss it, or is there no Kconfig section for this? I just realized > I can't find it. I was going to say "this commit log should explain > why/when this option is used", but then figured it might be explained in > the Kconfig ... but I couldn't find it. ;) It's in lib/Kconfig.debug. But yes, I will add a commit message in v4. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB2FCA9ECF for ; Fri, 1 Nov 2019 16:33:24 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 66119217D9 for ; Fri, 1 Nov 2019 16:33:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mVdZ7udl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66119217D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17228-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 17416 invoked by uid 550); 1 Nov 2019 16:33:18 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 16372 invoked from network); 1 Nov 2019 16:33:17 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j5WHWvyJ9Hz5kosmku4ReDEqbYSNCjtYvPAtQ8gov0w=; b=mVdZ7udliBm1Ah/0SRYlDf6bwEJ6TL7x3JmnofXlcyZOXqi5Q9VBuiMbpvt9qFtviY O1dg12Mx/ZqNCdmPnMehixCUQwwDXQwkP8easpaC7ETmB8M+bGzkf5mtTCIfXJepYgXQ UpEXv0+Y/8IRh6Bt9tXSt5I5dm6Naa/8+P0Gfr7zVhf9zJ0enNNpTxkLjpUS3Y3FM1TQ K14mAw/P1HzmMF2Q3lOwbI6KFmRqbDNTH4h5du1QpSKj0tUoB4V/KntCBftt2t3ivGyo CvnopvuGe8ctEsWcfBzhSVdFtD8ECLxaPGft365BahwUkKRXVOufpCDz3m9fqW+WiVMo c2IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j5WHWvyJ9Hz5kosmku4ReDEqbYSNCjtYvPAtQ8gov0w=; b=BHFqY0CjJtwpYJqQ2J7s2UXHBYO+0iUgsSwY8x6qQpHXZJOXvY4gmDvAfVD7rH+4wV SVQ+Hp8HcoSBwFA7h8YzBlJU5cMPAMOjVTjmJavDLauYQR4D/O/REti4dZ2I1aDFzEhU C0dMyXWPrkXTNZkCBIfTd4qz0KIuDUizUeE9uE7SS4R90XdVomVRAIYmo/B08tKo/q8B sMnP8U9yLn/+GVRWN8J53HcFhfOClUtvvjUdARLaRIbYc0/AhAkkSML1rqMvUVAK0nMl kHuQqkK/8N28mcNcA27X84JWpzSLRzFAF4aYqSTnQZivB8FUeaeBPnRLT0SXNeTQptjs mntQ== X-Gm-Message-State: APjAAAURet70wvJq8Hlbr/0NZVFnsT90/7EemOR4AHeftg5JbRPi929U 6HkmIEuPQ4f/emJW+fgc8YUssnGIEOZjAMe/cGpDDw== X-Google-Smtp-Source: APXvYqyUC2VNoK3kn3nz3vybeugE+sMvvcm2WU0gwrr3Eljqv0y0V3sHBklXl+ihwCVizGZj+lsXZashNS/ogzG8fqQ= X-Received: by 2002:a05:6102:36a:: with SMTP id f10mr1696654vsa.44.1572625985166; Fri, 01 Nov 2019 09:33:05 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-8-samitolvanen@google.com> <201910312054.3064999E@keescook> In-Reply-To: <201910312054.3064999E@keescook> From: Sami Tolvanen Date: Fri, 1 Nov 2019 09:32:54 -0700 Message-ID: Subject: Re: [PATCH v3 07/17] scs: add support for stack usage debugging To: Kees Cook Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Laura Abbott , Mark Rutland , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" On Thu, Oct 31, 2019 at 8:55 PM Kees Cook wrote: > > On Thu, Oct 31, 2019 at 09:46:27AM -0700, samitolvanen@google.com wrote: > > Implements CONFIG_DEBUG_STACK_USAGE for shadow stacks. > > Did I miss it, or is there no Kconfig section for this? I just realized > I can't find it. I was going to say "this commit log should explain > why/when this option is used", but then figured it might be explained in > the Kconfig ... but I couldn't find it. ;) It's in lib/Kconfig.debug. But yes, I will add a commit message in v4. Sami