From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51456CA9ECB for ; Thu, 31 Oct 2019 17:42:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29B5C2083E for ; Thu, 31 Oct 2019 17:42:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vyAZGLuQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729121AbfJaRmb (ORCPT ); Thu, 31 Oct 2019 13:42:31 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:34346 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728974AbfJaRma (ORCPT ); Thu, 31 Oct 2019 13:42:30 -0400 Received: by mail-vs1-f68.google.com with SMTP id 127so1725399vsn.1 for ; Thu, 31 Oct 2019 10:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SpMt9swBFV/X7pJxY11yJxvoU/jl5TYZqkYEwxVo1zk=; b=vyAZGLuQJaP6UmPU/5OivZeIeCWgYHlNvqLsuh7U3yYJqNwBg3VduUAZbxG7Wh6UWt vR9hiusZOPdTKmpPzcbCdthcVtfAuVWCA/M8pStelbzfHpRETEdtgYoVIO74pLVcS5Aj PDux1c/zr+9UcdqYc/u8vkoVsM0YeYHd9+PtmsdPd6I9nLItOy76IJT1irNZ7ZvnLPOp Awz0G6XV3jDbzYKy0ICsWxla4idyK6XrPywrZoHibV+ewA3guRirwYmw7BYI3lR697k/ 6y0spqBrB465HxukOz7+BvekqO5c7tmGdGe9sOFhPb3/TuqkcTuslnkiueSXTjL7kZ2a Exew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SpMt9swBFV/X7pJxY11yJxvoU/jl5TYZqkYEwxVo1zk=; b=IT8QDTP1e0YpjKxRed1LY2jCSrvX63CvVZWqhTzDgYqSnVnSFjpkk9rKwT5xB6+HC+ RT9m6VzwegNqSho1574q1vN6dC9gXyAItLzIqa4OMtgkpcidNlDNkHZPKoXA6VGYx1rt JPv9z/oVFDxsJDdaqLpUIZPQADSetGUizEgAaeu7sCKH0tWO9OlE/fjV4Yr2tZEpsYKX GUAvcIwvzJx4ENlDZiT9waM+iXfomRaDTFXcQVM/3+27bU+4m9OOC/1j1YDHFOrZopS+ UxOmuwm0VEopqkkVLVZnGYo4jxm7Cb04efq67TlhKBhGZQecWA9CmoXlzKsU4BNNst60 HpXw== X-Gm-Message-State: APjAAAWg2rL4Atr29D+WNwX6faGyEdCDnDkH4GeFI8chbmwy4kUv2nlA HmWmRU0v5TI0n0rH5RItYW+I6+hkyPQqagWXUkQy0Q== X-Google-Smtp-Source: APXvYqw74Dsa5tbwvZVY6ubm3mq6Ol0GpZBf3HyKWvRWHEbC8fAxc8l0X7gBK5dChGcDSWL/yjwxE6D5ZDxmwT29ntI= X-Received: by 2002:a67:ed8b:: with SMTP id d11mr3309159vsp.104.1572543748924; Thu, 31 Oct 2019 10:42:28 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-14-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Thu, 31 Oct 2019 10:42:17 -0700 Message-ID: Subject: Re: [PATCH v3 13/17] arm64: preserve x18 when CPU is suspended To: Nick Desaulniers Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 31, 2019 at 10:35 AM Nick Desaulniers wrote: > > On Thu, Oct 31, 2019 at 10:27 AM Sami Tolvanen wrote: > > > > On Thu, Oct 31, 2019 at 10:18 AM Nick Desaulniers > > wrote: > > > > +#ifdef CONFIG_SHADOW_CALL_STACK > > > > + ldr x18, [x0, #96] > > > > + str xzr, [x0, #96] > > > > > > How come we zero out x0+#96, but not for other offsets? Is this str necessary? > > > > It clears the shadow stack pointer from the sleep state buffer, which > > is not strictly speaking necessary, but leaves one fewer place to find > > it. > > That sounds like a good idea. Consider adding comments or to the > commit message so that the str doesn't get removed accidentally in the > future. Sure, I'll add a comment in the next version. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC0D2CA9ECB for ; Thu, 31 Oct 2019 17:42:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6E502083E for ; Thu, 31 Oct 2019 17:42:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NgIYOeAl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="vyAZGLuQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6E502083E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dkF750C7xGSxd+vLZYsYXjpDM3vAYKItH0UI6KDMy5o=; b=NgIYOeAl/p3ue4 GJDU7ZdCxYdpU7GGzgNDbrQ513cgoFlfTQC0IcNdmA/sNLj7ui9ONj0QJ+ylg33Q4E5Pd+aejDqMX kxKKNLf8srgGmfLIOzdK2RWvO4jEfNyBtv8xbOocKDeE3rK5kpgj7uZixOZ+6zoG0Ui3vFTIWPupr S0LkTIxIUI8iegWu6yYd0XKLcENr8GDY8xViht9jyozqUAqrs4We1/y0bNiu8NKS4w5LtCXSZWBif nQOJSXlsXT+zEIikr7IDXWhpz7qM1kVSESHhL7HKH642yRY4WO3sN3KXzHLvy5X46JnhVzkwHD8Ar GDPka5rUSwVdNb9LeFiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQESw-00027y-0i; Thu, 31 Oct 2019 17:42:34 +0000 Received: from mail-vs1-xe43.google.com ([2607:f8b0:4864:20::e43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQESs-00027d-M8 for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2019 17:42:31 +0000 Received: by mail-vs1-xe43.google.com with SMTP id g7so1786481vsm.10 for ; Thu, 31 Oct 2019 10:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SpMt9swBFV/X7pJxY11yJxvoU/jl5TYZqkYEwxVo1zk=; b=vyAZGLuQJaP6UmPU/5OivZeIeCWgYHlNvqLsuh7U3yYJqNwBg3VduUAZbxG7Wh6UWt vR9hiusZOPdTKmpPzcbCdthcVtfAuVWCA/M8pStelbzfHpRETEdtgYoVIO74pLVcS5Aj PDux1c/zr+9UcdqYc/u8vkoVsM0YeYHd9+PtmsdPd6I9nLItOy76IJT1irNZ7ZvnLPOp Awz0G6XV3jDbzYKy0ICsWxla4idyK6XrPywrZoHibV+ewA3guRirwYmw7BYI3lR697k/ 6y0spqBrB465HxukOz7+BvekqO5c7tmGdGe9sOFhPb3/TuqkcTuslnkiueSXTjL7kZ2a Exew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SpMt9swBFV/X7pJxY11yJxvoU/jl5TYZqkYEwxVo1zk=; b=YSSJiKbNeDWkwui4r3Pqo58HEySlJuUShKoJET8KiMZmAp6AqXVvLeuJMrwX2l6iMM Vt200YFlepsbfuWJprlquMqiLfApZlIU0N3+b3fIb+YO6mvWcMDhZXGTY89I+0etT+V3 cSWef1RsndgN/zlaGW/63wGWVVse7wKBMqSil4Z0ku6PO03SfolCkWlQcRsec2TycVJ6 /Fa+avt0Jvv20JvgZ328XXaOX4LejAGSqzlygG6xN1AHWJhHP5uxJvUWiU5IZEAkw/b2 jMrDIzHall0UJHl7QYr1a/o2iEU5kiA6Hk+saR+4/DmFM+G35J/VFlaaR2kPSSiH/h1A 6sSA== X-Gm-Message-State: APjAAAVhs/JHUVWRMrXbRQ3KoOwYuG40K6WaM2kggFqwpJd9iz93LRex SwuJsX+QuAQhcfd37BBz4S9rLedKkXUVJUAAMBmOVw== X-Google-Smtp-Source: APXvYqw74Dsa5tbwvZVY6ubm3mq6Ol0GpZBf3HyKWvRWHEbC8fAxc8l0X7gBK5dChGcDSWL/yjwxE6D5ZDxmwT29ntI= X-Received: by 2002:a67:ed8b:: with SMTP id d11mr3309159vsp.104.1572543748924; Thu, 31 Oct 2019 10:42:28 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-14-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Thu, 31 Oct 2019 10:42:17 -0700 Message-ID: Subject: Re: [PATCH v3 13/17] arm64: preserve x18 when CPU is suspended To: Nick Desaulniers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191031_104230_749268_586AF1D5 X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , LKML , Steven Rostedt , Miguel Ojeda , Masami Hiramatsu , clang-built-linux , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 31, 2019 at 10:35 AM Nick Desaulniers wrote: > > On Thu, Oct 31, 2019 at 10:27 AM Sami Tolvanen wrote: > > > > On Thu, Oct 31, 2019 at 10:18 AM Nick Desaulniers > > wrote: > > > > +#ifdef CONFIG_SHADOW_CALL_STACK > > > > + ldr x18, [x0, #96] > > > > + str xzr, [x0, #96] > > > > > > How come we zero out x0+#96, but not for other offsets? Is this str necessary? > > > > It clears the shadow stack pointer from the sleep state buffer, which > > is not strictly speaking necessary, but leaves one fewer place to find > > it. > > That sounds like a good idea. Consider adding comments or to the > commit message so that the str doesn't get removed accidentally in the > future. Sure, I'll add a comment in the next version. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E964DCA9ECB for ; Thu, 31 Oct 2019 17:42:48 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 426862083E for ; Thu, 31 Oct 2019 17:42:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vyAZGLuQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 426862083E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17208-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 21753 invoked by uid 550); 31 Oct 2019 17:42:41 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 21733 invoked from network); 31 Oct 2019 17:42:41 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SpMt9swBFV/X7pJxY11yJxvoU/jl5TYZqkYEwxVo1zk=; b=vyAZGLuQJaP6UmPU/5OivZeIeCWgYHlNvqLsuh7U3yYJqNwBg3VduUAZbxG7Wh6UWt vR9hiusZOPdTKmpPzcbCdthcVtfAuVWCA/M8pStelbzfHpRETEdtgYoVIO74pLVcS5Aj PDux1c/zr+9UcdqYc/u8vkoVsM0YeYHd9+PtmsdPd6I9nLItOy76IJT1irNZ7ZvnLPOp Awz0G6XV3jDbzYKy0ICsWxla4idyK6XrPywrZoHibV+ewA3guRirwYmw7BYI3lR697k/ 6y0spqBrB465HxukOz7+BvekqO5c7tmGdGe9sOFhPb3/TuqkcTuslnkiueSXTjL7kZ2a Exew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SpMt9swBFV/X7pJxY11yJxvoU/jl5TYZqkYEwxVo1zk=; b=N+w/xkL/buQ4ZjVhW3uASrevT9jo/mg1hy1eRBI8QbwKjVZqTzX2/662WELpDI7NGs xSc1ZE859VNmFZmob3VyTfnqvoyoKtgRR9le05Ee534MuHl1s7ehefP1PGMHl5dPqJdz 9dWPPQtz6pmSqyLD1nT7twW/K+Fy92y8QcADIysyV/jmRAiUbKuzd9DA2W0bdM/VpP08 RWlulu90p/0cOwDmnNyqsd3LIv9G8JBxdsqmVI82lfCcrlVP/uhNlQ8yYWFYlMx3aM1X B+auxWkuOxJBD20J3iMmvrL+HTb3sb5AhqyvfGhHqWgw20SG0thaczs2ndE+wJFy2+oY EKpw== X-Gm-Message-State: APjAAAXgQNotyNXYR4roeG8JZF7W6w4ZjZRbDrPFUrEz0njqelH/rs8t dTimm+030xtlFGQ0sC2nEtt8XjrNULfYVds013Ac5g== X-Google-Smtp-Source: APXvYqw74Dsa5tbwvZVY6ubm3mq6Ol0GpZBf3HyKWvRWHEbC8fAxc8l0X7gBK5dChGcDSWL/yjwxE6D5ZDxmwT29ntI= X-Received: by 2002:a67:ed8b:: with SMTP id d11mr3309159vsp.104.1572543748924; Thu, 31 Oct 2019 10:42:28 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-14-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Thu, 31 Oct 2019 10:42:17 -0700 Message-ID: Subject: Re: [PATCH v3 13/17] arm64: preserve x18 when CPU is suspended To: Nick Desaulniers Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" On Thu, Oct 31, 2019 at 10:35 AM Nick Desaulniers wrote: > > On Thu, Oct 31, 2019 at 10:27 AM Sami Tolvanen wrote: > > > > On Thu, Oct 31, 2019 at 10:18 AM Nick Desaulniers > > wrote: > > > > +#ifdef CONFIG_SHADOW_CALL_STACK > > > > + ldr x18, [x0, #96] > > > > + str xzr, [x0, #96] > > > > > > How come we zero out x0+#96, but not for other offsets? Is this str necessary? > > > > It clears the shadow stack pointer from the sleep state buffer, which > > is not strictly speaking necessary, but leaves one fewer place to find > > it. > > That sounds like a good idea. Consider adding comments or to the > commit message so that the str doesn't get removed accidentally in the > future. Sure, I'll add a comment in the next version. Sami