From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E47CA9EC0 for ; Mon, 28 Oct 2019 16:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C421208C0 for ; Mon, 28 Oct 2019 16:15:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cRlJ8go8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732088AbfJ1QPN (ORCPT ); Mon, 28 Oct 2019 12:15:13 -0400 Received: from mail-vs1-f66.google.com ([209.85.217.66]:39329 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729469AbfJ1QPN (ORCPT ); Mon, 28 Oct 2019 12:15:13 -0400 Received: by mail-vs1-f66.google.com with SMTP id y129so6706904vsc.6 for ; Mon, 28 Oct 2019 09:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NAeDGv4mmTdcJjmFC/Y5EqwPqrlxkNMDKmTxGtNGkZY=; b=cRlJ8go8Gwg5sHkB7ZS3FAbbXtnMD/tbE+zSlh/I1r1/OC/G4k2GVu3K4ZQIVtSesK qWj5vEzyZr/kwqbQ/BTQz27rlFGtYiadnB4BjwV9Aanq9y6mIcNlZgE0TDCUZmzdfMAK pYXldXOHSP6bQqOp2tqseN1pN+uwLR+zn/EQU53d0ejxptXvTV4EloD/dPmL0glR+KIS nM5OLYggHmVr1GJPpWaCLHPpHehzf5Xxk2CL48eRGzuTedh2dhf7I58eB/9um9Q2ykj/ fH8V56DN6X6u8meTksQpmCSDkwZZFwfBU/9m+m5LLJy37fUNh5yE52TZE9xDBcF8G6ck eKDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NAeDGv4mmTdcJjmFC/Y5EqwPqrlxkNMDKmTxGtNGkZY=; b=BrKuJHtOFwbymcfpjNKur4M1YpdsklOmA7eaBOmTg/0xzKI4Fj1q3gitgZFEI0UeK5 uPx9kD3XQXc2nWdRFQO+beN5ZmshhA/mlehqXr8RJSSII9b2i4DRCMIQ2shXKj2JgzfN aiDsT96UubTOo2TmcxWi6dlTmCQwRbqXblSgLOMULTYtMkwbfIH+OWOWkeQs0zjmEslu k92koOA5xIOw1c8sk7Epq3XbOXIQGi70jervQODv0M2PeWa30hJolcNzgDc7fdeaTR/e 2PXOlR7Qs0nE+2Xr1b8QbtuIazwy1STv8yfKP4PYv57gTjItyLL0+tTsbMYqGPPFHGZ0 QHow== X-Gm-Message-State: APjAAAXn2fPSJQOdjXzLCVnAxtAqLQGEjDwABFIO9GFVeOCnOsjg9Yza ZdoaYmp6N95VJxz1Yk64XCzTKp2QR+vs75BCqu/w1g== X-Google-Smtp-Source: APXvYqyErnDNeReEYHXLOlOQvJxZB1LCeRqzFRFTtzuu+yjPbfij2oddf0msvyrSOjimXhfQmIZ/10I+XmQJOMeVmmI= X-Received: by 2002:a67:ffc7:: with SMTP id w7mr9278938vsq.15.1572279312128; Mon, 28 Oct 2019 09:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191024225132.13410-1-samitolvanen@google.com> <20191024225132.13410-6-samitolvanen@google.com> <2c13c39acb55df5dbb0d40c806bb1d7dc4bde2ae.camel@perches.com> In-Reply-To: From: Sami Tolvanen Date: Mon, 28 Oct 2019 09:15:00 -0700 Message-ID: Subject: Re: [PATCH v2 05/17] add support for Clang's Shadow Call Stack (SCS) To: Miguel Ojeda Cc: Ard Biesheuvel , Catalin Marinas , Dave Martin , Jann Horn , Joe Perches , Kees Cook , Kernel Hardening , LKML , Laura Abbott , Mark Rutland , Masahiro Yamada , Masami Hiramatsu , Nick Desaulniers , Steven Rostedt , Will Deacon , clang-built-linux , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 28, 2019 at 8:31 AM Miguel Ojeda wrote: > We decided to do it like that when I introduced compiler_attributes.h. > > Given it is hidden behind a definition, we don't care about which one we use internally; therefore the idea was to avoid clashes as much as possible with other names/definitions/etc. > > The syntax is supported in the compilers we care about (for docs on attributes, the best reference is GCC's by the way). Got it, thank you for explaining. I'll change this to __no_sanitize__ in v3 since Clang seems to be happy with either version. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 997D3CA9EC0 for ; Mon, 28 Oct 2019 16:15:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CF7F208C0 for ; Mon, 28 Oct 2019 16:15:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zhh8KQ/s"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="cRlJ8go8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CF7F208C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D1AQsiJ7oPUbiW1Lu2TkgPjD/pDgkYvlHw4L0BS/Zcc=; b=Zhh8KQ/smSxotS IqlAdQPyZLI7I0VmPhiyDJRJMkRosxcspt4LdG6Oa6ELZqOEeEd/RqoRTTFB+xVC66N5YUeC+X1Hq oyqnFrSaaTiY4Zai6zTYR+wmWgavcpKpBWXS1iJet4z36M2/PEJScr4mDOJY5iXac9fPiCT4qT2ec ejhdxkj9xFO2FcvqJnkRefLBaK0R0SZji6gn2M0h+pOBp7Ko2ZiIkJS83+kIrPO7+5aZcxOAsY1kb hMlIFYMLYdtNccmLML9xfvMdw8G7R01+HYfwHOu0sWBzHYwlHmx1bj/sQ5nLSNrN+SmqCZVzVL9/e JHaRc3Upkcju4lnlZJAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP7fq-0000if-4R; Mon, 28 Oct 2019 16:15:18 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP7fm-0000Hv-0u for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2019 16:15:15 +0000 Received: by mail-vs1-xe44.google.com with SMTP id y129so6706907vsc.6 for ; Mon, 28 Oct 2019 09:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NAeDGv4mmTdcJjmFC/Y5EqwPqrlxkNMDKmTxGtNGkZY=; b=cRlJ8go8Gwg5sHkB7ZS3FAbbXtnMD/tbE+zSlh/I1r1/OC/G4k2GVu3K4ZQIVtSesK qWj5vEzyZr/kwqbQ/BTQz27rlFGtYiadnB4BjwV9Aanq9y6mIcNlZgE0TDCUZmzdfMAK pYXldXOHSP6bQqOp2tqseN1pN+uwLR+zn/EQU53d0ejxptXvTV4EloD/dPmL0glR+KIS nM5OLYggHmVr1GJPpWaCLHPpHehzf5Xxk2CL48eRGzuTedh2dhf7I58eB/9um9Q2ykj/ fH8V56DN6X6u8meTksQpmCSDkwZZFwfBU/9m+m5LLJy37fUNh5yE52TZE9xDBcF8G6ck eKDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NAeDGv4mmTdcJjmFC/Y5EqwPqrlxkNMDKmTxGtNGkZY=; b=SKP4JFqqJvr8mLj5Zsop8WB5FdA25TJvllEKPvk6ZXrbc+2PaVxKejy9SfwxVC8/za cessTonZFffsBEidYs50gvQnS5MCWJPs/F7VIuaIN4gGQ8mNTd8SoQCYYWYKDu2XQlIf OrYlHHjY+J+W+Hmfy4+PPQYcCwYQ7feeQufHOBqAOODoVISIY4KYZhGblZrEPz3lU5TT UK0LHmuGvPTtsqa/amFDAGHwktWOKxyWDYK1At9f3L3QX8+sepSHP+aiELvPaLm1+NYy GVVhCYTJ3N3AMIFUk3UzmfLndgJtnLHXFhxCPLJolLWBmVujEfFBjA74W9XDBTSOZ0H+ bxsg== X-Gm-Message-State: APjAAAV50sX70cS/vx9lxTfVObZkrEPR+4BgADanaou5oI002jM8DC8x P12KcE+Qye109B8L3Qv13mjArTxJmUfHCYpnDuXFOw== X-Google-Smtp-Source: APXvYqyErnDNeReEYHXLOlOQvJxZB1LCeRqzFRFTtzuu+yjPbfij2oddf0msvyrSOjimXhfQmIZ/10I+XmQJOMeVmmI= X-Received: by 2002:a67:ffc7:: with SMTP id w7mr9278938vsq.15.1572279312128; Mon, 28 Oct 2019 09:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191024225132.13410-1-samitolvanen@google.com> <20191024225132.13410-6-samitolvanen@google.com> <2c13c39acb55df5dbb0d40c806bb1d7dc4bde2ae.camel@perches.com> In-Reply-To: From: Sami Tolvanen Date: Mon, 28 Oct 2019 09:15:00 -0700 Message-ID: Subject: Re: [PATCH v2 05/17] add support for Clang's Shadow Call Stack (SCS) To: Miguel Ojeda X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_091514_118413_E9DC869E X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Jann Horn , Catalin Marinas , Ard Biesheuvel , Nick Desaulniers , LKML , Steven Rostedt , Masahiro Yamada , Kernel Hardening , Masami Hiramatsu , clang-built-linux , Joe Perches , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 28, 2019 at 8:31 AM Miguel Ojeda wrote: > We decided to do it like that when I introduced compiler_attributes.h. > > Given it is hidden behind a definition, we don't care about which one we use internally; therefore the idea was to avoid clashes as much as possible with other names/definitions/etc. > > The syntax is supported in the compilers we care about (for docs on attributes, the best reference is GCC's by the way). Got it, thank you for explaining. I'll change this to __no_sanitize__ in v3 since Clang seems to be happy with either version. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AFC6CA9EC0 for ; Mon, 28 Oct 2019 16:15:32 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id C4B0E208C0 for ; Mon, 28 Oct 2019 16:15:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cRlJ8go8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4B0E208C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17137-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 7931 invoked by uid 550); 28 Oct 2019 16:15:25 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 7913 invoked from network); 28 Oct 2019 16:15:24 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NAeDGv4mmTdcJjmFC/Y5EqwPqrlxkNMDKmTxGtNGkZY=; b=cRlJ8go8Gwg5sHkB7ZS3FAbbXtnMD/tbE+zSlh/I1r1/OC/G4k2GVu3K4ZQIVtSesK qWj5vEzyZr/kwqbQ/BTQz27rlFGtYiadnB4BjwV9Aanq9y6mIcNlZgE0TDCUZmzdfMAK pYXldXOHSP6bQqOp2tqseN1pN+uwLR+zn/EQU53d0ejxptXvTV4EloD/dPmL0glR+KIS nM5OLYggHmVr1GJPpWaCLHPpHehzf5Xxk2CL48eRGzuTedh2dhf7I58eB/9um9Q2ykj/ fH8V56DN6X6u8meTksQpmCSDkwZZFwfBU/9m+m5LLJy37fUNh5yE52TZE9xDBcF8G6ck eKDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NAeDGv4mmTdcJjmFC/Y5EqwPqrlxkNMDKmTxGtNGkZY=; b=RnOAzu2Qsah3uwse3aqnOsy7sxSy8Oo7whhvVd2ZtdgOPevAYl6gWqqVnRtuiaTwyO nyQt8FSZ4lEvYooy/ueWsO4fSOKBTpCjbavASXa/JYe5+OOX5QXOh6sG8WYBbNsC36Rp 3wJuAGe5T9dQi7jgv2rK1xmqjP9VDj+S/Yb2Fz6iJulsyMTkEQCpQlGC9r8KbBFzGlks rax74IoNoLKo2AajrAArYWvz8KpBEfJv2rR0x2J5NBKzwng4KH0tGfHA5uwdXcwg/TsQ ZpJFINtFUSGfytRZa8J7r5ON44zBqkmfbxAjuIo5s1oFknJc5NUUlKB9zt2kGh62LCQQ lSKA== X-Gm-Message-State: APjAAAV7X6EN/xPnfCX07C2vWQjN0WehQKq//+RYAvkLhFF1c8VrquLN 6fnXX/xuQAkSF4wo8QSiKEWmWdCiinjHYnb+WDJgdg== X-Google-Smtp-Source: APXvYqyErnDNeReEYHXLOlOQvJxZB1LCeRqzFRFTtzuu+yjPbfij2oddf0msvyrSOjimXhfQmIZ/10I+XmQJOMeVmmI= X-Received: by 2002:a67:ffc7:: with SMTP id w7mr9278938vsq.15.1572279312128; Mon, 28 Oct 2019 09:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191024225132.13410-1-samitolvanen@google.com> <20191024225132.13410-6-samitolvanen@google.com> <2c13c39acb55df5dbb0d40c806bb1d7dc4bde2ae.camel@perches.com> In-Reply-To: From: Sami Tolvanen Date: Mon, 28 Oct 2019 09:15:00 -0700 Message-ID: Subject: Re: [PATCH v2 05/17] add support for Clang's Shadow Call Stack (SCS) To: Miguel Ojeda Cc: Ard Biesheuvel , Catalin Marinas , Dave Martin , Jann Horn , Joe Perches , Kees Cook , Kernel Hardening , LKML , Laura Abbott , Mark Rutland , Masahiro Yamada , Masami Hiramatsu , Nick Desaulniers , Steven Rostedt , Will Deacon , clang-built-linux , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" On Mon, Oct 28, 2019 at 8:31 AM Miguel Ojeda wrote: > We decided to do it like that when I introduced compiler_attributes.h. > > Given it is hidden behind a definition, we don't care about which one we use internally; therefore the idea was to avoid clashes as much as possible with other names/definitions/etc. > > The syntax is supported in the compilers we care about (for docs on attributes, the best reference is GCC's by the way). Got it, thank you for explaining. I'll change this to __no_sanitize__ in v3 since Clang seems to be happy with either version. Sami