From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E0E4CA9EAF for ; Mon, 21 Oct 2019 22:40:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B18C20873 for ; Mon, 21 Oct 2019 22:40:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="O/CXUAVG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730425AbfJUWkE (ORCPT ); Mon, 21 Oct 2019 18:40:04 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:34897 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729620AbfJUWkD (ORCPT ); Mon, 21 Oct 2019 18:40:03 -0400 Received: by mail-vs1-f68.google.com with SMTP id k15so1051892vsp.2 for ; Mon, 21 Oct 2019 15:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+ZsNsXP4OTYt0YNh6qKFB6AFECQX69mBiPpRVt9SfH0=; b=O/CXUAVGNYcy3a5ZMEhvYVIsdUWMdntI32aa1fCXHK7oi6GQtdX8twOyCLRtqHcLw6 am1b9fbswrT9o98uh5aDlhm1tPvl0Av/XEHc7jFDFc/FekuKFDvkdmrzLXsS+cBmnejP w+a/gseGa6WnbCp/yH1KdCdxNLv/Q43LbeRO19wQ0C6JCREDYSId7agxszZ/KRyBe4dS rBqaj2BEFPuwjg8K2IaN+ZdQ2/V18uW5p+D3bRRAW5ncrEsKECvCEFR63WSYX3IplWb4 GYGuiM7vUIXmh+zLMMdnpEno7Jg6V7tjnP6+5fo5a94md98f+1ELrfUwmGcSvu34YKiS XHeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+ZsNsXP4OTYt0YNh6qKFB6AFECQX69mBiPpRVt9SfH0=; b=LRZ432uQkVzyF1z82vbxgB446QbsulDDNGg7CYs+OGhfOeV5//zD2gdwjtA78lFHCK TxBKSkn9bkGg7dcycNHK0Mm9Xs0OCIiyS1JFgBrnWdKBgE80qApFIEC8bApIr7urs+Xx TczaTjuWqrx8xTByfb4JwtBlc2ZzQh85P0/K3pRUc5j53luaPIChLbUb9PnhZry3/rib mJ7dB9LHcjyPIN1GKyoXUHTQEkwc2p+8ZLtGhgqGIpooMFGF8abTbmwXx9YXvy2WgfQ7 tozlETmLopCaqe74zPDr7VzcM5vzNNp7fK7jwbVHMrasRRHNRAaL8kt5A6yManxSVaB2 Vz2A== X-Gm-Message-State: APjAAAXyzwfgOVOoNU0mqEoSUyJeQdsOj4ZTke3PHubliC2alCX2/mY9 yaSKT5FyblQQOvZkoVEjzutbi3wE9rkQ+KmV0XiVFg== X-Google-Smtp-Source: APXvYqy582En+heI5MQp3ZrQQ6f6MZJsAwNRRmtRSRpMZCKNBzLSU+/wxNeKwJ1tJAW4E2Y1xYNHr6jWiAAsx2LVJZQ= X-Received: by 2002:a67:ed8b:: with SMTP id d11mr100849vsp.104.1571697602070; Mon, 21 Oct 2019 15:40:02 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-15-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Mon, 21 Oct 2019 15:39:50 -0700 Message-ID: Subject: Re: [PATCH 14/18] arm64: efi: restore x18 if it was corrupted To: Ard Biesheuvel Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 20, 2019 at 11:20 PM Ard Biesheuvel wrote: > You'll have to elaborate a bit here and explain that this is > sufficient, given that we run EFI runtime services with interrupts > enabled. I can add a note about this in v2. This is called with preemption disabled and we have a separate interrupt shadow stack, so as far as I can tell, this should be sufficient. Did you have concerns about this? Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 469F5CA9EAF for ; Mon, 21 Oct 2019 22:40:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 150D520700 for ; Mon, 21 Oct 2019 22:40:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TUNzO5so"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="O/CXUAVG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 150D520700 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u64Ag+HqoWEOns3wMWCEDWooXmwpSdVW9oypkCKfknQ=; b=TUNzO5sokB2TQI z+fsxocdiGOsFWim41p9XdsdJACrg3Vv1bC4OR3sUbH+BwrzWocK9x7KSTA2qAx7QsL6fhRut5JXx v5XTpVKFP972P8bkshPeoVb7luvkgVDkSbE72WYCkEI1weukiEGFxe4lATvx49FbyvZqL1djlBxes RC9+lVNpqcXY+vU0kUzM58QHXFiJywgcMpA3wkrWPsEjw4vhApVkERNhrzFvyIjib0myOjQRrW9X0 vpaQ9e2Al0I1rqTtzlWypVZ4A6vVfKloJR2zZOMRDrgvPPRuWwKrWH5hD1E3MNwLS9FUSjgYhde9k jlvUL/rxC+EstiAipwKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMgLR-0004M2-K2; Mon, 21 Oct 2019 22:40:09 +0000 Received: from mail-vs1-xe41.google.com ([2607:f8b0:4864:20::e41]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMgLN-0003RN-8o for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2019 22:40:07 +0000 Received: by mail-vs1-xe41.google.com with SMTP id l2so10005034vsr.8 for ; Mon, 21 Oct 2019 15:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+ZsNsXP4OTYt0YNh6qKFB6AFECQX69mBiPpRVt9SfH0=; b=O/CXUAVGNYcy3a5ZMEhvYVIsdUWMdntI32aa1fCXHK7oi6GQtdX8twOyCLRtqHcLw6 am1b9fbswrT9o98uh5aDlhm1tPvl0Av/XEHc7jFDFc/FekuKFDvkdmrzLXsS+cBmnejP w+a/gseGa6WnbCp/yH1KdCdxNLv/Q43LbeRO19wQ0C6JCREDYSId7agxszZ/KRyBe4dS rBqaj2BEFPuwjg8K2IaN+ZdQ2/V18uW5p+D3bRRAW5ncrEsKECvCEFR63WSYX3IplWb4 GYGuiM7vUIXmh+zLMMdnpEno7Jg6V7tjnP6+5fo5a94md98f+1ELrfUwmGcSvu34YKiS XHeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+ZsNsXP4OTYt0YNh6qKFB6AFECQX69mBiPpRVt9SfH0=; b=fPIcwfAox1X/hGeZJH4Wk7SEMhfrpUh966ZYflmf9yAvltQaH6cL413Pr3JpN0ano2 HWCCtMChycpP/J3kfTKC0lF8sbxX4P+0L+6py75j2kpjpISYGc/u7rnMkIu1lsnzLJgL ItZqnmaZcW6VNP9zhumQ3MaM9QxlXSNnqtUu223AfTD6O+8e0FReV08kBZmQ9JEoNuXv rzk6l6y4fW6y5yK6IGq0zFrJhy9Clv2dnygwQg2P+2ojcV31R8HQxlL3pnPNP3toCGj5 vnTCMug1MZP1M9K6f+g7otlok2GcrRFqReNiHFC66rpRx2okWRfOk+zwqxgx9WN7vOWJ hzig== X-Gm-Message-State: APjAAAV39W6PVfFs+uTd7kvRFkqICw/48ur8XtU8l+ztg1DFp5T7nSl5 8Bv80iRnS+KbtYtUtNN8LX0eNgsfpP5+yjcb8m3Gzw== X-Google-Smtp-Source: APXvYqy582En+heI5MQp3ZrQQ6f6MZJsAwNRRmtRSRpMZCKNBzLSU+/wxNeKwJ1tJAW4E2Y1xYNHr6jWiAAsx2LVJZQ= X-Received: by 2002:a67:ed8b:: with SMTP id d11mr100849vsp.104.1571697602070; Mon, 21 Oct 2019 15:40:02 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-15-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Mon, 21 Oct 2019 15:39:50 -0700 Message-ID: Subject: Re: [PATCH 14/18] arm64: efi: restore x18 if it was corrupted To: Ard Biesheuvel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191021_154005_338723_353E7F8E X-CRM114-Status: UNSURE ( 9.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Kernel Hardening , Catalin Marinas , Nick Desaulniers , Linux Kernel Mailing List , Steven Rostedt , clang-built-linux , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 20, 2019 at 11:20 PM Ard Biesheuvel wrote: > You'll have to elaborate a bit here and explain that this is > sufficient, given that we run EFI runtime services with interrupts > enabled. I can add a note about this in v2. This is called with preemption disabled and we have a separate interrupt shadow stack, so as far as I can tell, this should be sufficient. Did you have concerns about this? Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0905CA9EAF for ; Mon, 21 Oct 2019 22:40:22 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 03CDD20700 for ; Mon, 21 Oct 2019 22:40:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="O/CXUAVG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03CDD20700 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17082-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 19537 invoked by uid 550); 21 Oct 2019 22:40:15 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 19517 invoked from network); 21 Oct 2019 22:40:14 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+ZsNsXP4OTYt0YNh6qKFB6AFECQX69mBiPpRVt9SfH0=; b=O/CXUAVGNYcy3a5ZMEhvYVIsdUWMdntI32aa1fCXHK7oi6GQtdX8twOyCLRtqHcLw6 am1b9fbswrT9o98uh5aDlhm1tPvl0Av/XEHc7jFDFc/FekuKFDvkdmrzLXsS+cBmnejP w+a/gseGa6WnbCp/yH1KdCdxNLv/Q43LbeRO19wQ0C6JCREDYSId7agxszZ/KRyBe4dS rBqaj2BEFPuwjg8K2IaN+ZdQ2/V18uW5p+D3bRRAW5ncrEsKECvCEFR63WSYX3IplWb4 GYGuiM7vUIXmh+zLMMdnpEno7Jg6V7tjnP6+5fo5a94md98f+1ELrfUwmGcSvu34YKiS XHeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+ZsNsXP4OTYt0YNh6qKFB6AFECQX69mBiPpRVt9SfH0=; b=bCglgDFGD0m9T+mHdsta4A/RQNB52tm5hASUVRaSvKO+tRugJm6CQ4K+IR4W4JNDEP JEeuzguNjmZf0QNNuIaCVekxwe+JiKjqyqwoMOQ8YKjQkZDBiNxQEXXMEITm9fZIL7I7 6C5RfP9W9E2iXFgWL4QZQKQpl0JqF7OjawBZOTviY3ElrCzoCkiQBWTRvPmP2+jBgEdK fnWPp8ME56hab7L8BhzoLgiiPbmCH6EkXVKNNbAXA1Erl0Ldrf1rFhMU9ACNO41XhIvt 0+nbt8gw71iB3d20I730xyHeJQrxKVIQvjySKORMwFU4KDoI83oroTQSImqtNbylIRok M6KQ== X-Gm-Message-State: APjAAAXi7BVVW6yE2cGtDR/iv8vpkwCcNTbE9nKYud5FgWBhjqbg0ZlJ f1d9b5ZRka3pTGrzpWxcn26ZeTjjgifv0evMEOoNDw== X-Google-Smtp-Source: APXvYqy582En+heI5MQp3ZrQQ6f6MZJsAwNRRmtRSRpMZCKNBzLSU+/wxNeKwJ1tJAW4E2Y1xYNHr6jWiAAsx2LVJZQ= X-Received: by 2002:a67:ed8b:: with SMTP id d11mr100849vsp.104.1571697602070; Mon, 21 Oct 2019 15:40:02 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-15-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Mon, 21 Oct 2019 15:39:50 -0700 Message-ID: Subject: Re: [PATCH 14/18] arm64: efi: restore x18 if it was corrupted To: Ard Biesheuvel Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" On Sun, Oct 20, 2019 at 11:20 PM Ard Biesheuvel wrote: > You'll have to elaborate a bit here and explain that this is > sufficient, given that we run EFI runtime services with interrupts > enabled. I can add a note about this in v2. This is called with preemption disabled and we have a separate interrupt shadow stack, so as far as I can tell, this should be sufficient. Did you have concerns about this? Sami